[GitHub] [flink] czy006 commented on a diff in pull request #21012: [FLINK-29543] Jar Run Rest Handler Support Flink Configuration

[GitBox <gi...@apache.org>]

czy006 commented on code in PR #21012:
URL: https://github.com/apache/flink/pull/21012#discussion_r995518693


##########
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarRunHandler.java:
##########
@@ -92,7 +93,20 @@ public CompletableFuture<JarRunResponseBody> handleRequest(
             @Nonnull final DispatcherGateway gateway)
             throws RestHandlerException {
 
-        final Configuration effectiveConfiguration = new Configuration(configuration);
+        Map<String, String> requestJobFlinkConfig =
+                HandlerRequestUtils.fromRequestBodyOrQueryParameter(
+                        (request.getRequestBody()).getFlinkConfiguration(),
+                        () -> null,
+                        null,
+                        this.log);
+        Configuration effectiveConfiguration;
+        if (requestJobFlinkConfig != null) {
+            effectiveConfiguration = new Configuration();
+            requestJobFlinkConfig.forEach(effectiveConfiguration::setString);

Review Comment:
   I am now changing it to
   `Configuration effectiveConfiguration = new Configuration(this.configuration);`
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org