You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "numinnex (via GitHub)" <gi...@apache.org> on 2026/03/03 14:54:22 UTC
[PR] fix(cluster): fix type mismatch for variadic plane impl [iggy]
numinnex opened a new pull request, #2857:
URL: https://github.com/apache/iggy/pull/2857
This PR fixes the problem where `Plane` trait methods were not accessible for `MuxPlane` used by the `simulator`, due to type mismatch on the `IggyPartitions` Plane implementation site.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(cluster): fix type mismatch for variadic plane impl [iggy]
Posted by "numinnex (via GitHub)" <gi...@apache.org>.
numinnex merged PR #2857:
URL: https://github.com/apache/iggy/pull/2857
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(cluster): fix type mismatch for variadic plane impl [iggy]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2857:
URL: https://github.com/apache/iggy/pull/2857#issuecomment-3991622532
## [Codecov](https://app.codecov.io/gh/apache/iggy/pull/2857?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 65.88%. Comparing base ([`be23a35`](https://app.codecov.io/gh/apache/iggy/commit/be23a351abbb77b323278370803f4d1bde75cf21?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`28c846e`](https://app.codecov.io/gh/apache/iggy/commit/28c846ee14cd8441993fde48f8153a1feaf94712?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #2857 +/- ##
============================================
- Coverage 67.94% 65.88% -2.07%
Complexity 739 739
============================================
Files 1049 974 -75
Lines 84385 78509 -5876
Branches 60963 60771 -192
============================================
- Hits 57336 51724 -5612
+ Misses 24692 24425 -267
- Partials 2357 2360 +3
```
| [Flag](https://app.codecov.io/gh/apache/iggy/pull/2857/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [node](https://app.codecov.io/gh/apache/iggy/pull/2857/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.29% <ø> (-5.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/iggy/pull/2857?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [core/metadata/src/impls/metadata.rs](https://app.codecov.io/gh/apache/iggy/pull/2857?src=pr&el=tree&filepath=core%2Fmetadata%2Fsrc%2Fimpls%2Fmetadata.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9tZXRhZGF0YS9zcmMvaW1wbHMvbWV0YWRhdGEucnM=) | `16.66% <ø> (+0.75%)` | :arrow_up: |
| [core/partitions/src/iggy\_partitions.rs](https://app.codecov.io/gh/apache/iggy/pull/2857?src=pr&el=tree&filepath=core%2Fpartitions%2Fsrc%2Figgy_partitions.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9wYXJ0aXRpb25zL3NyYy9pZ2d5X3BhcnRpdGlvbnMucnM=) | `0.00% <ø> (ø)` | |
| [core/shard/src/lib.rs](https://app.codecov.io/gh/apache/iggy/pull/2857?src=pr&el=tree&filepath=core%2Fshard%2Fsrc%2Flib.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zaGFyZC9zcmMvbGliLnJz) | `0.00% <ø> (ø)` | |
... and [93 files with indirect coverage changes](https://app.codecov.io/gh/apache/iggy/pull/2857/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org