You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2015/08/10 09:06:14 UTC

Review Request 37283: Maintenance Primitives: Refactored Master maintenance test to use V1 API.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37283/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Bugs: MESOS-1474
    https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
-------

See summary.


Diffs
-----

  src/tests/master_tests.cpp a4703afc331244a9e959c48652342f31ef787288 

Diff: https://reviews.apache.org/r/37283/diff/


Testing
-------


Thanks,

Joris Van Remoortere

Re: Review Request 37283: Maintenance Primitives: Refactored Master maintenance test to use V1 API.

Posted by Guangya Liu <gy...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37283/#review95802
-----------------------------------------------------------

Ship it!


Ship It!

- Guangya Liu


On 八月 18, 2015, 6:58 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37283/
> -----------------------------------------------------------
> 
> (Updated 八月 18, 2015, 6:58 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
>     https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_maintenance_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37283/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 37283: Maintenance Primitives: Refactored Master maintenance test to use V1 API.

Posted by Joseph Wu <jo...@mesosphere.io>.


> On Sept. 14, 2015, 4:51 p.m., Qian Zhang wrote:
> > src/tests/master_maintenance_tests.cpp, line 418
> > <https://reviews.apache.org/r/37283/diff/6/?file=1071196#file1071196line418>
> >
> >     I checked v1/mesos.proto, and found regular offer also has unavailability:
> >     ```
> >     optional Unavailability unavailability = 9;
> >     ```

That comment is saying, "the first set of offers in this test should not have `unavailability` set".

I think you misunderstood it to be: "offers don't have an `unavailability` field".


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37283/#review98964
-----------------------------------------------------------


On Sept. 13, 2015, 1:33 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37283/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2015, 1:33 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
>     https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_maintenance_tests.cpp fb8dca3757a9565d5eb5a69eed10aa34602bb15c 
> 
> Diff: https://reviews.apache.org/r/37283/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>