You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/06 10:02:14 UTC

[GitHub] [flink] Myracle opened a new pull request, #20182: [FLINK-28003][Table SQL / Client] Disable SqlCompleter when using -f {file}

Myracle opened a new pull request, #20182:
URL: https://github.com/apache/flink/pull/20182

   ## What is the purpose of the change
   
   *When starting job using hive sql file in SQL client, the sql may be modified by SqlCompleter, for example, 'pos' field is changed to 'POSITION'. So it is better to disable SqlCompleter when using -f {file} in SQL client.*
   
   
   ## Brief change log
   
   *(for example:)*
     - *Disable SqlCompleter when using sql file.*
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
     - *Add test testExecuteSqlFileWithoutSqlCompleter and testExecuteSqlInteractiveWithSqlCompleter in class CliClientTest*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #20182: [FLINK-28003][Table SQL / Client] Disable SqlCompleter when using -f {file}

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20182:
URL: https://github.com/apache/flink/pull/20182#issuecomment-1176039833

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f414eb8a1aa55567963181fe8f7de70d88b6bcb7",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f414eb8a1aa55567963181fe8f7de70d88b6bcb7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f414eb8a1aa55567963181fe8f7de70d88b6bcb7 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wuchong merged pull request #20182: [FLINK-28003][Table SQL / Client] Disable SqlCompleter when using -f {file}

Posted by GitBox <gi...@apache.org>.
wuchong merged PR #20182:
URL: https://github.com/apache/flink/pull/20182


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org