(trafficserver) branch master updated: Coverity 1497238: Uninitialized scalar variable in DiagsConfigState class (#10837)

[bc...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

bcall pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/master by this push:
     new 0fcfb27be0 Coverity 1497238: Uninitialized scalar variable in DiagsConfigState class (#10837)
0fcfb27be0 is described below

commit 0fcfb27be095254e55a6993444a74ac3ae7171cd
Author: Bryan Call <bc...@apache.org>
AuthorDate: Mon Nov 27 12:50:43 2023 -0800

    Coverity 1497238: Uninitialized scalar variable in DiagsConfigState class (#10837)
---
 src/proxy/shared/DiagsConfig.cc | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/src/proxy/shared/DiagsConfig.cc b/src/proxy/shared/DiagsConfig.cc
index 2adf3d83a8..da6ca53446 100644
--- a/src/proxy/shared/DiagsConfig.cc
+++ b/src/proxy/shared/DiagsConfig.cc
@@ -143,14 +143,10 @@ DiagsConfig::reconfigure_diags()
     _diags->activate_taglist((_diags->base_debug_tags ? _diags->base_debug_tags : dt), DiagsTagType_Debug);
     _diags->activate_taglist((_diags->base_action_tags ? _diags->base_action_tags : at), DiagsTagType_Action);
 
-////////////////////////////////////
-// change the diags config values //
-////////////////////////////////////
-#if !defined(__GNUC__)
+    ////////////////////////////////////
+    // change the diags config values //
+    ////////////////////////////////////
     _diags->config = c;
-#else
-    memcpy(((void *)&_diags->config), ((void *)&c), sizeof(DiagsConfigState));
-#endif
     Note("updated diags config");
   }