You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "vinothchandar (via GitHub)" <gi...@apache.org> on 2025/12/12 21:46:22 UTC

[PR] refactor: code sweep on hudi-io to streamline package and class organization [hudi]

vinothchandar opened a new pull request, #17586:
URL: https://github.com/apache/hudi/pull/17586

   ### Describe the issue this Pull Request addresses
   
   hudi-io has some remnants from the hudi-hadoop-common vs hudi-common refactoring, classes that need to be homed correctly.
   
   ### Summary and Changelog
   
   refactor: moving RetryHelper to hudi-common
   refactor: Moving FileIOUtils to io.utils package
   refactor: Moving ConsistencyGuard to hudi-common
   refactor: move ByteBufferBackedInputStream to the .io package
   
   
   ### Impact
   
   none 
   
   ### Risk Level
   none 
   
   ### Documentation Update
   none
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Enough context is provided in the sections above
   - [ ] Adequate tests were added if applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: code sweep on hudi-io, hudi-hadoop-mr to streamline class organization [hudi]

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #17586:
URL: https://github.com/apache/hudi/pull/17586#discussion_r2615995988


##########
hudi-common/src/test/java/org/apache/hudi/common/util/io/TestByteBufferBackedInputStream.java:
##########
@@ -78,7 +80,7 @@ public void testRead() {
   public void testSeek() {
     byte[] sourceBytes = { 0xD, 0xE, 0xA, 0xD, 0xD, 0xA, 0xE, 0xD };
 
-    ByteBufferBackedInputStream stream = new ByteBufferBackedInputStream(sourceBytes, 1, 7);
+    org.apache.hudi.io.ByteBufferBackedInputStream stream = new org.apache.hudi.io.ByteBufferBackedInputStream(sourceBytes, 1, 7);

Review Comment:
   Import the class for brevity?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: code sweep on hudi-io, hudi-hadoop-mr to streamline class organization [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17586:
URL: https://github.com/apache/hudi/pull/17586#issuecomment-3648537746

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c279217bf11b01975ad959a84c7630791117d3f4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10191",
       "triggerID" : "c279217bf11b01975ad959a84c7630791117d3f4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f9cf5f66a240a5c2d4e59a0ed60ad1f1d4d4630b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f9cf5f66a240a5c2d4e59a0ed60ad1f1d4d4630b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8cb4cbe2777bfbf758a865dcfa49d5f614c1917b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10192",
       "triggerID" : "8cb4cbe2777bfbf758a865dcfa49d5f614c1917b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e3f7bc00e78abbbab6ddf275e8ebe61e8e533265",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10193",
       "triggerID" : "e3f7bc00e78abbbab6ddf275e8ebe61e8e533265",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f9cf5f66a240a5c2d4e59a0ed60ad1f1d4d4630b UNKNOWN
   * 8cb4cbe2777bfbf758a865dcfa49d5f614c1917b Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10192) 
   * e3f7bc00e78abbbab6ddf275e8ebe61e8e533265 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10193) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: code sweep on hudi-io, hudi-hadoop-mr to streamline class organization [hudi]

Posted by "vinothchandar (via GitHub)" <gi...@apache.org>.
vinothchandar commented on code in PR #17586:
URL: https://github.com/apache/hudi/pull/17586#discussion_r2616013588


##########
hudi-io/src/main/java/org/apache/hudi/io/util/FileIOUtils.java:
##########
@@ -7,18 +7,18 @@
  * "License"); you may not use this file except in compliance
  * with the License.  You may obtain a copy of the License at
  *
- *   http://www.apache.org/licenses/LICENSE-2.0
+ *      http://www.apache.org/licenses/LICENSE-2.0
  *
- * Unless required by applicable law or agreed to in writing,

Review Comment:
   i think its the whitespace thats causing the diff. will fix



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: code sweep on hudi-io, hudi-hadoop-mr to streamline class organization [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17586:
URL: https://github.com/apache/hudi/pull/17586#issuecomment-3648430718

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c279217bf11b01975ad959a84c7630791117d3f4",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10191",
       "triggerID" : "c279217bf11b01975ad959a84c7630791117d3f4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f9cf5f66a240a5c2d4e59a0ed60ad1f1d4d4630b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f9cf5f66a240a5c2d4e59a0ed60ad1f1d4d4630b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8cb4cbe2777bfbf758a865dcfa49d5f614c1917b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10192",
       "triggerID" : "8cb4cbe2777bfbf758a865dcfa49d5f614c1917b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c279217bf11b01975ad959a84c7630791117d3f4 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10191) 
   * f9cf5f66a240a5c2d4e59a0ed60ad1f1d4d4630b UNKNOWN
   * 8cb4cbe2777bfbf758a865dcfa49d5f614c1917b Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10192) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: code sweep on hudi-io, hudi-hadoop-mr to streamline class organization [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17586:
URL: https://github.com/apache/hudi/pull/17586#issuecomment-3648697859

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c279217bf11b01975ad959a84c7630791117d3f4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10191",
       "triggerID" : "c279217bf11b01975ad959a84c7630791117d3f4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f9cf5f66a240a5c2d4e59a0ed60ad1f1d4d4630b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f9cf5f66a240a5c2d4e59a0ed60ad1f1d4d4630b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8cb4cbe2777bfbf758a865dcfa49d5f614c1917b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10192",
       "triggerID" : "8cb4cbe2777bfbf758a865dcfa49d5f614c1917b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e3f7bc00e78abbbab6ddf275e8ebe61e8e533265",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10193",
       "triggerID" : "e3f7bc00e78abbbab6ddf275e8ebe61e8e533265",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f9cf5f66a240a5c2d4e59a0ed60ad1f1d4d4630b UNKNOWN
   * e3f7bc00e78abbbab6ddf275e8ebe61e8e533265 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10193) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: code sweep on hudi-io, hudi-hadoop-mr to streamline class organization [hudi]

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #17586:
URL: https://github.com/apache/hudi/pull/17586#discussion_r2615998229


##########
hudi-common/src/test/java/org/apache/hudi/common/util/io/TestByteBufferBackedInputStream.java:
##########
@@ -38,20 +40,20 @@ public void testConstructor() {
     ByteBuffer byteBufClone = byteBuf.duplicate();
 
     // ByteBuffer ctor
-    ByteBufferBackedInputStream first = new ByteBufferBackedInputStream(byteBuf);
+    org.apache.hudi.io.ByteBufferBackedInputStream first = new org.apache.hudi.io.ByteBufferBackedInputStream(byteBuf);

Review Comment:
   No need of package prefix?



##########
hudi-common/src/test/java/org/apache/hudi/common/util/io/TestByteBufferBackedInputStream.java:
##########
@@ -38,20 +40,20 @@ public void testConstructor() {
     ByteBuffer byteBufClone = byteBuf.duplicate();
 
     // ByteBuffer ctor
-    ByteBufferBackedInputStream first = new ByteBufferBackedInputStream(byteBuf);
+    org.apache.hudi.io.ByteBufferBackedInputStream first = new org.apache.hudi.io.ByteBufferBackedInputStream(byteBuf);
 
     assertEquals(first.read(), 0xD);
     assertThrows(IllegalArgumentException.class, first::read);
     // Make sure that the original buffer stays intact
     assertEquals(byteBufClone, byteBuf);
 
     // byte[] ctor
-    ByteBufferBackedInputStream second = new ByteBufferBackedInputStream(bytes);
+    org.apache.hudi.io.ByteBufferBackedInputStream second = new org.apache.hudi.io.ByteBufferBackedInputStream(bytes);

Review Comment:
   Same here and other similar lines



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: code sweep on hudi-io, hudi-hadoop-mr to streamline class organization [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17586:
URL: https://github.com/apache/hudi/pull/17586#issuecomment-3648953401

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c279217bf11b01975ad959a84c7630791117d3f4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10191",
       "triggerID" : "c279217bf11b01975ad959a84c7630791117d3f4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f9cf5f66a240a5c2d4e59a0ed60ad1f1d4d4630b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f9cf5f66a240a5c2d4e59a0ed60ad1f1d4d4630b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8cb4cbe2777bfbf758a865dcfa49d5f614c1917b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10192",
       "triggerID" : "8cb4cbe2777bfbf758a865dcfa49d5f614c1917b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e3f7bc00e78abbbab6ddf275e8ebe61e8e533265",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10193",
       "triggerID" : "e3f7bc00e78abbbab6ddf275e8ebe61e8e533265",
       "triggerType" : "PUSH"
     }, {
       "hash" : "209b11ec97227c638ab1ed8487ba8785a76a2169",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10196",
       "triggerID" : "209b11ec97227c638ab1ed8487ba8785a76a2169",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f9cf5f66a240a5c2d4e59a0ed60ad1f1d4d4630b UNKNOWN
   * 209b11ec97227c638ab1ed8487ba8785a76a2169 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10196) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: code sweep on hudi-io, hudi-hadoop-mr to streamline class organization [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17586:
URL: https://github.com/apache/hudi/pull/17586#issuecomment-3648421382

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c279217bf11b01975ad959a84c7630791117d3f4",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10191",
       "triggerID" : "c279217bf11b01975ad959a84c7630791117d3f4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f9cf5f66a240a5c2d4e59a0ed60ad1f1d4d4630b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f9cf5f66a240a5c2d4e59a0ed60ad1f1d4d4630b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8cb4cbe2777bfbf758a865dcfa49d5f614c1917b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10192",
       "triggerID" : "8cb4cbe2777bfbf758a865dcfa49d5f614c1917b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c279217bf11b01975ad959a84c7630791117d3f4 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10191) 
   * f9cf5f66a240a5c2d4e59a0ed60ad1f1d4d4630b UNKNOWN
   * 8cb4cbe2777bfbf758a865dcfa49d5f614c1917b Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10192) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: code sweep on hudi-io, hudi-hadoop-mr to streamline class organization [hudi]

Posted by "vinothchandar (via GitHub)" <gi...@apache.org>.
vinothchandar commented on PR #17586:
URL: https://github.com/apache/hudi/pull/17586#issuecomment-3648779452

   @yihua Looks like IntelliJ got the full packages added. idk why. I ll skim again and fix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: code sweep on hudi-io to streamline package and class organization [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17586:
URL: https://github.com/apache/hudi/pull/17586#issuecomment-3648252734

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c279217bf11b01975ad959a84c7630791117d3f4",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c279217bf11b01975ad959a84c7630791117d3f4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c279217bf11b01975ad959a84c7630791117d3f4 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: code sweep on hudi-io, hudi-hadoop-mr to streamline class organization [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17586:
URL: https://github.com/apache/hudi/pull/17586#issuecomment-3648516892

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c279217bf11b01975ad959a84c7630791117d3f4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10191",
       "triggerID" : "c279217bf11b01975ad959a84c7630791117d3f4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f9cf5f66a240a5c2d4e59a0ed60ad1f1d4d4630b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f9cf5f66a240a5c2d4e59a0ed60ad1f1d4d4630b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8cb4cbe2777bfbf758a865dcfa49d5f614c1917b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10192",
       "triggerID" : "8cb4cbe2777bfbf758a865dcfa49d5f614c1917b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f9cf5f66a240a5c2d4e59a0ed60ad1f1d4d4630b UNKNOWN
   * 8cb4cbe2777bfbf758a865dcfa49d5f614c1917b Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10192) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: code sweep on hudi-io, hudi-hadoop-mr to streamline class organization [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17586:
URL: https://github.com/apache/hudi/pull/17586#issuecomment-3648815235

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c279217bf11b01975ad959a84c7630791117d3f4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10191",
       "triggerID" : "c279217bf11b01975ad959a84c7630791117d3f4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f9cf5f66a240a5c2d4e59a0ed60ad1f1d4d4630b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f9cf5f66a240a5c2d4e59a0ed60ad1f1d4d4630b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8cb4cbe2777bfbf758a865dcfa49d5f614c1917b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10192",
       "triggerID" : "8cb4cbe2777bfbf758a865dcfa49d5f614c1917b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e3f7bc00e78abbbab6ddf275e8ebe61e8e533265",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10193",
       "triggerID" : "e3f7bc00e78abbbab6ddf275e8ebe61e8e533265",
       "triggerType" : "PUSH"
     }, {
       "hash" : "209b11ec97227c638ab1ed8487ba8785a76a2169",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "209b11ec97227c638ab1ed8487ba8785a76a2169",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f9cf5f66a240a5c2d4e59a0ed60ad1f1d4d4630b UNKNOWN
   * e3f7bc00e78abbbab6ddf275e8ebe61e8e533265 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10193) 
   * 209b11ec97227c638ab1ed8487ba8785a76a2169 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: code sweep on hudi-io, hudi-hadoop-mr to streamline class organization [hudi]

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua merged PR #17586:
URL: https://github.com/apache/hudi/pull/17586


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: code sweep on hudi-io, hudi-hadoop-mr to streamline class organization [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17586:
URL: https://github.com/apache/hudi/pull/17586#issuecomment-3648402451

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c279217bf11b01975ad959a84c7630791117d3f4",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10191",
       "triggerID" : "c279217bf11b01975ad959a84c7630791117d3f4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f9cf5f66a240a5c2d4e59a0ed60ad1f1d4d4630b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f9cf5f66a240a5c2d4e59a0ed60ad1f1d4d4630b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8cb4cbe2777bfbf758a865dcfa49d5f614c1917b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8cb4cbe2777bfbf758a865dcfa49d5f614c1917b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c279217bf11b01975ad959a84c7630791117d3f4 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10191) 
   * f9cf5f66a240a5c2d4e59a0ed60ad1f1d4d4630b UNKNOWN
   * 8cb4cbe2777bfbf758a865dcfa49d5f614c1917b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: code sweep on hudi-io, hudi-hadoop-mr to streamline class organization [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17586:
URL: https://github.com/apache/hudi/pull/17586#issuecomment-3648524963

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c279217bf11b01975ad959a84c7630791117d3f4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10191",
       "triggerID" : "c279217bf11b01975ad959a84c7630791117d3f4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f9cf5f66a240a5c2d4e59a0ed60ad1f1d4d4630b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f9cf5f66a240a5c2d4e59a0ed60ad1f1d4d4630b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8cb4cbe2777bfbf758a865dcfa49d5f614c1917b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10192",
       "triggerID" : "8cb4cbe2777bfbf758a865dcfa49d5f614c1917b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e3f7bc00e78abbbab6ddf275e8ebe61e8e533265",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "e3f7bc00e78abbbab6ddf275e8ebe61e8e533265",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f9cf5f66a240a5c2d4e59a0ed60ad1f1d4d4630b UNKNOWN
   * 8cb4cbe2777bfbf758a865dcfa49d5f614c1917b Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10192) 
   * e3f7bc00e78abbbab6ddf275e8ebe61e8e533265 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: code sweep on hudi-io, hudi-hadoop-mr to streamline class organization [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17586:
URL: https://github.com/apache/hudi/pull/17586#issuecomment-3648881621

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c279217bf11b01975ad959a84c7630791117d3f4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10191",
       "triggerID" : "c279217bf11b01975ad959a84c7630791117d3f4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f9cf5f66a240a5c2d4e59a0ed60ad1f1d4d4630b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f9cf5f66a240a5c2d4e59a0ed60ad1f1d4d4630b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8cb4cbe2777bfbf758a865dcfa49d5f614c1917b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10192",
       "triggerID" : "8cb4cbe2777bfbf758a865dcfa49d5f614c1917b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e3f7bc00e78abbbab6ddf275e8ebe61e8e533265",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10193",
       "triggerID" : "e3f7bc00e78abbbab6ddf275e8ebe61e8e533265",
       "triggerType" : "PUSH"
     }, {
       "hash" : "209b11ec97227c638ab1ed8487ba8785a76a2169",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10196",
       "triggerID" : "209b11ec97227c638ab1ed8487ba8785a76a2169",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f9cf5f66a240a5c2d4e59a0ed60ad1f1d4d4630b UNKNOWN
   * e3f7bc00e78abbbab6ddf275e8ebe61e8e533265 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10193) 
   * 209b11ec97227c638ab1ed8487ba8785a76a2169 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10196) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: code sweep on hudi-io, hudi-hadoop-mr to streamline class organization [hudi]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #17586:
URL: https://github.com/apache/hudi/pull/17586#discussion_r2615991031


##########
hudi-hadoop-common/src/test/java/org/apache/hudi/common/util/TestFileIOUtils.java:
##########
@@ -45,36 +46,36 @@ public class TestFileIOUtils extends HoodieCommonTestHarness {
   @Test
   public void testMkdirAndDelete() throws IOException {
     try {
-      FileIOUtils.mkdir(tempDir.toFile());
+      org.apache.hudi.io.util.FileIOUtils.mkdir(tempDir.toFile());
     } catch (IOException e) {
       fail("Should not error out if dir exists already");
     }
     File dir = tempDir.resolve("dir").toFile();
-    FileIOUtils.mkdir(dir);
+    org.apache.hudi.io.util.FileIOUtils.mkdir(dir);
     assertTrue(dir.exists());
 
     new File(dir, "t.txt").createNewFile();
     new File(dir, "subdir").mkdirs();
     new File(dir, "subdir" + File.pathSeparator + "z.txt").createNewFile();
-    FileIOUtils.deleteDirectory(dir);
+    org.apache.hudi.io.util.FileIOUtils.deleteDirectory(dir);
     assertFalse(dir.exists());
   }
 
   @Test
   public void testInputStreamReads() throws IOException {
     String msg = "hudi rocks!";
     ByteArrayInputStream inputStream = new ByteArrayInputStream(getUTF8Bytes(msg));
-    assertEquals(msg, FileIOUtils.readAsUTFString(inputStream));
+    assertEquals(msg, org.apache.hudi.io.util.FileIOUtils.readAsUTFString(inputStream));
     inputStream = new ByteArrayInputStream(getUTF8Bytes(msg));
-    assertEquals(msg.length(), FileIOUtils.readAsByteArray(inputStream).length);
+    assertEquals(msg.length(), org.apache.hudi.io.util.FileIOUtils.readAsByteArray(inputStream).length);
   }
 
   @Test
   public void testReadAsUTFStringLines() {
     String content = "a\nb\nc";
     List<String> expectedLines = Arrays.stream(new String[] {"a", "b", "c"}).collect(Collectors.toList());
     ByteArrayInputStream inputStream = new ByteArrayInputStream(getUTF8Bytes(content));
-    assertEquals(expectedLines, FileIOUtils.readAsUTFStringLines(inputStream));
+    assertEquals(expectedLines, org.apache.hudi.io.util.FileIOUtils.readAsUTFStringLines(inputStream));

Review Comment:
   The method call uses a fully qualified name `org.apache.hudi.io.util.FileIOUtils` even though FileIOUtils is already imported at line 22. For better code readability, the fully qualified name should be replaced with the simple class name `FileIOUtils` to be consistent with the import statement.



##########
hudi-common/src/test/java/org/apache/hudi/common/util/io/TestByteBufferBackedInputStream.java:
##########
@@ -78,7 +80,7 @@ public void testRead() {
   public void testSeek() {
     byte[] sourceBytes = { 0xD, 0xE, 0xA, 0xD, 0xD, 0xA, 0xE, 0xD };
 
-    ByteBufferBackedInputStream stream = new ByteBufferBackedInputStream(sourceBytes, 1, 7);
+    org.apache.hudi.io.ByteBufferBackedInputStream stream = new org.apache.hudi.io.ByteBufferBackedInputStream(sourceBytes, 1, 7);

Review Comment:
   The constructor call uses a fully qualified name `org.apache.hudi.io.ByteBufferBackedInputStream` even though ByteBufferBackedInputStream is already imported at line 21. For better code readability, the fully qualified name should be replaced with the simple class name `ByteBufferBackedInputStream` to be consistent with the import statement.



##########
hudi-common/src/test/java/org/apache/hudi/common/util/io/TestByteBufferBackedInputStream.java:
##########
@@ -61,7 +63,7 @@ public void testConstructor() {
   public void testRead() {
     byte[] sourceBytes = { 0xD, 0xE, 0xA, 0xD, 0xD, 0xE, 0xE, 0xD };
 
-    ByteBufferBackedInputStream stream = new ByteBufferBackedInputStream(sourceBytes);
+    org.apache.hudi.io.ByteBufferBackedInputStream stream = new org.apache.hudi.io.ByteBufferBackedInputStream(sourceBytes);

Review Comment:
   The constructor call uses a fully qualified name `org.apache.hudi.io.ByteBufferBackedInputStream` even though ByteBufferBackedInputStream is already imported at line 21. For better code readability, the fully qualified name should be replaced with the simple class name `ByteBufferBackedInputStream` to be consistent with the import statement.



##########
hudi-hadoop-common/src/test/java/org/apache/hudi/common/util/TestFileIOUtils.java:
##########
@@ -90,10 +91,10 @@ public void testGetConfiguredLocalDirs() {
     } catch (NoSuchFieldException | IllegalAccessException e) {
       throw new IllegalArgumentException(e);
     }
-    assertEquals(String.join("", FileIOUtils.getConfiguredLocalDirs()),
+    assertEquals(String.join("", org.apache.hudi.io.util.FileIOUtils.getConfiguredLocalDirs()),
             System.getProperty("java.io.tmpdir"));
     envMaps.put("LOCAL_DIRS", "/xxx");
-    assertEquals(String.join("", FileIOUtils.getConfiguredLocalDirs()),
+    assertEquals(String.join("", org.apache.hudi.io.util.FileIOUtils.getConfiguredLocalDirs()),
             envMaps.get("LOCAL_DIRS"));
   }
 

Review Comment:
   The method calls in this test use fully qualified names `org.apache.hudi.io.util.FileIOUtils` even though FileIOUtils is already imported at line 22. For better code readability, the fully qualified names should be replaced with the simple class name `FileIOUtils` to be consistent with the import statement.



##########
hudi-hadoop-common/src/test/java/org/apache/hudi/common/util/TestFileIOUtils.java:
##########
@@ -104,7 +105,7 @@ public void testGetDefaultSpillableMapBasePath() {
 
     // Case when local dirs provided
     System.setProperty("java.io.tmpdir", "dir1,dir2,dir3");
-    String result = FileIOUtils.getDefaultSpillableMapBasePath();
+    String result = org.apache.hudi.io.util.FileIOUtils.getDefaultSpillableMapBasePath();

Review Comment:
   The method call uses a fully qualified name `org.apache.hudi.io.util.FileIOUtils` even though FileIOUtils is already imported at line 22. For better code readability, the fully qualified name should be replaced with the simple class name `FileIOUtils` to be consistent with the import statement.



##########
hudi-common/src/main/java/org/apache/hudi/common/util/MarkerUtils.java:
##########
@@ -119,7 +120,7 @@ public static Option<MarkerType> readMarkerType(HoodieStorage storage, String ma
         return Option.empty();
       }
       inputStream = storage.open(markerTypeFilePath);
-      String markerType = FileIOUtils.readAsUTFString(inputStream);
+      String markerType = org.apache.hudi.io.util.FileIOUtils.readAsUTFString(inputStream);

Review Comment:
   Inconsistent usage of FileIOUtils reference. Line 123 uses the fully qualified name `org.apache.hudi.io.util.FileIOUtils.readAsUTFString()` while FileIOUtils is already imported at line 30 (via static import of closeQuietly at line 56). This should use the simple class name `FileIOUtils.readAsUTFString()` for consistency.
   ```suggestion
         String markerType = FileIOUtils.readAsUTFString(inputStream);
   ```



##########
hudi-hadoop-common/src/test/java/org/apache/hudi/common/util/TestFileIOUtils.java:
##########
@@ -45,36 +46,36 @@ public class TestFileIOUtils extends HoodieCommonTestHarness {
   @Test
   public void testMkdirAndDelete() throws IOException {
     try {
-      FileIOUtils.mkdir(tempDir.toFile());
+      org.apache.hudi.io.util.FileIOUtils.mkdir(tempDir.toFile());
     } catch (IOException e) {
       fail("Should not error out if dir exists already");
     }
     File dir = tempDir.resolve("dir").toFile();
-    FileIOUtils.mkdir(dir);
+    org.apache.hudi.io.util.FileIOUtils.mkdir(dir);
     assertTrue(dir.exists());
 
     new File(dir, "t.txt").createNewFile();
     new File(dir, "subdir").mkdirs();
     new File(dir, "subdir" + File.pathSeparator + "z.txt").createNewFile();
-    FileIOUtils.deleteDirectory(dir);
+    org.apache.hudi.io.util.FileIOUtils.deleteDirectory(dir);
     assertFalse(dir.exists());
   }
 

Review Comment:
   The method calls in this test use fully qualified names `org.apache.hudi.io.util.FileIOUtils` even though FileIOUtils is already imported at line 22. For better code readability, the fully qualified names should be replaced with the simple class name `FileIOUtils` to be consistent with the import statement.



##########
hudi-hadoop-common/src/test/java/org/apache/hudi/common/util/TestFileIOUtils.java:
##########
@@ -45,36 +46,36 @@ public class TestFileIOUtils extends HoodieCommonTestHarness {
   @Test
   public void testMkdirAndDelete() throws IOException {
     try {
-      FileIOUtils.mkdir(tempDir.toFile());
+      org.apache.hudi.io.util.FileIOUtils.mkdir(tempDir.toFile());
     } catch (IOException e) {
       fail("Should not error out if dir exists already");
     }
     File dir = tempDir.resolve("dir").toFile();
-    FileIOUtils.mkdir(dir);
+    org.apache.hudi.io.util.FileIOUtils.mkdir(dir);
     assertTrue(dir.exists());
 
     new File(dir, "t.txt").createNewFile();
     new File(dir, "subdir").mkdirs();
     new File(dir, "subdir" + File.pathSeparator + "z.txt").createNewFile();
-    FileIOUtils.deleteDirectory(dir);
+    org.apache.hudi.io.util.FileIOUtils.deleteDirectory(dir);
     assertFalse(dir.exists());
   }
 
   @Test
   public void testInputStreamReads() throws IOException {
     String msg = "hudi rocks!";
     ByteArrayInputStream inputStream = new ByteArrayInputStream(getUTF8Bytes(msg));
-    assertEquals(msg, FileIOUtils.readAsUTFString(inputStream));
+    assertEquals(msg, org.apache.hudi.io.util.FileIOUtils.readAsUTFString(inputStream));
     inputStream = new ByteArrayInputStream(getUTF8Bytes(msg));
-    assertEquals(msg.length(), FileIOUtils.readAsByteArray(inputStream).length);
+    assertEquals(msg.length(), org.apache.hudi.io.util.FileIOUtils.readAsByteArray(inputStream).length);
   }
 
   @Test

Review Comment:
   The method calls in this test use fully qualified names `org.apache.hudi.io.util.FileIOUtils` even though FileIOUtils is already imported at line 22. For better code readability, the fully qualified names should be replaced with the simple class name `FileIOUtils` to be consistent with the import statement.



##########
hudi-hadoop-common/src/main/java/org/apache/hudi/common/util/ParquetReaderIterator.java:
##########
@@ -50,7 +51,7 @@ public boolean hasNext() {
       }
       return this.next != null;
     } catch (Exception e) {
-      FileIOUtils.closeQuietly(parquetReader);
+      org.apache.hudi.io.util.FileIOUtils.closeQuietly(parquetReader);

Review Comment:
   Inconsistent usage of FileIOUtils reference. Line 54 uses the fully qualified name `org.apache.hudi.io.util.FileIOUtils.closeQuietly()` while FileIOUtils is already imported at line 24. This should use the simple class name `FileIOUtils.closeQuietly()` for consistency, matching the usage on line 72.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: code sweep on hudi-io to streamline package and class organization [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17586:
URL: https://github.com/apache/hudi/pull/17586#issuecomment-3648256712

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c279217bf11b01975ad959a84c7630791117d3f4",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10191",
       "triggerID" : "c279217bf11b01975ad959a84c7630791117d3f4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c279217bf11b01975ad959a84c7630791117d3f4 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10191) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: code sweep on hudi-io, hudi-hadoop-mr to streamline class organization [hudi]

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #17586:
URL: https://github.com/apache/hudi/pull/17586#discussion_r2616001512


##########
hudi-io/src/main/java/org/apache/hudi/io/util/FileIOUtils.java:
##########
@@ -7,18 +7,18 @@
  * "License"); you may not use this file except in compliance
  * with the License.  You may obtain a copy of the License at
  *
- *   http://www.apache.org/licenses/LICENSE-2.0
+ *      http://www.apache.org/licenses/LICENSE-2.0
  *
- * Unless required by applicable law or agreed to in writing,

Review Comment:
   I think this is the new format of the license header (https://www.apache.org/legal/src-headers#headers).  We should keep using this one.



##########
hudi-hadoop-common/src/main/java/org/apache/hudi/common/util/ParquetReaderIterator.java:
##########
@@ -50,7 +51,7 @@ public boolean hasNext() {
       }
       return this.next != null;
     } catch (Exception e) {
-      FileIOUtils.closeQuietly(parquetReader);
+      org.apache.hudi.io.util.FileIOUtils.closeQuietly(parquetReader);

Review Comment:
   +1



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: code sweep on hudi-io, hudi-hadoop-mr to streamline class organization [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17586:
URL: https://github.com/apache/hudi/pull/17586#issuecomment-3648385739

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c279217bf11b01975ad959a84c7630791117d3f4",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10191",
       "triggerID" : "c279217bf11b01975ad959a84c7630791117d3f4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f9cf5f66a240a5c2d4e59a0ed60ad1f1d4d4630b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f9cf5f66a240a5c2d4e59a0ed60ad1f1d4d4630b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c279217bf11b01975ad959a84c7630791117d3f4 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10191) 
   * f9cf5f66a240a5c2d4e59a0ed60ad1f1d4d4630b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org