You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/06/20 10:55:46 UTC

[GitHub] [maven-resolver] michael-o opened a new pull request #113: Null implementations shall return null

michael-o opened a new pull request #113:
URL: https://github.com/apache/maven-resolver/pull/113


   @cstamas This breaks stuff and should be in 2.x only. The motivation is that if the class name says `Null...` it shall return `null` and not be a `Default...` impl. WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-resolver] michael-o commented on pull request #113: Null implementations shall return null

Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #113:
URL: https://github.com/apache/maven-resolver/pull/113#issuecomment-864584498


   > 
   > Null impl does not mean that a method returns null. It means that the class and method does nothing - no behavior. 
   
   I don't understand that. How can be no behaivor if it invokes a getter?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-resolver] Tibor17 commented on pull request #113: Null implementations shall return null

Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #113:
URL: https://github.com/apache/maven-resolver/pull/113#issuecomment-864582160


   Null impl does not mean that a method returns null. It means that the class
   and method does nothing - no behavior.
   
   Dňa ne 20. 6. 2021, 12:55 Michael Osipov ***@***.***>
   napísal(a):
   
   > @cstamas <https://github.com/cstamas> This breaks stuff and should be in
   > 2.x only. The motivation is that if the class name says Null... it shall
   > return null and not be a Default... impl. WDYT?
   > ------------------------------
   > You can view, comment on, or merge this pull request online at:
   >
   >   https://github.com/apache/maven-resolver/pull/113
   > Commit Summary
   >
   >    - Null implementations shall return null
   >
   > File Changes
   >
   >    - *M*
   >    maven-resolver-api/src/main/java/org/eclipse/aether/DefaultRepositorySystemSession.java
   >    <https://github.com/apache/maven-resolver/pull/113/files#diff-f1c0b545239dff473550ca53cab44bf3054c7e7ce915b9ad40ef5b865a165426>
   >    (4)
   >
   > Patch Links:
   >
   >    - https://github.com/apache/maven-resolver/pull/113.patch
   >    - https://github.com/apache/maven-resolver/pull/113.diff
   >
   > —
   > You are receiving this because you are subscribed to this thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/maven-resolver/pull/113>, or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AAH7ER7CPXFIWKXFG3DSWH3TTXCLLANCNFSM4676ZRHA>
   > .
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-resolver] Tibor17 commented on pull request #113: Null implementations shall return null

Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #113:
URL: https://github.com/apache/maven-resolver/pull/113#issuecomment-865268516


   Every Null...Class means no behavior. The generál terminology. Also
   nongetter methods.
   
   Dňa ne 20. 6. 2021, 19:10 Michael Osipov ***@***.***>
   napísal(a):
   
   > Null impl does not mean that a method returns null. It means that the
   > class and method does nothing - no behavior.
   >
   > I don't understand that. How can be no behaivor if it invokes a getter?
   >
   > —
   > You are receiving this because you commented.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/maven-resolver/pull/113#issuecomment-864584498>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AAH7ER4JTKJIEEPV3UEDOEDTTYOJLANCNFSM4676ZRHA>
   > .
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-resolver] Tibor17 commented on pull request #113: Null implementations shall return null

Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #113:
URL: https://github.com/apache/maven-resolver/pull/113#issuecomment-865268516


   Every Null...Class means no behavior. The generál terminology. Also
   nongetter methods.
   
   Dňa ne 20. 6. 2021, 19:10 Michael Osipov ***@***.***>
   napísal(a):
   
   > Null impl does not mean that a method returns null. It means that the
   > class and method does nothing - no behavior.
   >
   > I don't understand that. How can be no behaivor if it invokes a getter?
   >
   > —
   > You are receiving this because you commented.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/maven-resolver/pull/113#issuecomment-864584498>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AAH7ER4JTKJIEEPV3UEDOEDTTYOJLANCNFSM4676ZRHA>
   > .
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org