[GitHub] [solr] bszabo97 commented on a change in pull request #330: SOLR-14781 Delete unused classes

[GitBox <gi...@apache.org>]

bszabo97 commented on a change in pull request #330:
URL: https://github.com/apache/solr/pull/330#discussion_r728159417



##########
File path: solr/core/src/java/org/apache/solr/handler/NotFoundRequestHandler.java
##########
@@ -1,38 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements.  See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License.  You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.apache.solr.handler;
-
-import org.apache.solr.common.SolrException;
-import org.apache.solr.request.SolrQueryRequest;
-import org.apache.solr.response.SolrQueryResponse;
-
-import static org.apache.solr.common.params.CommonParams.PATH;
-
-/**
- * Does nothing other than showing a 404 message
- */
-public class NotFoundRequestHandler extends RequestHandlerBase{

Review comment:
       Thank you for reviewing the PR! I uploaded a new commit which puts back the NotFoundRequestHandler. 
   Also, I deleted this because I could not find any other files which mentions this class (Other RequestHandlers appear in at least one solrconfig of a test). Do you think it would be however useful to write a test for this one as well?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org