You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jeff Coffler <je...@taltos.com> on 2017/10/11 23:31:21 UTC

Re: Review Request 60623: Converted "file://" URI handling to use new uri function.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60623/
-----------------------------------------------------------

(Updated Oct. 11, 2017, 11:31 p.m.)


Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.


Summary (updated)
-----------------

Converted "file://" URI handling to use new uri function.


Bugs: MESOS-6705
    https://issues.apache.org/jira/browse/MESOS-6705


Repository: mesos


Description (updated)
-------

Converted "file://" URI handling to use new uri function.


Diffs (updated)
-----

  src/tests/credentials_tests.cpp 7eb5abd21a1be35d4739c4928cb922f028cfc9a7 
  src/tests/fetcher_tests.cpp df9d2d9586a6457004506c4e2a972ccfc912c7c5 
  src/tests/master_contender_detector_tests.cpp f499136c0b981072af5bc8accf2238b7ba4bf430 
  src/tests/script.cpp 8d40e01da005cb05e7804f0b3975e3e0edb8f3bd 


Diff: https://reviews.apache.org/r/60623/diff/3/

Changes: https://reviews.apache.org/r/60623/diff/2-3/


Testing
-------

See upstream


Thanks,

Jeff Coffler


Re: Review Request 60623: Converted "file://" URI handling to use new uri function.

Posted by Jeff Coffler <je...@taltos.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60623/
-----------------------------------------------------------

(Updated Oct. 19, 2017, 9:33 p.m.)


Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.


Bugs: MESOS-6705
    https://issues.apache.org/jira/browse/MESOS-6705


Repository: mesos


Description
-------

Converted "file://" URI handling to use new uri function.


Diffs (updated)
-----

  src/tests/credentials_tests.cpp 7eb5abd21a1be35d4739c4928cb922f028cfc9a7 
  src/tests/fetcher_tests.cpp df9d2d9586a6457004506c4e2a972ccfc912c7c5 
  src/tests/master_contender_detector_tests.cpp f499136c0b981072af5bc8accf2238b7ba4bf430 
  src/tests/script.cpp 8d40e01da005cb05e7804f0b3975e3e0edb8f3bd 


Diff: https://reviews.apache.org/r/60623/diff/6/

Changes: https://reviews.apache.org/r/60623/diff/5-6/


Testing
-------

See upstream


Thanks,

Jeff Coffler


Re: Review Request 60623: Converted "file://" URI handling to use new uri function.

Posted by Jeff Coffler <je...@taltos.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60623/
-----------------------------------------------------------

(Updated Oct. 19, 2017, 6:17 p.m.)


Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.


Bugs: MESOS-6705
    https://issues.apache.org/jira/browse/MESOS-6705


Repository: mesos


Description
-------

Converted "file://" URI handling to use new uri function.


Diffs (updated)
-----

  src/tests/credentials_tests.cpp 7eb5abd21a1be35d4739c4928cb922f028cfc9a7 
  src/tests/fetcher_tests.cpp df9d2d9586a6457004506c4e2a972ccfc912c7c5 
  src/tests/master_contender_detector_tests.cpp f499136c0b981072af5bc8accf2238b7ba4bf430 
  src/tests/script.cpp 8d40e01da005cb05e7804f0b3975e3e0edb8f3bd 


Diff: https://reviews.apache.org/r/60623/diff/5/

Changes: https://reviews.apache.org/r/60623/diff/4-5/


Testing
-------

See upstream


Thanks,

Jeff Coffler


Re: Review Request 60623: Converted "file://" URI handling to use new uri function.

Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60623/#review188417
-----------------------------------------------------------


Ship it!




Ship It!

- Andrew Schwartzmeyer


On Oct. 16, 2017, 6:18 p.m., Jeff Coffler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60623/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2017, 6:18 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
> 
> 
> Bugs: MESOS-6705
>     https://issues.apache.org/jira/browse/MESOS-6705
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Converted "file://" URI handling to use new uri function.
> 
> 
> Diffs
> -----
> 
>   src/tests/credentials_tests.cpp 7eb5abd21a1be35d4739c4928cb922f028cfc9a7 
>   src/tests/fetcher_tests.cpp df9d2d9586a6457004506c4e2a972ccfc912c7c5 
>   src/tests/master_contender_detector_tests.cpp f499136c0b981072af5bc8accf2238b7ba4bf430 
>   src/tests/script.cpp 8d40e01da005cb05e7804f0b3975e3e0edb8f3bd 
> 
> 
> Diff: https://reviews.apache.org/r/60623/diff/4/
> 
> 
> Testing
> -------
> 
> See upstream
> 
> 
> Thanks,
> 
> Jeff Coffler
> 
>


Re: Review Request 60623: Converted "file://" URI handling to use new uri function.

Posted by Jeff Coffler <je...@taltos.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60623/
-----------------------------------------------------------

(Updated Oct. 17, 2017, 1:18 a.m.)


Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.


Bugs: MESOS-6705
    https://issues.apache.org/jira/browse/MESOS-6705


Repository: mesos


Description
-------

Converted "file://" URI handling to use new uri function.


Diffs (updated)
-----

  src/tests/credentials_tests.cpp 7eb5abd21a1be35d4739c4928cb922f028cfc9a7 
  src/tests/fetcher_tests.cpp df9d2d9586a6457004506c4e2a972ccfc912c7c5 
  src/tests/master_contender_detector_tests.cpp f499136c0b981072af5bc8accf2238b7ba4bf430 
  src/tests/script.cpp 8d40e01da005cb05e7804f0b3975e3e0edb8f3bd 


Diff: https://reviews.apache.org/r/60623/diff/4/

Changes: https://reviews.apache.org/r/60623/diff/3-4/


Testing
-------

See upstream


Thanks,

Jeff Coffler