[GitHub] abesto commented on a change in pull request #15: Jenkinsfile tweaks

[GitBox <gi...@apache.org>]

abesto commented on a change in pull request #15: Jenkinsfile tweaks
URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/15#discussion_r252690062
 
 

 ##########
 File path: Jenkinsfile
 ##########
 @@ -39,13 +56,38 @@ pipeline {
                 sh './mvnw clean install'
             }
         }
-    }
 
+        /*
+        TODO uncomment and finish up the command here once we're ready to release snapshots
+        stage('Publish snapshot') {
+            when {
+                branch 'master'
+            }
+            steps {
+                sh './mvnw $TODO'
+            }
+        }
+         */
+    }
 
     post {
         always {
             junit '**/target/surefire-reports/*.xml'
             deleteDir()
         }
+
+        changed {
+            script {
+                if (env.BRANCH_NAME == 'master') {
 
 Review comment:
   Great point. I *think* those wouldn't trigger this build, but better be on the safe side, I'll add an extra check.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail: dev-help@zipkin.apache.org