You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/11/21 09:36:22 UTC

[GitHub] [cordova-ios] timbru31 commented on a change in pull request #719: Add check for newer versions of cocoapods to avoid locking adding platforms on non synced pods repo

timbru31 commented on a change in pull request #719: Add check for newer versions of cocoapods to avoid locking adding platforms on non synced pods repo
URL: https://github.com/apache/cordova-ios/pull/719#discussion_r348979763
 
 

 ##########
 File path: bin/templates/scripts/cordova/lib/check_reqs.js
 ##########
 @@ -121,15 +121,22 @@ module.exports.check_cocoapods = function (toolChecker) {
         // check whether the cocoapods repo has been synced through `pod repo` command
         // a value of '0 repos' means it hasn't been synced
         .then(function (toolOptions) {
+            if (toolOptions.ignore) return toolOptions;
 
 Review comment:
   a bit nit-picky, but what is your code styleguide in regards to `{ }` after an `if` statement?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org