[jira] [Commented] (GROOVY-12065) Implement peephole optimization for bytecode generation

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GROOVY-12065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18093557#comment-18093557 ] 

ASF GitHub Bot commented on GROOVY-12065:
-----------------------------------------

testlens-app[bot] commented on PR #2591:
URL: https://github.com/apache/groovy/pull/2591#issuecomment-4879767200

   ## 🚨 TestLens detected 1 failed test 🚨
   
   Here is what you can do:
   
   1) Inspect the test failures carefully.
   2) If you are convinced that some of the tests are flaky, you can mute them below.
   3) Finally, trigger a rerun by checking the rerun checkbox.
   
   ### Test Summary
   
   #### [Build and test / lts \(17, macos-latest\)](https://github.com/apache/groovy/actions/runs/28686886754/job/85081128254?pr=2591) > :test
   
   | Test | Runs |
   |---|---|
   | Groovy11046 > testMissingDependency2\(\) | ❌ |
   
   🏷️ Commit: 298263db0d853a31bffdd9dcd10f26c039c370df
   ▶️ Tests:  15449 executed
   🟡 Checks: 3/57 completed
   
   ### Test Failures
   
   <details>
   
   <summary><strong>Groovy11046 > testMissingDependency2()</strong> (:test in <a href="https://github.com/apache/groovy/actions/runs/28686886754/job/85081128254?pr=2591">Build and test / lts (17, macos-latest)</a>)</summary>
   
   ```
   java.lang.AssertionError: script should have failed at runtime. Expression: (err.asString() =~ at org.apache.logging.log4j.LogManager.getLogger\()
   	at org.codehaus.groovy.runtime.InvokerHelper.createAssertError(InvokerHelper.java:402)
   	at bugs.Groovy11046.testMissingDependency2(Groovy11046.groovy:52)
   ```
   
   </details>
   
   ### Muted Tests
   > [!NOTE]
   > Checks are currently running using the configuration below.
   
   Select tests to mute in this pull request:
   
   🔲 Groovy11046 > testMissingDependency2\(\) <!

> Implement peephole optimization for bytecode generation
> -------------------------------------------------------
>
>                 Key: GROOVY-12065
>                 URL: https://issues.apache.org/jira/browse/GROOVY-12065
>             Project: Groovy
>          Issue Type: Improvement
>            Reporter: Daniel Sun
>            Assignee: Daniel Sun
>            Priority: Major
>
> h2. Overview
> This improvement introduces a dedicated, single-pass bytecode compaction layer via {{{}PeepholeOptimizingMethodVisitor{}}}. This adapter wraps the underlying ASM {{MethodVisitor}} during class generation ({{{}AsmClassGenerator{}}}), intercepting instruction streams within local basic blocks to eliminate redundant operations, rewrite conditional branches, and narrow constant instructions to their most optimal forms.
> Crucially, by decoupling peephole optimization from structural code generation, this approach significantly simplifies the constant emission logic inside {{{}OperandStack{}}}. Instead of maintaining verbose, duplicate routing logic for specialized primitive opcodes (such as {{{}ICONST_x{}}}, {{{}BIPUSH{}}}, or {{{}FCONST_x{}}}), {{OperandStack}} now delegates constant pushing uniformly via {{{}visitLdcInsn{}}}. The stateful peephole layer then transparently condenses these instructions into their tightest bytecode representations under the hood.
> h2. Key Optimizations to Implement
> h3. 1. Redundant Instruction & Dead Code Elimination
>  * *Discarded Assignment Values:* Eliminates wasteful {{DUP}} -> {{[X]STORE}} -> {{POP}} patterns typically produced during assignments where the expression result on the operand stack is unused. The optimizer flattens these directly into a single {{{}[X]STORE{}}}.
>  * *Redundant Loads:* Detects situations where a local variable or constant is loaded ({{{}[X]LOAD{}}} / {{{}LDC{}}}) but immediately discarded via {{{}POP{}}}/{{{}POP2{}}}, or followed immediately by a void {{{}RETURN{}}}. The optimizer safely drops both operations while preserving interleaved local increments ({{{}IINC{}}}).
> h3. 2. Conditional Jump & Zero-Comparison Rewriting
>  * Optimizes integer comparisons against zero by transforming expensive binary comparison sequences (e.g., {{ILOAD}} -> {{ICONST_0}} -> {{{}IF_ICMPxx{}}}) into compact unary zero-comparison instructions ({{{}IFxx{}}}). For instance, an {{IF_ICMPEQ}} branch against a buffered {{0}} constant is cleanly rewritten directly to {{{}IFEQ{}}}.
> h3. 3. Instruction Narrowing & Constant Compaction
>  * Intercepts standard literal definitions and transparently narrows them down to the smallest possible specialized opcodes ({{{}ICONST_M1{}}} through {{{}ICONST_5{}}}, {{{}BIPUSH{}}}, {{{}SIPUSH{}}}, {{{}LCONST_0/1{}}}, {{{}FCONST_0/1/2{}}}, and {{{}DCONST_0/1{}}}).
>  * Explicitly safeguards signed floating-point zeros ({{{}-0.0f{}}} and {{{}-0.0d{}}}) from accidental flattening to guarantee strict IEEE 754 runtime compliance.
> h3. 4. Big Number Literal Lowering
>  * Centralizes string-constructed object instantiations for {{BigDecimal}} and {{BigInteger}} literals by rewriting buffered constants into inline {{NEW}} -> {{DUP}} -> {{LDC [string]}} -> {{INVOKESPECIAL <init>}} pipelines seamlessly before stack emission.
> h2. Implementation Strategy & Safety Guardrails
> The {{PeepholeOptimizingMethodVisitor}} operates on a lightweight, stack-local sliding window. To fully preserve runtime semantics, debugging capabilities, and catch-block structures, the lookahead window is automatically flushed to the delegate visitor when encountering non-local boundaries or frame-altering instructions, including:
>  * Control flow jumps and basic block {{Label}} targets.
>  * Stack map frames ({{{}visitFrame{}}}).
>  * Line numbers and local variable debug maps.
>  * Method invocations and {{InvokeDynamic}} instructions.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)