[jira] [Commented] (THRIFT-2157) generated code would cause ClassCastException

["Jens Geyer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379593#comment-14379593 ] 

Jens Geyer commented on THRIFT-2157:
------------------------------------

The base class for Thrift exceptions is TExceptions, not TBase, as specified by THRIFT-1761. 

Speaking about that subject, there is also some kind of a pending discussion in THRIFT-2935, where I personally disagree with, mainly because of the inconcistency this would cause, but I'm not that much of a Java user to fully understand all the implications that may exist. Feel free to contribute to that discussion if you have something to add.



> generated code would cause ClassCastException
> ---------------------------------------------
>
>                 Key: THRIFT-2157
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2157
>             Project: Thrift
>          Issue Type: Bug
>          Components: Java - Compiler
>    Affects Versions: 0.9.1
>            Reporter: Dave Brosius
>            Priority: Trivial
>
> Looking at the thrift generated code for cassandra, i'm seeing
>  msg = (org.apache.thrift.TBase)new org.apache.thrift.TApplicationException(org.apache.thrift.TApplicationException.INTERNAL_ERROR, e.getMessage());
> as seen here
> https://git-wip-us.apache.org/repos/asf?p=cassandra.git;a=blob;f=interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java;h=837acfc0e964249fd62720420e8f1f85d966f1a3;hb=8f202895ab9e17c3d6bd4965924fd5f1ffc27f94#l6095
> i don't see how TApplicationException can be cast to TBase, and so i'd expect a ClassCastException there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)