[PATCH] serf compile fixes

[Garrett Rooney <ro...@electricjellyfish.net>]

So with the amount of change happening in serf, I imagine these 
problems have already been fixed in gstein or jerenkrantz's local 
tree's, but in case they haven't, here's a few compile fixes.

-garrett

* serf.h
   (serf_request_get_alloc): return a pointer to a serf_bucket_alloc_t, 
as
    you can't return the structure since it's only forward declared, and 
we
    only have a pointer anyway.

* context.c
   (serf_request_deliver): remove return, this function returns void.
   (serf_request_get_alloc): adjust for change to prototype.

Re: [PATCH] serf compile fixes

[Garrett Rooney <ro...@electricjellyfish.net>]

On Nov 4, 2003, at 10:12 PM, Greg Stein wrote:

> On Tue, Nov 04, 2003 at 08:15:12PM -0500, Garrett Rooney wrote:
>> So with the amount of change happening in serf, I imagine these
>> problems have already been fixed in gstein or jerenkrantz's local
>> tree's, but in case they haven't, here's a few compile fixes.
>
> Nope. I hadn't run a compile after my last round of changes. There 
> isn't
> much need to do that, except as a syntax check :-) (eventually, we'll 
> have
> enough functionality to really attack serf_get and make it work; then
> we'll be compiling all the time...)  So in that sense, your changes are
> appreciated.
>
> [ well, the suggestions of changes; no patch was attached :-) ]

Odd, in my 'Sent' folder, there is a patch attached to the mail...  
Does this mailing list strip attachments for some reason?  If so I 
suppose I'll have to send it inline with the mail next time...

> The changes were easily made, and I've committed them. Thanks!

No problem ;-)

-garrett

Re: [PATCH] serf compile fixes

[Greg Stein <gs...@lyra.org>]

On Tue, Nov 04, 2003 at 08:15:12PM -0500, Garrett Rooney wrote:
> So with the amount of change happening in serf, I imagine these 
> problems have already been fixed in gstein or jerenkrantz's local 
> tree's, but in case they haven't, here's a few compile fixes.

Nope. I hadn't run a compile after my last round of changes. There isn't
much need to do that, except as a syntax check :-) (eventually, we'll have
enough functionality to really attack serf_get and make it work; then
we'll be compiling all the time...)  So in that sense, your changes are
appreciated.

[ well, the suggestions of changes; no patch was attached :-) ]

The changes were easily made, and I've committed them. Thanks!

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/