You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/24 12:48:28 UTC
[GitHub] [skywalking] wu-sheng opened a new issue #7553: Create skywalking-java-commons sub project
wu-sheng opened a new issue #7553:
URL: https://github.com/apache/skywalking/issues/7553
SkyWalking main repo's apm-common includes `apm-datacarrier` and `apm-util`. I am going to separate them into another repo and call it `skywalking-java-commons`.
In the future, everything commons in Java should be placed there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7553: Create skywalking-java-commons sub project
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7553:
URL: https://github.com/apache/skywalking/issues/7553#issuecomment-904633218
We could do share nothing, and copy them into agent and backend core if we want, actually. If duplicate is not a concern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7553: Create skywalking-java-commons sub project
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7553:
URL: https://github.com/apache/skywalking/issues/7553#issuecomment-904632342
The issue of submodule is in further release process. Both the agent and backend include the same maven module, they would conflict. How could we resolve that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 edited a comment on issue #7553: Create skywalking-java-commons sub project
Posted by GitBox <gi...@apache.org>.
kezhenxu94 edited a comment on issue #7553:
URL: https://github.com/apache/skywalking/issues/7553#issuecomment-904640789
What I concern is, having this new sub repo will increase the maintainers' load, (not about maintaining codes, I mean releasing new versions)
> We could do share nothing, and copy them into agent and backend core if we want, actually. If duplicate is not a concern.
In fact we don't need to "copy", we just push the original repo to the new agent repo, and delete everything that is not needed in the repo itself.
And according to https://github.com/apache/skywalking/issues/7553#issuecomment-904629858
> I also checked classes in apm-util, only PropertyPlaceholderHelper is really shared between oap-server and agent, other classes are either only used in agent or oap-server, we can move them into agent or oap-server codebase respectively.
As for the other module `apm-datacarrier`, I think we can leave it in 2 repos until we have time to replace it with Disruptor (we discussed this before, with @CalvinKirs, and I'm glad to do that when I have time).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #7553: Create skywalking-java-commons sub project
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #7553:
URL: https://github.com/apache/skywalking/issues/7553#issuecomment-904630995
If submodule is not a blocker, I prefer using submodule
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7553: Create skywalking-java-commons sub project
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7553:
URL: https://github.com/apache/skywalking/issues/7553#issuecomment-904610288
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #7553: Create skywalking-java-commons sub project
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #7553:
URL: https://github.com/apache/skywalking/issues/7553#issuecomment-904629858
Then we have to release it first every time when we add / modify codes in this new repo, which is painful, we should minimize the codes in this new repo.
I also checked classes in `apm-util`, only `PropertyPlaceholderHelper` is really shared between oap-server and agent, other classes are either only used in agent or oap-server, we can move them into agent or oap-server codebase respectively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7553: Create skywalking-java-commons sub project
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7553:
URL: https://github.com/apache/skywalking/issues/7553#issuecomment-904638728
I am totally fine about withdraw this proposal, if we keep DataCarrier's source codes in both sides.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #7553: Create skywalking-java-commons sub project
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #7553:
URL: https://github.com/apache/skywalking/issues/7553
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #7553: Create skywalking-java-commons sub project
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #7553:
URL: https://github.com/apache/skywalking/issues/7553#issuecomment-904640789
What I concern is, having this new sub repo will increase the maintainers' load, (not about maintaining codes, I mean releasing new versions)
> We could do share nothing, and copy them into agent and backend core if we want, actually. If duplicate is not a concern.
In fact we don't need to "copy", we just push the original repo to the new agent repo, and delete everything that is not needed in the repo itself.
And according to https://github.com/apache/skywalking/issues/7553#issuecomment-904629858
> I also checked classes in apm-util, only PropertyPlaceholderHelper is really shared between oap-server and agent, other classes are either only used in agent or oap-server, we can move them into agent or oap-server codebase respectively.
As for the other module `apm-datacarrier`, I think we can leave it in 2 repos until we have time to replace it with Disruptor (we discussed this before, and I'm glad to do that when I have time).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7553: Create skywalking-java-commons sub project
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7553:
URL: https://github.com/apache/skywalking/issues/7553#issuecomment-904650289
> > Actually, this will not work. Because https://github.com/apache/skywalking/blob/master/apm-commons/apm-util/pom.xml this will trigger a new Maven central push in the release. We can't do it twice.
> > What I mean keep both and copy, is removing this at the both side, and move them into another package in the agent and server-util.
>
> Simply renaming the artifact id to like `apm-util-oap` / `apm-util-agent` can easily resolve the problem, without needs to rename the package, I don't think anyone would import `apm-util-oap` and `apm-util-agent` at the same time in a single project so we don't need to worry about package name conflicts.
Yes, that is my meaning about copy. We have `org.apache.skywalking:library-util` already. Moving the codes into there also works.
If this is our preference, let me close this issue and milestone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #7553: Create skywalking-java-commons sub project
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #7553:
URL: https://github.com/apache/skywalking/issues/7553#issuecomment-904646562
> Actually, this will not work. Because https://github.com/apache/skywalking/blob/master/apm-commons/apm-util/pom.xml this will trigger a new Maven central push in the release. We can't do it twice.
> What I mean keep both and copy, is removing this at the both side, and move them into another package in the agent and server-util.
Simply renaming the artifact id to like `apm-util-oap` / `apm-util-agent` can easily resolve the problem, without needs to rename the package, I don't think anyone would import `apm-util-oap` and `apm-util-agent` at the same time in a single project so we don't need to worry about package name conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7553: Create skywalking-java-commons sub project
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7553:
URL: https://github.com/apache/skywalking/issues/7553#issuecomment-904614841
I prefer release first.(That is why I am planning to initial this repo in next days) What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #7553: Create skywalking-java-commons sub project
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #7553:
URL: https://github.com/apache/skywalking/issues/7553#issuecomment-904614166
@wu-sheng How the backend and agent depend on this new sub project? Via git submodule or release it first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7553: Create skywalking-java-commons sub project
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7553:
URL: https://github.com/apache/skywalking/issues/7553#issuecomment-904642734
> In fact we don't need to "copy", we just push the original repo to the new agent repo, and delete everything that is not needed in the repo itself.
Actually, this will not work. Because https://github.com/apache/skywalking/blob/master/apm-commons/apm-util/pom.xml this will trigger a new Maven central push in the release. We can't do it twice.
What I mean keep both and copy, is removing this at the both side, and move them into another package in the agent and server-util.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org