You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/10/05 01:06:26 UTC

[GitHub] [mynewt-core] rafacouto opened a new pull request #2386: WIP: SPI_4 and SPI_5 definitions

rafacouto opened a new pull request #2386:
URL: https://github.com/apache/mynewt-core/pull/2386


   Missing SPI definitions on STM32 common drivers. See issue #2385


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [mynewt-core] kasjer commented on pull request #2386: WIP: SPI_4 and SPI_5 definitions

Posted by GitBox <gi...@apache.org>.
kasjer commented on pull request #2386:
URL: https://github.com/apache/mynewt-core/pull/2386#issuecomment-713515884


   @rafacouto is this PR still in work in progress state?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [mynewt-core] kasjer merged pull request #2386: WIP: SPI_4 and SPI_5 definitions

Posted by GitBox <gi...@apache.org>.
kasjer merged pull request #2386:
URL: https://github.com/apache/mynewt-core/pull/2386


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2386: WIP: SPI_4 and SPI_5 definitions

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2386:
URL: https://github.com/apache/mynewt-core/pull/2386#issuecomment-703346563


   
   <!-- style-bot -->
   
   ## Style check summary
   
   #### No suggestions at this time!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [mynewt-core] rafacouto commented on pull request #2386: WIP: SPI_4 and SPI_5 definitions

Posted by GitBox <gi...@apache.org>.
rafacouto commented on pull request #2386:
URL: https://github.com/apache/mynewt-core/pull/2386#issuecomment-715457264


   > @rafacouto is this PR still in work in progress state?
   
   I've tested that prebuilt macros are generated but I couldn't check if SPIs are operatives. Please, give me some more days to do a full test on board. I'll post the results in this thread.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [mynewt-core] kasjer commented on pull request #2386: WIP: SPI_4 and SPI_5 definitions

Posted by GitBox <gi...@apache.org>.
kasjer commented on pull request #2386:
URL: https://github.com/apache/mynewt-core/pull/2386#issuecomment-716360246


   Hi @rafacouto changes were good, I tested it and since commit message was also nice I though that little WIP in PR name will not be a problem. Thanks for you contribution.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org