[jira] [Commented] (CLOUDSTACK-8985) Deleted volume's removed column not updated

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14969875#comment-14969875 ] 

ASF GitHub Bot commented on CLOUDSTACK-8985:
--------------------------------------------

GitHub user mike-tutkowski opened a pull request:

    https://github.com/apache/cloudstack/pull/968

    CLOUDSTACK-8985: Deleted volume's removed column not updated

    I found this issue when a SolidFire integration test yesterday wasn't able to delete primary storage because it claimed there were still volumes using the primary storage in question (this was due to the removed column not being updated appropriately).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mike-tutkowski/cloudstack removed_column

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/968.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #968
    
----
commit 60f53fb9fecb8aba2088d6245f5a5b1168c49bf3
Author: Mike Tutkowski <mt...@mtutkowski-lt.local>
Date:   2015-10-22T18:16:19Z

    CLOUDSTACK-8985: Deleted volume's removed column not updated

----


> Deleted volume's removed column not updated
> -------------------------------------------
>
>                 Key: CLOUDSTACK-8985
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8985
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server
>    Affects Versions: 4.6.0
>         Environment: All
>            Reporter: Mike Tutkowski
>            Assignee: Mike Tutkowski
>             Fix For: 4.6.0
>
>
> Note: Relates to managed storage only.
> Due to the fact that a volume does not enter the "Expunged" state until after a callback method is invoked (which happens after the plug-in is notified to delete the volume in question), the current getUsedBytes implementation (in SolidFirePrimaryDataStoreDriver) was assuming the volume just deleted would not be included in the used-byte count calculation.
> The fact that the code does try to count this volume in the used-byte count calculation leads to an exception being thrown and the removed column not being updated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)