You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "claudio4j (via GitHub)" <gi...@apache.org> on 2024/01/25 18:53:06 UTC
[PR] Fix: TestCreateCatalog fail when runtime is 3.6.0-SNAPSHOT [camel-k]
claudio4j opened a new pull request, #5111:
URL: https://github.com/apache/camel-k/pull/5111
Fix https://github.com/apache/camel-k/issues/5099
<!-- Description -->
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: TestCreateCatalog fail when runtime is 3.6.0-SNAPSHOT [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #5111:
URL: https://github.com/apache/camel-k/pull/5111#issuecomment-1911846235
The root cause is that the new catalog has a wrong `quarkus-version`:
```
metadata:
camel-quarkus.version: 3.6.0
camel.version: 4.2.0
jib.layer-filter-extension-maven.version: 0.3.0
jib.maven-plugin.version: 3.4.0
quarkus.native-builder-image: quay.io/quarkus/ubi-quarkus-mandrel-builder-image:jdk-21
quarkus.version: 3.6.0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: TestCreateCatalog fail when runtime is 3.6.0-SNAPSHOT [camel-k]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5111:
URL: https://github.com/apache/camel-k/pull/5111#issuecomment-1910805916
:heavy_check_mark: Unit test coverage report - coverage increased from 34.8% to 35.3% (**+0.5%**)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: TestCreateCatalog fail when runtime is 3.6.0-SNAPSHOT [camel-k]
Posted by "claudio4j (via GitHub)" <gi...@apache.org>.
claudio4j commented on PR #5111:
URL: https://github.com/apache/camel-k/pull/5111#issuecomment-1911819078
> We cannot hardcode variables.
This is a test only, for the catalog to be created in the IntegrationPlatform and the status to be "Ready", it would really not matter the version, since the "mvn camel-k-maven-plugin:generate-catalog" is to output the catalog yaml file. The catalog generation is also covered in camel-k-maven-plugin project.
The real problem with this particular test is the snapshot version, the apache snapshot repository is not set. I can change the test to include the snapshot repo and retain the defaults.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: TestCreateCatalog fail when runtime is 3.6.0-SNAPSHOT [camel-k]
Posted by "claudio4j (via GitHub)" <gi...@apache.org>.
claudio4j commented on PR #5111:
URL: https://github.com/apache/camel-k/pull/5111#issuecomment-1911934177
The [nightly test failed](https://github.com/apache/camel-k/actions/runs/7649141367/job/20843059854#step:4:1008) exactly in the same spot.
The problem is the missing snapshot maven repo.
I think it would not be a problem to hard code the LTS version in the test code and in the nightly, add the snapshot repository. I will change the code to accommodate this behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: TestCreateCatalog fail when runtime is 3.6.0-SNAPSHOT [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #5111:
URL: https://github.com/apache/camel-k/pull/5111#issuecomment-1911835525
FYI, this seems to be a regression. It was working 2 days ago: https://github.com/apache/camel-k/actions/runs/7634756816/job/20799121558#step:4:929
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: TestCreateCatalog fail when runtime is 3.6.0-SNAPSHOT [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #5111:
URL: https://github.com/apache/camel-k/pull/5111#issuecomment-1911944842
IMO the problem is in the last runtime change. I'd be more inclined to revert the latest changes there instead. At least you can confirm that one is the root cause or this issue persist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: TestCreateCatalog fail when runtime is 3.6.0-SNAPSHOT [camel-k]
Posted by "claudio4j (via GitHub)" <gi...@apache.org>.
claudio4j commented on PR #5111:
URL: https://github.com/apache/camel-k/pull/5111#issuecomment-1911920168
That version is defined in https://github.com/apache/camel-k-runtime/blob/main/pom.xml#L46
Can you run: `make DEFAULT_RUNTIME_VERSION=3.6.0-SNAPSHOT clean build`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org