[GitHub] kishoreg commented on issue #3893: Reduce MAX_SEGMENT_COMPLETION_TIME_MILLIS to 5 minutes

[GitBox <gi...@apache.org>]

kishoreg commented on issue #3893: Reduce MAX_SEGMENT_COMPLETION_TIME_MILLIS to 5 minutes
URL: https://github.com/apache/incubator-pinot/pull/3893#issuecomment-468336769
 
 
   Are we not using compare and set.  Why do we need time based checks
   
   On Thu, Feb 28, 2019 at 8:20 AM Subbu Subramaniam <no...@github.com>
   wrote:
   
   > *@mcvsubbu* commented on this pull request.
   >
   > Dont we also need to check time of idealstate update (step 3) ? The entire
   > segment metadata commit should happen within a time t <
   > MAX_SEGMENT_COMPLEZTION_TIME_MILLIS, so it is good to check before
   > idealstate update whether that time is already past.
   >
   > —
   > You are receiving this because you are subscribed to this thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/incubator-pinot/pull/3893#pullrequestreview-209170058>,
   > or mute the thread
   > <https://github.com/notifications/unsubscribe-auth/AAz7Z5CiEpIB5H6gmH-UosniFMuC9Xlmks5vSAHRgaJpZM4bVu5M>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org