You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/06/29 18:20:09 UTC
[kudu-CR] stopwatch: ensure LOG TIMING always prints
Todd Lipcon has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7333
Change subject: stopwatch: ensure LOG_TIMING always prints
......................................................................
stopwatch: ensure LOG_TIMING always prints
On rare occasion in benchmark runs, the LOG_TIMING macro doesn't produce
any output. It's not entirely clear why this happens, but it seems the
only possibility is that the so-called monotonic clock is going
backwards. This change ensures that the macro always prints even if the
clock moves backwards.
Change-Id: I67fe658801be153cbcb6efb31cc8f3bf9eaf944f
---
M src/kudu/util/stopwatch.h
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/7333/1
--
To view, visit http://gerrit.cloudera.org:8080/7333
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I67fe658801be153cbcb6efb31cc8f3bf9eaf944f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
[kudu-CR] stopwatch: ensure LOG TIMING always prints
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: stopwatch: ensure LOG_TIMING always prints
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7333/1/src/kudu/util/stopwatch.h
File src/kudu/util/stopwatch.h:
Line 330: // TODO(todd): for some reason, times.wall_millis() sometimes ends up negative
Did you add a CHECK() for that case? Did it produce anything interesting?
--
To view, visit http://gerrit.cloudera.org:8080/7333
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I67fe658801be153cbcb6efb31cc8f3bf9eaf944f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] stopwatch: ensure LOG TIMING always prints
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: stopwatch: ensure LOG_TIMING always prints
......................................................................
stopwatch: ensure LOG_TIMING always prints
On rare occasion in benchmark runs, the LOG_TIMING macro doesn't produce
any output. It's not entirely clear why this happens, but it seems the
only possibility is that the so-called monotonic clock is going
backwards. This change ensures that the macro always prints even if the
clock moves backwards.
Change-Id: I67fe658801be153cbcb6efb31cc8f3bf9eaf944f
Reviewed-on: http://gerrit.cloudera.org:8080/7333
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/util/stopwatch.h
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7333
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I67fe658801be153cbcb6efb31cc8f3bf9eaf944f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] stopwatch: ensure LOG TIMING always prints
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: stopwatch: ensure LOG_TIMING always prints
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7333/1/src/kudu/util/stopwatch.h
File src/kudu/util/stopwatch.h:
Line 330: // TODO(todd): for some reason, times.wall_millis() sometimes ends up negative
> Did you add a CHECK() for that case? Did it produce anything interesting?
I overnight looped a test which looked for negative wall_millis() on a box with the same kernel and it never failed, so I gave up and just doing this.
--
To view, visit http://gerrit.cloudera.org:8080/7333
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I67fe658801be153cbcb6efb31cc8f3bf9eaf944f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes