You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Veena Basavaraj <vb...@cloudera.com> on 2014/10/29 15:15:16 UTC

Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/
-----------------------------------------------------------

Review request for Sqoop.


Repository: sqoop-sqoop2


Description
-------

see JIRA and its parent JIRA for details


Diffs
-----

  client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
  client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
  client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
  common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
  common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
  common/src/main/java/org/apache/sqoop/json/LinksBean.java 5858a18 
  common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
  common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/model/MLink.java 7a9f538 
  common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
  common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
  common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 811cbf0 
  common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
  core/src/main/java/org/apache/sqoop/driver/JobManager.java f6447c6 
  core/src/main/java/org/apache/sqoop/driver/SubmissionEngine.java 3a32e9f 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 2aeb07e 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ad380d3 
  core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 514b5ac 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 4c2d062 
  server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
  server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
  server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
  server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
  server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
  server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
  server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a 
  server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
  server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
  server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
  shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
  shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
  submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 631ceca 
  tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 
  tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 64b08fc 

Diff: https://reviews.apache.org/r/27330/diff/


Testing
-------

yes


Thanks,

Veena Basavaraj

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Veena Basavaraj <vb...@cloudera.com>.

> On Oct. 29, 2014, 8:01 a.m., Abraham Elmahrek wrote:
> > shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java, line 64
> > <https://reviews.apache.org/r/27330/diff/1/?file=740299#file740299line64>
> >
> >     rm?

same as below.


- Veena


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/#review58985
-----------------------------------------------------------


On Oct. 29, 2014, 1:12 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27330/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2014, 1:12 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see JIRA and its parent JIRA for details
> 
> All the WS stuff, I will do it in the end once the functionality is reviewd.
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c 
>   client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a 
>   client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
>   client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
>   client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
>   common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
>   common/src/main/java/org/apache/sqoop/json/LinksBean.java 5858a18 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
>   common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MLink.java 7a9f538 
>   common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
>   common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
>   common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 811cbf0 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java f6447c6 
>   core/src/main/java/org/apache/sqoop/driver/SubmissionEngine.java 3a32e9f 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 2aeb07e 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ad380d3 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 514b5ac 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 4c2d062 
>   server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5694ea5 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
>   server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
>   server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
>   server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
>   server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
>   server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
>   shell/src/main/java/org/apache/sqoop/shell/AbortCommand.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/AbortJobFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 
>   shell/src/main/java/org/apache/sqoop/shell/StartCommand.java 7c56980 
>   shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
>   shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 
>   shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
>   shell/src/main/java/org/apache/sqoop/shell/StopCommand.java 50b2e81 
>   shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
>   shell/src/main/java/org/apache/sqoop/shell/SubmitCommand.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SubmitJobFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
>   shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 44d5920 
>   submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 631ceca 
>   test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java af31769 
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 64b08fc 
> 
> Diff: https://reviews.apache.org/r/27330/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Veena Basavaraj <vb...@cloudera.com>.

> On Oct. 29, 2014, 8:01 a.m., Abraham Elmahrek wrote:
> > core/src/main/java/org/apache/sqoop/repository/Repository.java, lines 427-443
> > <https://reviews.apache.org/r/27330/diff/1/?file=740285#file740285line427>
> >
> >     This change does not seem relevant?

its just consistency and cleanup. Are we going to be this anal about a rename of ID to Id to? If it is a functionality change I totallya agree.


> On Oct. 29, 2014, 8:01 a.m., Abraham Elmahrek wrote:
> > core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java, lines 605-609
> > <https://reviews.apache.org/r/27330/diff/1/?file=740283#file740283line605>
> >
> >     These renames do not seem relevant

it is releated to submissions, Why is it not relevant? and everwhere it is findSubmissions and it makes sense to be consistent.


> On Oct. 29, 2014, 8:01 a.m., Abraham Elmahrek wrote:
> > server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java, line 303
> > <https://reviews.apache.org/r/27330/diff/1/?file=740289#file740289line303>
> >
> >     The identifier should always be name? In this case, the identifier will always be a string.

we support both in all places for consistency. I will update the doc if I have missed it


> On Oct. 29, 2014, 8:01 a.m., Abraham Elmahrek wrote:
> > server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java, lines 336-346
> > <https://reviews.apache.org/r/27330/diff/1/?file=740289#file740289line336>
> >
> >     Maybe other way around?
> >         try {
> >           return Long.valueOf(identifier);
> >         } catch(NumberFormatException ex) {
> >           if (repository.findJob(identifier) != null) {
> >             return repository.findJob(identifier).getPersistenceId();
> >           } else {
> >             throw new SqoopException
> >           }
> >         }
> >     Otherwise, if the job doesn't exist, just throw an exception?

How is this any better? I prfer looking up name since that is what we want to get to, the id remains for use cases we have so far 

But the docs should encourage using names going fowards both in client and the REST


> On Oct. 29, 2014, 8:01 a.m., Abraham Elmahrek wrote:
> > shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java, line 63
> > <https://reviews.apache.org/r/27330/diff/1/?file=740300#file740300line63>
> >
> >     rm? I'd update SQOOP-1634 with a little bit of detail just in case.

It is related to adding config as an api, the parent ticket has description. I will add more. 

the whole point is able to just use a config Id already created and dont have to make a call here during LINK/ JOB creation. less http calls.


- Veena


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/#review58985
-----------------------------------------------------------


On Oct. 29, 2014, 7:15 a.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27330/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2014, 7:15 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see JIRA and its parent JIRA for details
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
>   client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
>   client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
>   common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
>   common/src/main/java/org/apache/sqoop/json/LinksBean.java 5858a18 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
>   common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MLink.java 7a9f538 
>   common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
>   common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
>   common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 811cbf0 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java f6447c6 
>   core/src/main/java/org/apache/sqoop/driver/SubmissionEngine.java 3a32e9f 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 2aeb07e 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ad380d3 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 514b5ac 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 4c2d062 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
>   server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
>   server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
>   server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
>   server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
>   server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
>   submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 631ceca 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 64b08fc 
> 
> Diff: https://reviews.apache.org/r/27330/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Jarek Cecho <ja...@apache.org>.

> On Oct. 29, 2014, 3:01 p.m., Abraham Elmahrek wrote:
> > server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java, lines 336-346
> > <https://reviews.apache.org/r/27330/diff/1/?file=740289#file740289line336>
> >
> >     Maybe other way around?
> >         try {
> >           return Long.valueOf(identifier);
> >         } catch(NumberFormatException ex) {
> >           if (repository.findJob(identifier) != null) {
> >             return repository.findJob(identifier).getPersistenceId();
> >           } else {
> >             throw new SqoopException
> >           }
> >         }
> >     Otherwise, if the job doesn't exist, just throw an exception?
> 
> Veena Basavaraj wrote:
>     How is this any better? I prfer looking up name since that is what we want to get to, the id remains for use cases we have so far 
>     
>     But the docs should encourage using names going fowards both in client and the REST
> 
> Abraham Elmahrek wrote:
>     Now that I think about, we have a bit of an overlap unfortunately. If the name looks like an ID (e.g. "1"), then we can't look up by ID. It will have to be by name.
>     
>     With that I'd probably keep it the way you have it and prefer name over ID.

I'm concerned about the overlap as well. What about one of the following:

1) Let's have two REST interfaces for retriving objects one for "id" another for "name".
2) Let's define name rules so that name can never ever start with number. E.g creating link with name "1" will fail on invalid name or something like that.

I think that both will solve our overlap problem.


- Jarek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/#review58985
-----------------------------------------------------------


On Oct. 30, 2014, 9:08 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27330/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2014, 9:08 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see JIRA and its parent JIRA for details
> 
> All the WS stuff, I will do it in the end once the functionality is reviewd.
> 
> 
> If someone is wondering why START is changed to submit: there are tons of places in the code and in the java docs, we actually mean submit when we say START
> 
>   DRIVER_0008("Invalid combination of submission and execution engines"),
> 
>   DRIVER_0009("Job has been disabled. Cannot submit this job."),
> 
>   DRIVER_0010("Link for this job has been disabled. Cannot submit this job."),
> 
>   DRIVER_0011("Connector does not support specified direction. Cannot submit this job."),
> 
>   ;
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c 
>   client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a 
>   client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
>   client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
>   client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
>   common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
>   common/src/main/java/org/apache/sqoop/json/LinksBean.java 5858a18 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
>   common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MLink.java 7a9f538 
>   common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
>   common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
>   common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 811cbf0 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartitioner.java 2411169 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java 3ae64f0 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java f6447c6 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 2aeb07e 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ad380d3 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b996a0b 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 4c2d062 
>   server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5694ea5 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
>   server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
>   server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
>   server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
>   server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
>   server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
>   shell/src/main/java/org/apache/sqoop/shell/AbortCommand.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 
>   shell/src/main/java/org/apache/sqoop/shell/StartCommand.java 7c56980 
>   shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
>   shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 
>   shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
>   shell/src/main/java/org/apache/sqoop/shell/StopCommand.java 50b2e81 
>   shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
>   shell/src/main/java/org/apache/sqoop/shell/SubmitCommand.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SubmitJobFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
>   shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 44d5920 
>   shell/src/main/resources/shell-resource.properties 0e63c50 
>   test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java af31769 
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 64b08fc 
> 
> Diff: https://reviews.apache.org/r/27330/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Abraham Elmahrek <ab...@cloudera.com>.

> On Oct. 29, 2014, 3:01 p.m., Abraham Elmahrek wrote:
> > server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java, lines 336-346
> > <https://reviews.apache.org/r/27330/diff/1/?file=740289#file740289line336>
> >
> >     Maybe other way around?
> >         try {
> >           return Long.valueOf(identifier);
> >         } catch(NumberFormatException ex) {
> >           if (repository.findJob(identifier) != null) {
> >             return repository.findJob(identifier).getPersistenceId();
> >           } else {
> >             throw new SqoopException
> >           }
> >         }
> >     Otherwise, if the job doesn't exist, just throw an exception?
> 
> Veena Basavaraj wrote:
>     How is this any better? I prfer looking up name since that is what we want to get to, the id remains for use cases we have so far 
>     
>     But the docs should encourage using names going fowards both in client and the REST

Now that I think about, we have a bit of an overlap unfortunately. If the name looks like an ID (e.g. "1"), then we can't look up by ID. It will have to be by name.

With that I'd probably keep it the way you have it and prefer name over ID.


> On Oct. 29, 2014, 3:01 p.m., Abraham Elmahrek wrote:
> > core/src/main/java/org/apache/sqoop/repository/Repository.java, lines 427-443
> > <https://reviews.apache.org/r/27330/diff/1/?file=740285#file740285line427>
> >
> >     This change does not seem relevant?
> 
> Veena Basavaraj wrote:
>     its just consistency and cleanup. Are we going to be this anal about a rename of ID to Id to? If it is a functionality change I totallya agree.

Usually we try to limit the scope of code changes to the Jira for 'git blame'. There has been exceptions with sweeping refactoring, but sqoop2 is reaching a state where we can start doing this again.


> On Oct. 29, 2014, 3:01 p.m., Abraham Elmahrek wrote:
> > core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java, lines 605-609
> > <https://reviews.apache.org/r/27330/diff/1/?file=740283#file740283line605>
> >
> >     These renames do not seem relevant
> 
> Veena Basavaraj wrote:
>     it is releated to submissions, Why is it not relevant? and everwhere it is findSubmissions and it makes sense to be consistent.

Fair!


- Abraham


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/#review58985
-----------------------------------------------------------


On Oct. 29, 2014, 4:52 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27330/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2014, 4:52 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see JIRA and its parent JIRA for details
> 
> All the WS stuff, I will do it in the end once the functionality is reviewd.
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
>   client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
>   client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
>   common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
>   common/src/main/java/org/apache/sqoop/json/LinksBean.java 5858a18 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
>   common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MLink.java 7a9f538 
>   common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
>   common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
>   common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 811cbf0 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java f6447c6 
>   core/src/main/java/org/apache/sqoop/driver/SubmissionEngine.java 3a32e9f 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 2aeb07e 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ad380d3 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 514b5ac 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 4c2d062 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
>   server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
>   server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
>   server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
>   server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
>   server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
>   submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 631ceca 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 64b08fc 
> 
> Diff: https://reviews.apache.org/r/27330/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/#review58985
-----------------------------------------------------------


Good first cut. There are a lot of renames that don't seem to be part of this Jira. Can we do them in a separate Jira? Also, your IDE may be able to remove extra white spaces for you.


common/src/main/java/org/apache/sqoop/json/JobBean.java
<https://reviews.apache.org/r/27330/#comment100241>

    in*



core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java
<https://reviews.apache.org/r/27330/#comment100244>

    These renames do not seem relevant



core/src/main/java/org/apache/sqoop/repository/Repository.java
<https://reviews.apache.org/r/27330/#comment100243>

    This change does not seem relevant?



repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
<https://reviews.apache.org/r/27330/#comment100245>

    sp



repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
<https://reviews.apache.org/r/27330/#comment100246>

    sp



server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
<https://reviews.apache.org/r/27330/#comment100247>

    sp



server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
<https://reviews.apache.org/r/27330/#comment100248>

    sp



server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
<https://reviews.apache.org/r/27330/#comment100249>

    sp



server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
<https://reviews.apache.org/r/27330/#comment100250>

    sp



server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
<https://reviews.apache.org/r/27330/#comment100252>

    Maybe add a condition to skip hitting the database? i.e.
        if (job.getPersistanceId() == -1) {
          ...
        }



server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
<https://reviews.apache.org/r/27330/#comment100251>

    sp



server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
<https://reviews.apache.org/r/27330/#comment100253>

    space



server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
<https://reviews.apache.org/r/27330/#comment100255>

    The identifier should always be name? In this case, the identifier will always be a string.



server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
<https://reviews.apache.org/r/27330/#comment100256>

    Maybe other way around?
        try {
          return Long.valueOf(identifier);
        } catch(NumberFormatException ex) {
          if (repository.findJob(identifier) != null) {
            return repository.findJob(identifier).getPersistenceId();
          } else {
            throw new SqoopException
          }
        }
    Otherwise, if the job doesn't exist, just throw an exception?



server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
<https://reviews.apache.org/r/27330/#comment100257>

    sp



server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java
<https://reviews.apache.org/r/27330/#comment100258>

    sp



server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java
<https://reviews.apache.org/r/27330/#comment100259>

    sp



shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java
<https://reviews.apache.org/r/27330/#comment100260>

    rm?



shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java
<https://reviews.apache.org/r/27330/#comment100261>

    rm? I'd update SQOOP-1634 with a little bit of detail just in case.


- Abraham Elmahrek


On Oct. 29, 2014, 2:15 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27330/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2014, 2:15 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see JIRA and its parent JIRA for details
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
>   client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
>   client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
>   common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
>   common/src/main/java/org/apache/sqoop/json/LinksBean.java 5858a18 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
>   common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MLink.java 7a9f538 
>   common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
>   common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
>   common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 811cbf0 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java f6447c6 
>   core/src/main/java/org/apache/sqoop/driver/SubmissionEngine.java 3a32e9f 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 2aeb07e 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ad380d3 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 514b5ac 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 4c2d062 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
>   server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
>   server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
>   server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
>   server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
>   server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
>   submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 631ceca 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 64b08fc 
> 
> Diff: https://reviews.apache.org/r/27330/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Veena Basavaraj <vb...@cloudera.com>.

> On Oct. 29, 2014, 6:28 p.m., Abraham Elmahrek wrote:
> > I think this patch blew up way out of scope. There are changes to the CLI that don't appear to be necessary immediately or can be moved to separate Jiras. For example, the "start" command is gone and replaced by a "submit" command. All of these changes have actually broken pieces of the shell client. Try running the following commands from the shell client:
> > # show job --all
> > # show connector --all
> > # help
> > 
> > Think it may be worth while to address these pieces separately?

1. All the changes here are in the scope of the ticket and the changes were discsused before. It is in the PDF. 
2. I cannot afford to break the CLI and make just the rest api changes. This has been the same principle I have used so far for the 4 other tickets in 1509, anytime I make the rest api change if I dont do CLI change integration tests will break
3. I tried to test the commands related to JOB, all of this is manual which sucks, but I awill look into it soon and see why the connector is broken. will upload a patch there.


> On Oct. 29, 2014, 6:28 p.m., Abraham Elmahrek wrote:
> > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfig.java, line 49
> > <https://reviews.apache.org/r/27330/diff/4/?file=742081#file742081line49>
> >
> >     Does this need to be changed? If so, let's do it in a separate jira. It's breaking the CLI.

must have creeped into this when I merged another patch, it will nto be here removing


> On Oct. 29, 2014, 6:28 p.m., Abraham Elmahrek wrote:
> > core/src/main/java/org/apache/sqoop/driver/JobManager.java, line 502
> > <https://reviews.apache.org/r/27330/diff/4/?file=742083#file742083line502>
> >
> >     This method just destroys the submission? Or does it test for job failure as well?

it is called only on job failure which is surprising to me, good you noticed it can you confirm it is expected to be called only on failure.


> On Oct. 29, 2014, 6:28 p.m., Abraham Elmahrek wrote:
> > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java, line 1577
> > <https://reviews.apache.org/r/27330/diff/4/?file=742088#file742088line1577>
> >
> >     NIT: Single string?

sure.


- Veena


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/#review59047
-----------------------------------------------------------


On Oct. 29, 2014, 5:04 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27330/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2014, 5:04 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see JIRA and its parent JIRA for details
> 
> All the WS stuff, I will do it in the end once the functionality is reviewd.
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c 
>   client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a 
>   client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
>   client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
>   client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
>   common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
>   common/src/main/java/org/apache/sqoop/json/LinksBean.java 5858a18 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
>   common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MLink.java 7a9f538 
>   common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
>   common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
>   common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 811cbf0 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartitioner.java 2411169 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfig.java 12ceb21 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java 3ae64f0 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java f6447c6 
>   core/src/main/java/org/apache/sqoop/driver/SubmissionEngine.java 3a32e9f 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 2aeb07e 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ad380d3 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b996a0b 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 4c2d062 
>   server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5694ea5 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
>   server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
>   server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
>   server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
>   server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
>   server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
>   shell/src/main/java/org/apache/sqoop/shell/AbortCommand.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/AbortJobFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 
>   shell/src/main/java/org/apache/sqoop/shell/StartCommand.java 7c56980 
>   shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
>   shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 
>   shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
>   shell/src/main/java/org/apache/sqoop/shell/StopCommand.java 50b2e81 
>   shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
>   shell/src/main/java/org/apache/sqoop/shell/SubmitCommand.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SubmitJobFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
>   shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 44d5920 
>   submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 631ceca 
>   test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java af31769 
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 64b08fc 
> 
> Diff: https://reviews.apache.org/r/27330/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Veena Basavaraj <vb...@cloudera.com>.

> On Oct. 29, 2014, 6:28 p.m., Abraham Elmahrek wrote:
> > I think this patch blew up way out of scope. There are changes to the CLI that don't appear to be necessary immediately or can be moved to separate Jiras. For example, the "start" command is gone and replaced by a "submit" command. All of these changes have actually broken pieces of the shell client. Try running the following commands from the shell client:
> > # show job --all
> > # show connector --all
> > # help
> > 
> > Think it may be worth while to address these pieces separately?
> 
> Veena Basavaraj wrote:
>     1. All the changes here are in the scope of the ticket and the changes were discsused before. It is in the PDF. 
>     2. I cannot afford to break the CLI and make just the rest api changes. This has been the same principle I have used so far for the 4 other tickets in 1509, anytime I make the rest api change if I dont do CLI change integration tests will break
>     3. I tried to test the commands related to JOB, all of this is manual which sucks, but I awill look into it soon and see why the connector is broken. will upload a patch there.

i tested the latest again and both commands work. Not sure what you were testing, let me know if you want me to send the sqoop war across


- Veena


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/#review59047
-----------------------------------------------------------


On Oct. 29, 2014, 5:04 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27330/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2014, 5:04 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see JIRA and its parent JIRA for details
> 
> All the WS stuff, I will do it in the end once the functionality is reviewd.
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c 
>   client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a 
>   client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
>   client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
>   client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
>   common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
>   common/src/main/java/org/apache/sqoop/json/LinksBean.java 5858a18 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
>   common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MLink.java 7a9f538 
>   common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
>   common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
>   common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 811cbf0 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartitioner.java 2411169 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfig.java 12ceb21 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java 3ae64f0 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java f6447c6 
>   core/src/main/java/org/apache/sqoop/driver/SubmissionEngine.java 3a32e9f 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 2aeb07e 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ad380d3 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b996a0b 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 4c2d062 
>   server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5694ea5 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
>   server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
>   server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
>   server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
>   server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
>   server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
>   shell/src/main/java/org/apache/sqoop/shell/AbortCommand.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/AbortJobFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 
>   shell/src/main/java/org/apache/sqoop/shell/StartCommand.java 7c56980 
>   shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
>   shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 
>   shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
>   shell/src/main/java/org/apache/sqoop/shell/StopCommand.java 50b2e81 
>   shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
>   shell/src/main/java/org/apache/sqoop/shell/SubmitCommand.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SubmitJobFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
>   shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 44d5920 
>   submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 631ceca 
>   test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java af31769 
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 64b08fc 
> 
> Diff: https://reviews.apache.org/r/27330/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Jarek Cecho <ja...@apache.org>.

> On Oct. 30, 2014, 1:28 a.m., Abraham Elmahrek wrote:
> > I think this patch blew up way out of scope. There are changes to the CLI that don't appear to be necessary immediately or can be moved to separate Jiras. For example, the "start" command is gone and replaced by a "submit" command. All of these changes have actually broken pieces of the shell client. Try running the following commands from the shell client:
> > # show job --all
> > # show connector --all
> > # help
> > 
> > Think it may be worth while to address these pieces separately?
> 
> Veena Basavaraj wrote:
>     1. All the changes here are in the scope of the ticket and the changes were discsused before. It is in the PDF. 
>     2. I cannot afford to break the CLI and make just the rest api changes. This has been the same principle I have used so far for the 4 other tickets in 1509, anytime I make the rest api change if I dont do CLI change integration tests will break
>     3. I tried to test the commands related to JOB, all of this is manual which sucks, but I awill look into it soon and see why the connector is broken. will upload a patch there.
> 
> Veena Basavaraj wrote:
>     i tested the latest again and both commands work. Not sure what you were testing, let me know if you want me to send the sqoop war across

We had a "submission" command in the past and we got feedback that it's confusing, so we've changed it to "start". Hence changing it back do yields need to have a separate JIRA with proper discussion, so that we have track why we are going back.


> On Oct. 30, 2014, 1:28 a.m., Abraham Elmahrek wrote:
> > core/src/main/java/org/apache/sqoop/driver/JobManager.java, line 502
> > <https://reviews.apache.org/r/27330/diff/4/?file=742083#file742083line502>
> >
> >     This method just destroys the submission? Or does it test for job failure as well?
> 
> Veena Basavaraj wrote:
>     it is called only on job failure which is surprising to me, good you noticed it can you confirm it is expected to be called only on failure.
> 
> Veena Basavaraj wrote:
>     boolean success = submissionEngine.submit(jobRequest);
>           if (!success) {
>             destroySubmissionOnJobSubmitFailure(jobRequest);
>             mJobSubmission.setStatus(SubmissionStatus.FAILURE_ON_SUBMIT);
>           }

Yup, this method is called only on submit failure, because in normal case "destroyers" are called from execution engine. As the submit has failed, the execution engine is not responsible for calling destroyers and hence we have to call them explicitly - it's sort of a corner case. In case of mapreduce, we're properly calling the destroyers in outputcommitter.


- Jarek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/#review59047
-----------------------------------------------------------


On Oct. 30, 2014, 9:08 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27330/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2014, 9:08 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see JIRA and its parent JIRA for details
> 
> All the WS stuff, I will do it in the end once the functionality is reviewd.
> 
> 
> If someone is wondering why START is changed to submit: there are tons of places in the code and in the java docs, we actually mean submit when we say START
> 
>   DRIVER_0008("Invalid combination of submission and execution engines"),
> 
>   DRIVER_0009("Job has been disabled. Cannot submit this job."),
> 
>   DRIVER_0010("Link for this job has been disabled. Cannot submit this job."),
> 
>   DRIVER_0011("Connector does not support specified direction. Cannot submit this job."),
> 
>   ;
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c 
>   client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a 
>   client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
>   client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
>   client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
>   common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
>   common/src/main/java/org/apache/sqoop/json/LinksBean.java 5858a18 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
>   common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MLink.java 7a9f538 
>   common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
>   common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
>   common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 811cbf0 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartitioner.java 2411169 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java 3ae64f0 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java f6447c6 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 2aeb07e 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ad380d3 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b996a0b 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 4c2d062 
>   server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5694ea5 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
>   server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
>   server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
>   server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
>   server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
>   server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
>   shell/src/main/java/org/apache/sqoop/shell/AbortCommand.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 
>   shell/src/main/java/org/apache/sqoop/shell/StartCommand.java 7c56980 
>   shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
>   shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 
>   shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
>   shell/src/main/java/org/apache/sqoop/shell/StopCommand.java 50b2e81 
>   shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
>   shell/src/main/java/org/apache/sqoop/shell/SubmitCommand.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SubmitJobFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
>   shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 44d5920 
>   shell/src/main/resources/shell-resource.properties 0e63c50 
>   test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java af31769 
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 64b08fc 
> 
> Diff: https://reviews.apache.org/r/27330/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Veena Basavaraj <vb...@cloudera.com>.

> On Oct. 29, 2014, 6:28 p.m., Abraham Elmahrek wrote:
> > core/src/main/java/org/apache/sqoop/driver/JobManager.java, line 502
> > <https://reviews.apache.org/r/27330/diff/4/?file=742083#file742083line502>
> >
> >     This method just destroys the submission? Or does it test for job failure as well?
> 
> Veena Basavaraj wrote:
>     it is called only on job failure which is surprising to me, good you noticed it can you confirm it is expected to be called only on failure.

boolean success = submissionEngine.submit(jobRequest);
      if (!success) {
        destroySubmissionOnJobSubmitFailure(jobRequest);
        mJobSubmission.setStatus(SubmissionStatus.FAILURE_ON_SUBMIT);
      }


- Veena


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/#review59047
-----------------------------------------------------------


On Oct. 29, 2014, 5:04 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27330/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2014, 5:04 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see JIRA and its parent JIRA for details
> 
> All the WS stuff, I will do it in the end once the functionality is reviewd.
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c 
>   client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a 
>   client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
>   client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
>   client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
>   common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
>   common/src/main/java/org/apache/sqoop/json/LinksBean.java 5858a18 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
>   common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MLink.java 7a9f538 
>   common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
>   common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
>   common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 811cbf0 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartitioner.java 2411169 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfig.java 12ceb21 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java 3ae64f0 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java f6447c6 
>   core/src/main/java/org/apache/sqoop/driver/SubmissionEngine.java 3a32e9f 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 2aeb07e 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ad380d3 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b996a0b 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 4c2d062 
>   server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5694ea5 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
>   server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
>   server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
>   server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
>   server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
>   server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
>   shell/src/main/java/org/apache/sqoop/shell/AbortCommand.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/AbortJobFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 
>   shell/src/main/java/org/apache/sqoop/shell/StartCommand.java 7c56980 
>   shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
>   shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 
>   shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
>   shell/src/main/java/org/apache/sqoop/shell/StopCommand.java 50b2e81 
>   shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
>   shell/src/main/java/org/apache/sqoop/shell/SubmitCommand.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SubmitJobFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
>   shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 44d5920 
>   submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 631ceca 
>   test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java af31769 
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 64b08fc 
> 
> Diff: https://reviews.apache.org/r/27330/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/#review59047
-----------------------------------------------------------


I think this patch blew up way out of scope. There are changes to the CLI that don't appear to be necessary immediately or can be moved to separate Jiras. For example, the "start" command is gone and replaced by a "submit" command. All of these changes have actually broken pieces of the shell client. Try running the following commands from the shell client:
# show job --all
# show connector --all
# help

Think it may be worth while to address these pieces separately?


client/src/main/java/org/apache/sqoop/client/SqoopClient.java
<https://reviews.apache.org/r/27330/#comment100326>

    NIT: Extra line



connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfig.java
<https://reviews.apache.org/r/27330/#comment100416>

    Does this need to be changed? If so, let's do it in a separate jira. It's breaking the CLI.



core/src/main/java/org/apache/sqoop/driver/JobManager.java
<https://reviews.apache.org/r/27330/#comment100411>

    This method just destroys the submission? Or does it test for job failure as well?



repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
<https://reviews.apache.org/r/27330/#comment100408>

    NIT: Single string?


- Abraham Elmahrek


On Oct. 30, 2014, 12:04 a.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27330/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2014, 12:04 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see JIRA and its parent JIRA for details
> 
> All the WS stuff, I will do it in the end once the functionality is reviewd.
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c 
>   client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a 
>   client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
>   client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
>   client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
>   common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
>   common/src/main/java/org/apache/sqoop/json/LinksBean.java 5858a18 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
>   common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MLink.java 7a9f538 
>   common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
>   common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
>   common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 811cbf0 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartitioner.java 2411169 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfig.java 12ceb21 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java 3ae64f0 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java f6447c6 
>   core/src/main/java/org/apache/sqoop/driver/SubmissionEngine.java 3a32e9f 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 2aeb07e 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ad380d3 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b996a0b 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 4c2d062 
>   server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5694ea5 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
>   server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
>   server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
>   server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
>   server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
>   server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
>   shell/src/main/java/org/apache/sqoop/shell/AbortCommand.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/AbortJobFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 
>   shell/src/main/java/org/apache/sqoop/shell/StartCommand.java 7c56980 
>   shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
>   shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 
>   shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
>   shell/src/main/java/org/apache/sqoop/shell/StopCommand.java 50b2e81 
>   shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
>   shell/src/main/java/org/apache/sqoop/shell/SubmitCommand.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SubmitJobFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
>   shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 44d5920 
>   submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 631ceca 
>   test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java af31769 
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 64b08fc 
> 
> Diff: https://reviews.apache.org/r/27330/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/#review59719
-----------------------------------------------------------



shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java
<https://reviews.apache.org/r/27330/#comment101032>

    yes good catch


- Veena Basavaraj


On Nov. 3, 2014, 9:25 a.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27330/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2014, 9:25 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see JIRA and its parent JIRA for details
> 
> FYI : it does nto include the start/submit and stop/abort renames.
> 
> new tickets have been added to address these
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c 
>   client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a 
>   client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
>   client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
>   client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
>   common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
>   common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
>   common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
>   core/src/main/java/org/apache/sqoop/driver/DriverError.java ddee282 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java ba56c77 
>   core/src/main/java/org/apache/sqoop/driver/JobRequest.java 2666320 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 976223d 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 1e22759 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 61d6b9b 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b324f4f 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
>   server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
>   server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
>   server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
>   shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 
>   shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
>   shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 
>   shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
>   shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 60f9500 
>   test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 06462a3 
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 
> 
> Diff: https://reviews.apache.org/r/27330/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/#review59730
-----------------------------------------------------------

Ship it!


Ship It!

- Abraham Elmahrek


On Nov. 3, 2014, 5:25 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27330/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2014, 5:25 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see JIRA and its parent JIRA for details
> 
> FYI : it does nto include the start/submit and stop/abort renames.
> 
> new tickets have been added to address these
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c 
>   client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a 
>   client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
>   client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
>   client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
>   common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
>   common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
>   common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
>   core/src/main/java/org/apache/sqoop/driver/DriverError.java ddee282 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java ba56c77 
>   core/src/main/java/org/apache/sqoop/driver/JobRequest.java 2666320 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 976223d 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 1e22759 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 61d6b9b 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b324f4f 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
>   server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
>   server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
>   server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
>   shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 
>   shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
>   shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 
>   shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
>   shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 60f9500 
>   test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 06462a3 
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 
> 
> Diff: https://reviews.apache.org/r/27330/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/#review59557
-----------------------------------------------------------

Ship it!


Good stuff! One small issue, but +1!


shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java
<https://reviews.apache.org/r/27330/#comment100829>

    Unintentional?


- Abraham Elmahrek


On Nov. 3, 2014, 5:25 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27330/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2014, 5:25 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see JIRA and its parent JIRA for details
> 
> FYI : it does nto include the start/submit and stop/abort renames.
> 
> new tickets have been added to address these
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c 
>   client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a 
>   client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
>   client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
>   client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
>   common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
>   common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
>   common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
>   core/src/main/java/org/apache/sqoop/driver/DriverError.java ddee282 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java ba56c77 
>   core/src/main/java/org/apache/sqoop/driver/JobRequest.java 2666320 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 976223d 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 1e22759 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 61d6b9b 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b324f4f 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
>   server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
>   server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
>   server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
>   shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 
>   shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
>   shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 
>   shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
>   shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 60f9500 
>   test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 06462a3 
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 
> 
> Diff: https://reviews.apache.org/r/27330/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/
-----------------------------------------------------------

(Updated Nov. 3, 2014, 9:25 a.m.)


Review request for Sqoop.


Changes
-------

rebased as of 9.24 A.M nov 3rd


Repository: sqoop-sqoop2


Description
-------

see JIRA and its parent JIRA for details

FYI : it does nto include the start/submit and stop/abort renames.

new tickets have been added to address these


Diffs (updated)
-----

  client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c 
  client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a 
  client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
  client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
  client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
  common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
  common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
  common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
  common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
  common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
  common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
  core/src/main/java/org/apache/sqoop/driver/DriverError.java ddee282 
  core/src/main/java/org/apache/sqoop/driver/JobManager.java ba56c77 
  core/src/main/java/org/apache/sqoop/driver/JobRequest.java 2666320 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 976223d 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 1e22759 
  core/src/main/java/org/apache/sqoop/repository/Repository.java 61d6b9b 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b324f4f 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
  server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
  server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
  server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
  server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
  server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
  server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
  server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
  shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 
  shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
  shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 
  shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
  shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
  shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
  shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 60f9500 
  test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 06462a3 
  test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443 
  tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 

Diff: https://reviews.apache.org/r/27330/diff/


Testing
-------

yes


Thanks,

Veena Basavaraj

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/
-----------------------------------------------------------

(Updated Nov. 2, 2014, 6:47 p.m.)


Review request for Sqoop.


Changes
-------

Rebased to latest as of 6.47 Nov 2


Repository: sqoop-sqoop2


Description
-------

see JIRA and its parent JIRA for details

FYI : it does nto include the start/submit and stop/abort renames.

new tickets have been added to address these


Diffs (updated)
-----

  client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c 
  client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a 
  client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
  client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
  client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
  common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
  common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
  common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
  common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
  common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
  common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
  core/src/main/java/org/apache/sqoop/driver/DriverError.java ddee282 
  core/src/main/java/org/apache/sqoop/driver/JobManager.java ba56c77 
  core/src/main/java/org/apache/sqoop/driver/JobRequest.java 2666320 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 976223d 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 1e22759 
  core/src/main/java/org/apache/sqoop/repository/Repository.java 09989e0 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b324f4f 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
  server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
  server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
  server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
  server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
  server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
  server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
  server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
  server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
  server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
  shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 
  shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
  shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 
  shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
  shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
  shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
  shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
  test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 06462a3 
  test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443 
  tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 

Diff: https://reviews.apache.org/r/27330/diff/


Testing
-------

yes


Thanks,

Veena Basavaraj

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/
-----------------------------------------------------------

(Updated Oct. 31, 2014, 2:29 p.m.)


Review request for Sqoop.


Changes
-------

Make Stanley happy with (SQOOP-1650) fixes as well. 


Repository: sqoop-sqoop2


Description
-------

see JIRA and its parent JIRA for details

FYI : it does nto include the start/submit and stop/abort renames.

new tickets have been added to address these


Diffs (updated)
-----

  client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c 
  client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a 
  client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
  client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
  client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
  common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
  common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
  common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
  common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
  common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
  common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
  core/src/main/java/org/apache/sqoop/driver/DriverError.java ddee282 
  core/src/main/java/org/apache/sqoop/driver/JobManager.java f6447c6 
  core/src/main/java/org/apache/sqoop/driver/JobRequest.java 2666320 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 2aeb07e 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ad380d3 
  core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b996a0b 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
  server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
  server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
  server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
  server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
  server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
  server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
  server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
  server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
  server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
  shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 
  shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
  shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 
  shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
  shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
  shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
  shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
  test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java af31769 
  test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443 
  tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 

Diff: https://reviews.apache.org/r/27330/diff/


Testing
-------

yes


Thanks,

Veena Basavaraj

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/
-----------------------------------------------------------

(Updated Oct. 31, 2014, 2:02 p.m.)


Review request for Sqoop.


Changes
-------

after rebase.


Repository: sqoop-sqoop2


Description
-------

see JIRA and its parent JIRA for details

FYI : it does nto include the start/submit and stop/abort renames.

new tickets have been added to address these


Diffs (updated)
-----

  client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c 
  client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a 
  client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
  client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
  client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
  common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
  common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
  common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
  common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
  common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
  common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
  core/src/main/java/org/apache/sqoop/driver/DriverError.java ddee282 
  core/src/main/java/org/apache/sqoop/driver/JobManager.java f6447c6 
  core/src/main/java/org/apache/sqoop/driver/JobRequest.java 2666320 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 2aeb07e 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ad380d3 
  core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b996a0b 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
  server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
  server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
  server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
  server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
  server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
  server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
  server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
  server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
  server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
  shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 
  shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
  shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 
  shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
  shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
  shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
  shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
  test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java af31769 
  test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443 
  tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 

Diff: https://reviews.apache.org/r/27330/diff/


Testing
-------

yes


Thanks,

Veena Basavaraj

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/
-----------------------------------------------------------

(Updated Oct. 31, 2014, 1:57 p.m.)


Review request for Sqoop.


Repository: sqoop-sqoop2


Description
-------

see JIRA and its parent JIRA for details

FYI : it does nto include the start/submit and stop/abort renames.

new tickets have been added to address these


Diffs (updated)
-----

  client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c 
  client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a 
  client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
  client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
  client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
  common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
  common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
  common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
  common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
  common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
  common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
  core/src/main/java/org/apache/sqoop/driver/DriverError.java ddee282 
  core/src/main/java/org/apache/sqoop/driver/JobManager.java f6447c6 
  core/src/main/java/org/apache/sqoop/driver/JobRequest.java 2666320 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 2aeb07e 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ad380d3 
  core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b996a0b 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
  server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
  server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
  server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
  server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
  server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
  server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
  server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
  server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
  server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
  shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 
  shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
  shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 
  shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
  shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
  shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
  shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
  test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java af31769 
  test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443 
  tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 

Diff: https://reviews.apache.org/r/27330/diff/


Testing
-------

yes


Thanks,

Veena Basavaraj

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/#review59409
-----------------------------------------------------------



core/src/main/java/org/apache/sqoop/repository/Repository.java
<https://reviews.apache.org/r/27330/#comment100676>

    NOTE: this exists since I have to rebase to another patch. It will be removed.


- Veena Basavaraj


On Oct. 31, 2014, 1:46 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27330/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2014, 1:46 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see JIRA and its parent JIRA for details
> 
> FYI : it does nto include the start/submit and stop/abort renames.
> 
> new tickets have been added to address these
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c 
>   client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a 
>   client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
>   client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
>   client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
>   common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
>   common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
>   common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
>   core/src/main/java/org/apache/sqoop/driver/DriverError.java ddee282 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java f6447c6 
>   core/src/main/java/org/apache/sqoop/driver/JobRequest.java 2666320 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 2aeb07e 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ad380d3 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b996a0b 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
>   server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
>   server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
>   server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
>   server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
>   server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
>   shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 
>   shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
>   shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 
>   shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
>   shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
>   test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java af31769 
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 
> 
> Diff: https://reviews.apache.org/r/27330/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/
-----------------------------------------------------------

(Updated Oct. 31, 2014, 1:46 p.m.)


Review request for Sqoop.


Repository: sqoop-sqoop2


Description (updated)
-------

see JIRA and its parent JIRA for details

FYI : it does nto include the start/submit and stop/abort renames.

new tickets have been added to address these


Diffs (updated)
-----

  client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c 
  client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a 
  client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
  client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
  client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
  common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
  common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
  common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
  common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
  common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
  common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
  core/src/main/java/org/apache/sqoop/driver/DriverError.java ddee282 
  core/src/main/java/org/apache/sqoop/driver/JobManager.java f6447c6 
  core/src/main/java/org/apache/sqoop/driver/JobRequest.java 2666320 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 2aeb07e 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ad380d3 
  core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b996a0b 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
  server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
  server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
  server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
  server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
  server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
  server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
  server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a 
  server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
  server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
  server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
  shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 
  shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
  shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 
  shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
  shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
  shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
  shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
  test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java af31769 
  test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443 
  tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 

Diff: https://reviews.apache.org/r/27330/diff/


Testing
-------

yes


Thanks,

Veena Basavaraj

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Veena Basavaraj <vb...@cloudera.com>.

> On Oct. 30, 2014, 10:26 p.m., Qian Xu wrote:
> > client/src/main/java/org/apache/sqoop/client/SqoopClient.java, line 460
> > <https://reviews.apache.org/r/27330/diff/7/?file=743043#file743043line460>
> >
> >     The original `first` is more straightforward to understand
> 
> Veena Basavaraj wrote:
>     explain why, the reason it is changed it because, there is a enum on the client that holds the status and it was called "SUBMITTED"/ UPDATED.  the java doc was missed, what it really meant it started. since we want to use Start.
>     
>     I encourage you spend some time readinf the JIRA and the code, there is so much inconsistency between submit and start, done over time and I am trying to fix it.

I have moved this discussion to a new JIRA as to why we have 2 enums and how we can use submit/start consistently

https://issues.apache.org/jira/browse/SQOOP-1652


> On Oct. 30, 2014, 10:26 p.m., Qian Xu wrote:
> > common/src/main/java/org/apache/sqoop/json/JobBean.java, line 114
> > <https://reviews.apache.org/r/27330/diff/7/?file=743048#file743048line114>
> >
> >     I see you new an array and passed in. How about changing `void` to `JSONArray`? I'm afraid that when you passing an array and you cannot garantee existing elementes are not modified.
> 
> Veena Basavaraj wrote:
>     I rather not do this in this RB, since there are other places that follow this a pattern that was shipped, file a ticket so I can consistently change it all places

fixed in this RB for jobs/submisisons


- Veena


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/#review59303
-----------------------------------------------------------


On Nov. 2, 2014, 6:47 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27330/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2014, 6:47 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see JIRA and its parent JIRA for details
> 
> FYI : it does nto include the start/submit and stop/abort renames.
> 
> new tickets have been added to address these
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c 
>   client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a 
>   client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
>   client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
>   client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
>   common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
>   common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
>   common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
>   core/src/main/java/org/apache/sqoop/driver/DriverError.java ddee282 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java ba56c77 
>   core/src/main/java/org/apache/sqoop/driver/JobRequest.java 2666320 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 976223d 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 1e22759 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 09989e0 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b324f4f 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
>   server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
>   server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
>   server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
>   server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
>   server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
>   shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 
>   shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
>   shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 
>   shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
>   shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
>   test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 06462a3 
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 
> 
> Diff: https://reviews.apache.org/r/27330/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Veena Basavaraj <vb...@cloudera.com>.

> On Oct. 30, 2014, 10:26 p.m., Qian Xu wrote:
> > client/src/main/java/org/apache/sqoop/client/SqoopClient.java, line 460
> > <https://reviews.apache.org/r/27330/diff/7/?file=743043#file743043line460>
> >
> >     The original `first` is more straightforward to understand

explain why, the reason it is changed it because, there is a enum on the client that holds the status and it was called "SUBMITTED"/ UPDATED.  the java doc was missed, what it really meant it started. since we want to use Start.

I encourage you spend some time readinf the JIRA and the code, there is so much inconsistency between submit and start, done over time and I am trying to fix it.


> On Oct. 30, 2014, 10:26 p.m., Qian Xu wrote:
> > common/src/main/java/org/apache/sqoop/json/JobBean.java, line 114
> > <https://reviews.apache.org/r/27330/diff/7/?file=743048#file743048line114>
> >
> >     I see you new an array and passed in. How about changing `void` to `JSONArray`? I'm afraid that when you passing an array and you cannot garantee existing elementes are not modified.

I rather not do this in this RB, since there are other places that follow this a pattern that was shipped, file a ticket so I can consistently change it all places


- Veena


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/#review59303
-----------------------------------------------------------


On Oct. 30, 2014, 2:08 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27330/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2014, 2:08 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see JIRA and its parent JIRA for details
> 
> All the WS stuff, I will do it in the end once the functionality is reviewd.
> 
> 
> If someone is wondering why START is changed to submit: there are tons of places in the code and in the java docs, we actually mean submit when we say START
> 
>   DRIVER_0008("Invalid combination of submission and execution engines"),
> 
>   DRIVER_0009("Job has been disabled. Cannot submit this job."),
> 
>   DRIVER_0010("Link for this job has been disabled. Cannot submit this job."),
> 
>   DRIVER_0011("Connector does not support specified direction. Cannot submit this job."),
> 
>   ;
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c 
>   client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a 
>   client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
>   client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
>   client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
>   common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
>   common/src/main/java/org/apache/sqoop/json/LinksBean.java 5858a18 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
>   common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MLink.java 7a9f538 
>   common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
>   common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
>   common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 811cbf0 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartitioner.java 2411169 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java 3ae64f0 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java f6447c6 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 2aeb07e 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ad380d3 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b996a0b 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 4c2d062 
>   server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5694ea5 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
>   server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
>   server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
>   server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
>   server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
>   server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
>   shell/src/main/java/org/apache/sqoop/shell/AbortCommand.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 
>   shell/src/main/java/org/apache/sqoop/shell/StartCommand.java 7c56980 
>   shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
>   shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 
>   shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
>   shell/src/main/java/org/apache/sqoop/shell/StopCommand.java 50b2e81 
>   shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
>   shell/src/main/java/org/apache/sqoop/shell/SubmitCommand.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SubmitJobFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
>   shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 44d5920 
>   shell/src/main/resources/shell-resource.properties 0e63c50 
>   test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java af31769 
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 64b08fc 
> 
> Diff: https://reviews.apache.org/r/27330/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Qian Xu <sx...@googlemail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/#review59303
-----------------------------------------------------------



client/src/main/java/org/apache/sqoop/client/SqoopClient.java
<https://reviews.apache.org/r/27330/#comment100567>

    The original `first` is more straightforward to understand



client/src/main/java/org/apache/sqoop/client/SqoopClient.java
<https://reviews.apache.org/r/27330/#comment100568>

    `default` case is for sqoop an unhandled case. at least print a warning in log, or throw an exception.



client/src/main/java/org/apache/sqoop/client/SqoopClient.java
<https://reviews.apache.org/r/27330/#comment100569>

    Typo?



common/src/main/java/org/apache/sqoop/json/JobBean.java
<https://reviews.apache.org/r/27330/#comment100572>

    I see you new an array and passed in. How about changing `void` to `JSONArray`? I'm afraid that when you passing an array and you cannot garantee existing elementes are not modified.



common/src/main/java/org/apache/sqoop/json/SubmissionBean.java
<https://reviews.apache.org/r/27330/#comment100573>

    How about change `void` to `JSONArray`. (For same reason)



common/src/main/java/org/apache/sqoop/json/SubmissionBean.java
<https://reviews.apache.org/r/27330/#comment100574>

    Ditto


- Qian Xu


On Oct. 31, 2014, 5:08 a.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27330/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2014, 5:08 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see JIRA and its parent JIRA for details
> 
> All the WS stuff, I will do it in the end once the functionality is reviewd.
> 
> 
> If someone is wondering why START is changed to submit: there are tons of places in the code and in the java docs, we actually mean submit when we say START
> 
>   DRIVER_0008("Invalid combination of submission and execution engines"),
> 
>   DRIVER_0009("Job has been disabled. Cannot submit this job."),
> 
>   DRIVER_0010("Link for this job has been disabled. Cannot submit this job."),
> 
>   DRIVER_0011("Connector does not support specified direction. Cannot submit this job."),
> 
>   ;
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c 
>   client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a 
>   client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
>   client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
>   client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
>   common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
>   common/src/main/java/org/apache/sqoop/json/LinksBean.java 5858a18 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
>   common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MLink.java 7a9f538 
>   common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
>   common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
>   common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 811cbf0 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartitioner.java 2411169 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java 3ae64f0 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java f6447c6 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 2aeb07e 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ad380d3 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b996a0b 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 4c2d062 
>   server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5694ea5 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
>   server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
>   server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
>   server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
>   server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
>   server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
>   shell/src/main/java/org/apache/sqoop/shell/AbortCommand.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 
>   shell/src/main/java/org/apache/sqoop/shell/StartCommand.java 7c56980 
>   shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
>   shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 
>   shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
>   shell/src/main/java/org/apache/sqoop/shell/StopCommand.java 50b2e81 
>   shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
>   shell/src/main/java/org/apache/sqoop/shell/SubmitCommand.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SubmitJobFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
>   shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 44d5920 
>   shell/src/main/resources/shell-resource.properties 0e63c50 
>   test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java af31769 
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 64b08fc 
> 
> Diff: https://reviews.apache.org/r/27330/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Veena Basavaraj <vb...@cloudera.com>.

> On Oct. 30, 2014, 3:06 p.m., Gwen Shapira wrote:
> > client/src/main/java/org/apache/sqoop/client/SqoopClient.java, lines 508-509
> > <https://reviews.apache.org/r/27330/diff/7/?file=743043#file743043line508>
> >
> >     This change of deleteSubmission to stopJob was not in the JIRA or doc.

Sure,  the doc/ JIRA had high level description of the proposed changes to the actions on the JOB

enable/ disable/ submit / abort

The client will perform these actions

submit a job
stop a job ( deleting a submission is not the same as stop Job, when stop is called, we call the MR engine. killJOb and then we clean up the submission record.) So the rename was done to make sure that stopJob does more than just deleting submission.

does this explain?


- Veena


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/#review59264
-----------------------------------------------------------


On Oct. 30, 2014, 2:08 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27330/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2014, 2:08 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see JIRA and its parent JIRA for details
> 
> All the WS stuff, I will do it in the end once the functionality is reviewd.
> 
> 
> If someone is wondering why START is changed to submit: there are tons of places in the code and in the java docs, we actually mean submit when we say START
> 
>   DRIVER_0008("Invalid combination of submission and execution engines"),
> 
>   DRIVER_0009("Job has been disabled. Cannot submit this job."),
> 
>   DRIVER_0010("Link for this job has been disabled. Cannot submit this job."),
> 
>   DRIVER_0011("Connector does not support specified direction. Cannot submit this job."),
> 
>   ;
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c 
>   client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a 
>   client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
>   client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
>   client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
>   common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
>   common/src/main/java/org/apache/sqoop/json/LinksBean.java 5858a18 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
>   common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MLink.java 7a9f538 
>   common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
>   common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
>   common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 811cbf0 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartitioner.java 2411169 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java 3ae64f0 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java f6447c6 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 2aeb07e 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ad380d3 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b996a0b 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 4c2d062 
>   server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5694ea5 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
>   server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
>   server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
>   server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
>   server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
>   server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
>   shell/src/main/java/org/apache/sqoop/shell/AbortCommand.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 
>   shell/src/main/java/org/apache/sqoop/shell/StartCommand.java 7c56980 
>   shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
>   shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 
>   shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
>   shell/src/main/java/org/apache/sqoop/shell/StopCommand.java 50b2e81 
>   shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
>   shell/src/main/java/org/apache/sqoop/shell/SubmitCommand.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SubmitJobFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
>   shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 44d5920 
>   shell/src/main/resources/shell-resource.properties 0e63c50 
>   test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java af31769 
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 64b08fc 
> 
> Diff: https://reviews.apache.org/r/27330/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Veena Basavaraj <vb...@cloudera.com>.

> On Oct. 30, 2014, 3:06 p.m., Gwen Shapira wrote:
> > client/src/main/java/org/apache/sqoop/client/SqoopClient.java, lines 508-509
> > <https://reviews.apache.org/r/27330/diff/7/?file=743043#file743043line508>
> >
> >     This change of deleteSubmission to stopJob was not in the JIRA or doc.
> 
> Veena Basavaraj wrote:
>     Sure,  the doc/ JIRA had high level description of the proposed changes to the actions on the JOB
>     
>     enable/ disable/ submit / abort
>     
>     The client will perform these actions
>     
>     submit a job
>     stop a job ( deleting a submission is not the same as stop Job, when stop is called, we call the MR engine. killJOb and then we clean up the submission record.) So the rename was done to make sure that stopJob does more than just deleting submission.
>     
>     does this explain?
> 
> Gwen Shapira wrote:
>     I think so. So this is actually stopJobRequest?

yes it is.


- Veena


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/#review59264
-----------------------------------------------------------


On Oct. 30, 2014, 2:08 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27330/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2014, 2:08 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see JIRA and its parent JIRA for details
> 
> All the WS stuff, I will do it in the end once the functionality is reviewd.
> 
> 
> If someone is wondering why START is changed to submit: there are tons of places in the code and in the java docs, we actually mean submit when we say START
> 
>   DRIVER_0008("Invalid combination of submission and execution engines"),
> 
>   DRIVER_0009("Job has been disabled. Cannot submit this job."),
> 
>   DRIVER_0010("Link for this job has been disabled. Cannot submit this job."),
> 
>   DRIVER_0011("Connector does not support specified direction. Cannot submit this job."),
> 
>   ;
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c 
>   client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a 
>   client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
>   client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
>   client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
>   common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
>   common/src/main/java/org/apache/sqoop/json/LinksBean.java 5858a18 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
>   common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MLink.java 7a9f538 
>   common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
>   common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
>   common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 811cbf0 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartitioner.java 2411169 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java 3ae64f0 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java f6447c6 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 2aeb07e 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ad380d3 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b996a0b 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 4c2d062 
>   server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5694ea5 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
>   server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
>   server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
>   server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
>   server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
>   server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
>   shell/src/main/java/org/apache/sqoop/shell/AbortCommand.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 
>   shell/src/main/java/org/apache/sqoop/shell/StartCommand.java 7c56980 
>   shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
>   shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 
>   shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
>   shell/src/main/java/org/apache/sqoop/shell/StopCommand.java 50b2e81 
>   shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
>   shell/src/main/java/org/apache/sqoop/shell/SubmitCommand.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SubmitJobFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
>   shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 44d5920 
>   shell/src/main/resources/shell-resource.properties 0e63c50 
>   test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java af31769 
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 64b08fc 
> 
> Diff: https://reviews.apache.org/r/27330/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Gwen Shapira <gs...@cloudera.com>.

> On Oct. 30, 2014, 10:06 p.m., Gwen Shapira wrote:
> > client/src/main/java/org/apache/sqoop/client/SqoopClient.java, lines 508-509
> > <https://reviews.apache.org/r/27330/diff/7/?file=743043#file743043line508>
> >
> >     This change of deleteSubmission to stopJob was not in the JIRA or doc.
> 
> Veena Basavaraj wrote:
>     Sure,  the doc/ JIRA had high level description of the proposed changes to the actions on the JOB
>     
>     enable/ disable/ submit / abort
>     
>     The client will perform these actions
>     
>     submit a job
>     stop a job ( deleting a submission is not the same as stop Job, when stop is called, we call the MR engine. killJOb and then we clean up the submission record.) So the rename was done to make sure that stopJob does more than just deleting submission.
>     
>     does this explain?

I think so. So this is actually stopJobRequest?


- Gwen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/#review59264
-----------------------------------------------------------


On Oct. 30, 2014, 9:08 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27330/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2014, 9:08 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see JIRA and its parent JIRA for details
> 
> All the WS stuff, I will do it in the end once the functionality is reviewd.
> 
> 
> If someone is wondering why START is changed to submit: there are tons of places in the code and in the java docs, we actually mean submit when we say START
> 
>   DRIVER_0008("Invalid combination of submission and execution engines"),
> 
>   DRIVER_0009("Job has been disabled. Cannot submit this job."),
> 
>   DRIVER_0010("Link for this job has been disabled. Cannot submit this job."),
> 
>   DRIVER_0011("Connector does not support specified direction. Cannot submit this job."),
> 
>   ;
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c 
>   client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a 
>   client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
>   client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
>   client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
>   common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
>   common/src/main/java/org/apache/sqoop/json/LinksBean.java 5858a18 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
>   common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MLink.java 7a9f538 
>   common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
>   common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
>   common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 811cbf0 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartitioner.java 2411169 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java 3ae64f0 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java f6447c6 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 2aeb07e 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ad380d3 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b996a0b 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 4c2d062 
>   server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5694ea5 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
>   server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
>   server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
>   server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
>   server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
>   server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
>   shell/src/main/java/org/apache/sqoop/shell/AbortCommand.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 
>   shell/src/main/java/org/apache/sqoop/shell/StartCommand.java 7c56980 
>   shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
>   shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 
>   shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
>   shell/src/main/java/org/apache/sqoop/shell/StopCommand.java 50b2e81 
>   shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
>   shell/src/main/java/org/apache/sqoop/shell/SubmitCommand.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SubmitJobFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
>   shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 44d5920 
>   shell/src/main/resources/shell-resource.properties 0e63c50 
>   test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java af31769 
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 64b08fc 
> 
> Diff: https://reviews.apache.org/r/27330/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Gwen Shapira <gs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/#review59264
-----------------------------------------------------------



client/src/main/java/org/apache/sqoop/client/SqoopClient.java
<https://reviews.apache.org/r/27330/#comment100532>

    This change of deleteSubmission to stopJob was not in the JIRA or doc.


- Gwen Shapira


On Oct. 30, 2014, 9:08 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27330/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2014, 9:08 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see JIRA and its parent JIRA for details
> 
> All the WS stuff, I will do it in the end once the functionality is reviewd.
> 
> 
> If someone is wondering why START is changed to submit: there are tons of places in the code and in the java docs, we actually mean submit when we say START
> 
>   DRIVER_0008("Invalid combination of submission and execution engines"),
> 
>   DRIVER_0009("Job has been disabled. Cannot submit this job."),
> 
>   DRIVER_0010("Link for this job has been disabled. Cannot submit this job."),
> 
>   DRIVER_0011("Connector does not support specified direction. Cannot submit this job."),
> 
>   ;
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c 
>   client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a 
>   client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
>   client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
>   client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
>   common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
>   common/src/main/java/org/apache/sqoop/json/LinksBean.java 5858a18 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
>   common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MLink.java 7a9f538 
>   common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
>   common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
>   common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 811cbf0 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartitioner.java 2411169 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java 3ae64f0 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java f6447c6 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 2aeb07e 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ad380d3 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b996a0b 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 4c2d062 
>   server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5694ea5 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
>   server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
>   server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
>   server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
>   server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
>   server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
>   shell/src/main/java/org/apache/sqoop/shell/AbortCommand.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 
>   shell/src/main/java/org/apache/sqoop/shell/StartCommand.java 7c56980 
>   shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
>   shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 
>   shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
>   shell/src/main/java/org/apache/sqoop/shell/StopCommand.java 50b2e81 
>   shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
>   shell/src/main/java/org/apache/sqoop/shell/SubmitCommand.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SubmitJobFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
>   shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 44d5920 
>   shell/src/main/resources/shell-resource.properties 0e63c50 
>   test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java af31769 
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 64b08fc 
> 
> Diff: https://reviews.apache.org/r/27330/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Veena Basavaraj <vb...@cloudera.com>.

> On Oct. 31, 2014, 6:57 a.m., Jarek Cecho wrote:
> > client/src/main/java/org/apache/sqoop/client/SqoopClient.java, line 85
> > <https://reviews.apache.org/r/27330/diff/7/?file=743043#file743043line85>
> >
> >     I do feel that "SUBMITTED" and "STARTED" are two different cases. Submitted means that we've created the request to start a new job that will eventually transfer data. Started means that the job has started and is running now.
> >     
> >     This call will only create that request and will return before the actuall job will START. I don't see much different on our testing cluster as Submitted job is started pretty much immediately, however on real clusters the delay between submission and start can be significant as the job can be sitting in a scheduler queue for substantial amount of time before it starts (especially on busy clusters).

there are subtle differences, submit and start are used in very different ways. 

Think about this from the time we issue a command in the client, going by your explanation the command should be submit. I am utterly confused reading this code and how we have just used started and submitted without much thought.

I appreciate if we look at this from the client command / status to the execution engine on what we want to call as submit and what should be start.


> On Oct. 31, 2014, 6:57 a.m., Jarek Cecho wrote:
> > common/src/main/java/org/apache/sqoop/json/JobsBean.java, line 29
> > <https://reviews.apache.org/r/27330/diff/7/?file=743049#file743049line29>
> >
> >     I'm wondering why we are introducing this plural bean? I've noticed that we did something similar for the link recently as well.
> >     
> >     All our beans has been historically written in a way that they supported 1..N objects. Hence they were usable in all cases. This seems unnecessary change to me as now the code using the beans needs to have if-else statements to distinguish what exactly is being send.

read the JIRA and the related tickets for 1509, they are two different JSON structures, historically done does not mean it has to stay that unless it is making it obvious.

if I sending a JOB, I would see the root to be JOB, if I request a collection it better be JOBS.


> On Oct. 31, 2014, 6:57 a.m., Jarek Cecho wrote:
> > core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java, lines 508-520
> > <https://reviews.apache.org/r/27330/diff/7/?file=743062#file743062line508>
> >
> >     This move seems unencessary?

why? would you care to ask why I felt it is necessary? 

when reading code, having all the links related apis in one places makes it wasy for some one to not miss the apis. Whats wrong with moving, you want another RB for it? say that. 

Jus think about how you organize your table, when we write code lets do the same, organize things so that at one shot we know what the apis for links are. I would even want to split this up into logical classes as we have groen the repository apis, see how hard it is to add post gres, wish we had thight through this before.


> On Oct. 31, 2014, 6:57 a.m., Jarek Cecho wrote:
> > core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java, line 360
> > <https://reviews.apache.org/r/27330/diff/7/?file=743063#file743063line360>
> >
> >     Repository can't submit job as that is a job of execution engine. Repository is just storing the submission metadata. Hence I would prefer to keep the original name as this one seems misleading to me.

this has been changed, see the JIRA, this RB is stale .


> On Oct. 31, 2014, 6:57 a.m., Jarek Cecho wrote:
> > core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java, line 392
> > <https://reviews.apache.org/r/27330/diff/7/?file=743063#file743063line392>
> >
> >     Just FYI: Entire code base is written in a way that all methods, variables, properties are from most generic to most specific. So that when you sort all the methods alphabetically (which majority of the tools does), you can see all methods for let say "submission" next to each other. This entire review is changing that on majority of the places to "common english". 
> >     
> >     I'm wondering if there is a technical reason for that?

it is not, why do we call it findSbmissions and not Submissions find, why to we call it updateLink than linkUpdate? entire is a strong word

How does find become the prefix and not Unfinished.


- Veena


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/#review59331
-----------------------------------------------------------


On Oct. 30, 2014, 2:08 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27330/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2014, 2:08 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see JIRA and its parent JIRA for details
> 
> All the WS stuff, I will do it in the end once the functionality is reviewd.
> 
> 
> If someone is wondering why START is changed to submit: there are tons of places in the code and in the java docs, we actually mean submit when we say START
> 
>   DRIVER_0008("Invalid combination of submission and execution engines"),
> 
>   DRIVER_0009("Job has been disabled. Cannot submit this job."),
> 
>   DRIVER_0010("Link for this job has been disabled. Cannot submit this job."),
> 
>   DRIVER_0011("Connector does not support specified direction. Cannot submit this job."),
> 
>   ;
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c 
>   client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a 
>   client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
>   client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
>   client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
>   common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
>   common/src/main/java/org/apache/sqoop/json/LinksBean.java 5858a18 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
>   common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MLink.java 7a9f538 
>   common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
>   common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
>   common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 811cbf0 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartitioner.java 2411169 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java 3ae64f0 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java f6447c6 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 2aeb07e 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ad380d3 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b996a0b 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 4c2d062 
>   server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5694ea5 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
>   server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
>   server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
>   server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
>   server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
>   server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
>   shell/src/main/java/org/apache/sqoop/shell/AbortCommand.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 
>   shell/src/main/java/org/apache/sqoop/shell/StartCommand.java 7c56980 
>   shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
>   shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 
>   shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
>   shell/src/main/java/org/apache/sqoop/shell/StopCommand.java 50b2e81 
>   shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
>   shell/src/main/java/org/apache/sqoop/shell/SubmitCommand.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SubmitJobFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
>   shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 44d5920 
>   shell/src/main/resources/shell-resource.properties 0e63c50 
>   test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java af31769 
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 64b08fc 
> 
> Diff: https://reviews.apache.org/r/27330/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Veena Basavaraj <vb...@cloudera.com>.

> On Oct. 31, 2014, 6:57 a.m., Jarek Cecho wrote:
> > client/src/main/java/org/apache/sqoop/client/SqoopClient.java, line 85
> > <https://reviews.apache.org/r/27330/diff/7/?file=743043#file743043line85>
> >
> >     I do feel that "SUBMITTED" and "STARTED" are two different cases. Submitted means that we've created the request to start a new job that will eventually transfer data. Started means that the job has started and is running now.
> >     
> >     This call will only create that request and will return before the actuall job will START. I don't see much different on our testing cluster as Submitted job is started pretty much immediately, however on real clusters the delay between submission and start can be significant as the job can be sitting in a scheduler queue for substantial amount of time before it starts (especially on busy clusters).
> 
> Veena Basavaraj wrote:
>     there are subtle differences, submit and start are used in very different ways. 
>     
>     Think about this from the time we issue a command in the client, going by your explanation the command should be submit. I am utterly confused reading this code and how we have just used started and submitted without much thought.
>     
>     I appreciate if we look at this from the client command / status to the execution engine on what we want to call as submit and what should be start.
> 
> Jarek Cecho wrote:
>     I think that the client and REST API have different audiences that have different requirements. Most of the users don't know nor want to know the diffence between Submit and Start. I feel that the fact that those are two independent steps is pretty much an "implementation detail" from their perspective. On the other hand the connector developper or someone who will integrate with the REST API should know the difference and hence it's exposed there. I believe that this is intentional. 
>     
>     The project do have parts that are meant for different audiences and I think that it's reasonable that different audiences are presented with slightly different point of view. Simplification for users seems as good idea whereas we should say accurate for someone who is extending Sqoop.
> 
> Veena Basavaraj wrote:
>     correct me, I am not confused here.
>     
>     There is SqoopCLient -> so who is the audience for client. My understanding is that anyone can use it. Not retreicted to developer. Using rest/ client is a matter of preference is what I beleive.
>     
>     Second, I do not think different audiences need a different picture, it just makes our coding and rationalizing what we do in sqoop code harder. 
>     
>     Second, what is "most" mean? there are differences in clearly how we use them. submit is like putting it on a queue for it to start. As you clealry artiuclated it, it might start immediately or be delayed. There are error messages when I use a start command,it says I cannot submit the job, what does this indicate?
>     
>     Lets fix this. It might sound very trivial to you, but going forward it will lead to more confusion if one another person joins this team and wants his /her way.
>     
>     The rest api uses the SubmissionStatus I suppose directly and the SQoop client uses its own enum. Why?

see JIRA for details, taking this discussion to new a JIRA and new RB.


- Veena


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/#review59331
-----------------------------------------------------------


On Oct. 30, 2014, 2:08 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27330/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2014, 2:08 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see JIRA and its parent JIRA for details
> 
> All the WS stuff, I will do it in the end once the functionality is reviewd.
> 
> 
> If someone is wondering why START is changed to submit: there are tons of places in the code and in the java docs, we actually mean submit when we say START
> 
>   DRIVER_0008("Invalid combination of submission and execution engines"),
> 
>   DRIVER_0009("Job has been disabled. Cannot submit this job."),
> 
>   DRIVER_0010("Link for this job has been disabled. Cannot submit this job."),
> 
>   DRIVER_0011("Connector does not support specified direction. Cannot submit this job."),
> 
>   ;
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c 
>   client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a 
>   client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
>   client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
>   client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
>   common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
>   common/src/main/java/org/apache/sqoop/json/LinksBean.java 5858a18 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
>   common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MLink.java 7a9f538 
>   common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
>   common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
>   common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 811cbf0 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartitioner.java 2411169 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java 3ae64f0 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java f6447c6 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 2aeb07e 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ad380d3 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b996a0b 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 4c2d062 
>   server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5694ea5 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
>   server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
>   server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
>   server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
>   server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
>   server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
>   shell/src/main/java/org/apache/sqoop/shell/AbortCommand.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 
>   shell/src/main/java/org/apache/sqoop/shell/StartCommand.java 7c56980 
>   shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
>   shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 
>   shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
>   shell/src/main/java/org/apache/sqoop/shell/StopCommand.java 50b2e81 
>   shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
>   shell/src/main/java/org/apache/sqoop/shell/SubmitCommand.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SubmitJobFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
>   shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 44d5920 
>   shell/src/main/resources/shell-resource.properties 0e63c50 
>   test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java af31769 
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 64b08fc 
> 
> Diff: https://reviews.apache.org/r/27330/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Veena Basavaraj <vb...@cloudera.com>.

> On Oct. 31, 2014, 6:57 a.m., Jarek Cecho wrote:
> > client/src/main/java/org/apache/sqoop/client/SqoopClient.java, line 85
> > <https://reviews.apache.org/r/27330/diff/7/?file=743043#file743043line85>
> >
> >     I do feel that "SUBMITTED" and "STARTED" are two different cases. Submitted means that we've created the request to start a new job that will eventually transfer data. Started means that the job has started and is running now.
> >     
> >     This call will only create that request and will return before the actuall job will START. I don't see much different on our testing cluster as Submitted job is started pretty much immediately, however on real clusters the delay between submission and start can be significant as the job can be sitting in a scheduler queue for substantial amount of time before it starts (especially on busy clusters).
> 
> Veena Basavaraj wrote:
>     there are subtle differences, submit and start are used in very different ways. 
>     
>     Think about this from the time we issue a command in the client, going by your explanation the command should be submit. I am utterly confused reading this code and how we have just used started and submitted without much thought.
>     
>     I appreciate if we look at this from the client command / status to the execution engine on what we want to call as submit and what should be start.
> 
> Jarek Cecho wrote:
>     I think that the client and REST API have different audiences that have different requirements. Most of the users don't know nor want to know the diffence between Submit and Start. I feel that the fact that those are two independent steps is pretty much an "implementation detail" from their perspective. On the other hand the connector developper or someone who will integrate with the REST API should know the difference and hence it's exposed there. I believe that this is intentional. 
>     
>     The project do have parts that are meant for different audiences and I think that it's reasonable that different audiences are presented with slightly different point of view. Simplification for users seems as good idea whereas we should say accurate for someone who is extending Sqoop.

correct me, I am not confused here.

There is SqoopCLient -> so who is the audience for client. My understanding is that anyone can use it. Not retreicted to developer. Using rest/ client is a matter of preference is what I beleive.

Second, I do not think different audiences need a different picture, it just makes our coding and rationalizing what we do in sqoop code harder. 

Second, what is "most" mean? there are differences in clearly how we use them. submit is like putting it on a queue for it to start. As you clealry artiuclated it, it might start immediately or be delayed. There are error messages when I use a start command,it says I cannot submit the job, what does this indicate?

Lets fix this. It might sound very trivial to you, but going forward it will lead to more confusion if one another person joins this team and wants his /her way.

The rest api uses the SubmissionStatus I suppose directly and the SQoop client uses its own enum. Why?


> On Oct. 31, 2014, 6:57 a.m., Jarek Cecho wrote:
> > core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java, lines 508-520
> > <https://reviews.apache.org/r/27330/diff/7/?file=743062#file743062line508>
> >
> >     This move seems unencessary?
> 
> Veena Basavaraj wrote:
>     why? would you care to ask why I felt it is necessary? 
>     
>     when reading code, having all the links related apis in one places makes it wasy for some one to not miss the apis. Whats wrong with moving, you want another RB for it? say that. 
>     
>     Jus think about how you organize your table, when we write code lets do the same, organize things so that at one shot we know what the apis for links are. I would even want to split this up into logical classes as we have groen the repository apis, see how hard it is to add post gres, wish we had thight through this before.
> 
> Jarek Cecho wrote:
>     Doing unnecessary moves is breaking "git blame" and "git cherrypick". For easier readability we have all the methods and properties named in a way that most generic part was at the begging and most specific one at the end. This way all the overview tools (like method listing in IDEs) is showing similar methods next to each other.

I just gave an example.

we call it updateLink, and not linkUpdate, what is the most generic par?

Annd if your concern is about git blame, I will do another RB first with these changes. I have no issues with it.


- Veena


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/#review59331
-----------------------------------------------------------


On Oct. 30, 2014, 2:08 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27330/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2014, 2:08 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see JIRA and its parent JIRA for details
> 
> All the WS stuff, I will do it in the end once the functionality is reviewd.
> 
> 
> If someone is wondering why START is changed to submit: there are tons of places in the code and in the java docs, we actually mean submit when we say START
> 
>   DRIVER_0008("Invalid combination of submission and execution engines"),
> 
>   DRIVER_0009("Job has been disabled. Cannot submit this job."),
> 
>   DRIVER_0010("Link for this job has been disabled. Cannot submit this job."),
> 
>   DRIVER_0011("Connector does not support specified direction. Cannot submit this job."),
> 
>   ;
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c 
>   client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a 
>   client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
>   client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
>   client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
>   common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
>   common/src/main/java/org/apache/sqoop/json/LinksBean.java 5858a18 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
>   common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MLink.java 7a9f538 
>   common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
>   common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
>   common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 811cbf0 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartitioner.java 2411169 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java 3ae64f0 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java f6447c6 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 2aeb07e 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ad380d3 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b996a0b 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 4c2d062 
>   server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5694ea5 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
>   server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
>   server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
>   server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
>   server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
>   server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
>   shell/src/main/java/org/apache/sqoop/shell/AbortCommand.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 
>   shell/src/main/java/org/apache/sqoop/shell/StartCommand.java 7c56980 
>   shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
>   shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 
>   shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
>   shell/src/main/java/org/apache/sqoop/shell/StopCommand.java 50b2e81 
>   shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
>   shell/src/main/java/org/apache/sqoop/shell/SubmitCommand.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SubmitJobFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
>   shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 44d5920 
>   shell/src/main/resources/shell-resource.properties 0e63c50 
>   test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java af31769 
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 64b08fc 
> 
> Diff: https://reviews.apache.org/r/27330/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Jarek Cecho <ja...@apache.org>.

> On Oct. 31, 2014, 1:57 p.m., Jarek Cecho wrote:
> > client/src/main/java/org/apache/sqoop/client/SqoopClient.java, line 85
> > <https://reviews.apache.org/r/27330/diff/7/?file=743043#file743043line85>
> >
> >     I do feel that "SUBMITTED" and "STARTED" are two different cases. Submitted means that we've created the request to start a new job that will eventually transfer data. Started means that the job has started and is running now.
> >     
> >     This call will only create that request and will return before the actuall job will START. I don't see much different on our testing cluster as Submitted job is started pretty much immediately, however on real clusters the delay between submission and start can be significant as the job can be sitting in a scheduler queue for substantial amount of time before it starts (especially on busy clusters).
> 
> Veena Basavaraj wrote:
>     there are subtle differences, submit and start are used in very different ways. 
>     
>     Think about this from the time we issue a command in the client, going by your explanation the command should be submit. I am utterly confused reading this code and how we have just used started and submitted without much thought.
>     
>     I appreciate if we look at this from the client command / status to the execution engine on what we want to call as submit and what should be start.
> 
> Jarek Cecho wrote:
>     I think that the client and REST API have different audiences that have different requirements. Most of the users don't know nor want to know the diffence between Submit and Start. I feel that the fact that those are two independent steps is pretty much an "implementation detail" from their perspective. On the other hand the connector developper or someone who will integrate with the REST API should know the difference and hence it's exposed there. I believe that this is intentional. 
>     
>     The project do have parts that are meant for different audiences and I think that it's reasonable that different audiences are presented with slightly different point of view. Simplification for users seems as good idea whereas we should say accurate for someone who is extending Sqoop.
> 
> Veena Basavaraj wrote:
>     correct me, I am not confused here.
>     
>     There is SqoopCLient -> so who is the audience for client. My understanding is that anyone can use it. Not retreicted to developer. Using rest/ client is a matter of preference is what I beleive.
>     
>     Second, I do not think different audiences need a different picture, it just makes our coding and rationalizing what we do in sqoop code harder. 
>     
>     Second, what is "most" mean? there are differences in clearly how we use them. submit is like putting it on a queue for it to start. As you clealry artiuclated it, it might start immediately or be delayed. There are error messages when I use a start command,it says I cannot submit the job, what does this indicate?
>     
>     Lets fix this. It might sound very trivial to you, but going forward it will lead to more confusion if one another person joins this team and wants his /her way.
>     
>     The rest api uses the SubmissionStatus I suppose directly and the SQoop client uses its own enum. Why?
> 
> Veena Basavaraj wrote:
>     see JIRA for details, taking this discussion to new a JIRA and new RB.

Thanks, make sense.


> On Oct. 31, 2014, 1:57 p.m., Jarek Cecho wrote:
> > core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java, lines 508-520
> > <https://reviews.apache.org/r/27330/diff/7/?file=743062#file743062line508>
> >
> >     This move seems unencessary?
> 
> Veena Basavaraj wrote:
>     why? would you care to ask why I felt it is necessary? 
>     
>     when reading code, having all the links related apis in one places makes it wasy for some one to not miss the apis. Whats wrong with moving, you want another RB for it? say that. 
>     
>     Jus think about how you organize your table, when we write code lets do the same, organize things so that at one shot we know what the apis for links are. I would even want to split this up into logical classes as we have groen the repository apis, see how hard it is to add post gres, wish we had thight through this before.
> 
> Jarek Cecho wrote:
>     Doing unnecessary moves is breaking "git blame" and "git cherrypick". For easier readability we have all the methods and properties named in a way that most generic part was at the begging and most specific one at the end. This way all the overview tools (like method listing in IDEs) is showing similar methods next to each other.
> 
> Veena Basavaraj wrote:
>     I just gave an example.
>     
>     we call it updateLink, and not linkUpdate, what is the most generic par?
>     
>     Annd if your concern is about git blame, I will do another RB first with these changes. I have no issues with it.
> 
> Veena Basavaraj wrote:
>     Lets try to name methods like 90% of the people in other projects name it, if we have these special rules in sqoop, I;d like to see it documented and then we take a vote on why we need this.
>     
>     Until then I suggest we go back to what every one else names their methods by. This is something we should start right now helping contributors to be not confused on how to name a method and have a coherent story.
>     
>     First thing after this RB is shipped I will start the coding standard wiki and cover these examples

I'm all for specifying public code guidelines, let's create a separate JIRA for that?


- Jarek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/#review59331
-----------------------------------------------------------


On Nov. 3, 2014, 2:47 a.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27330/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2014, 2:47 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see JIRA and its parent JIRA for details
> 
> FYI : it does nto include the start/submit and stop/abort renames.
> 
> new tickets have been added to address these
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c 
>   client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a 
>   client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
>   client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
>   client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
>   common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
>   common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
>   common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
>   core/src/main/java/org/apache/sqoop/driver/DriverError.java ddee282 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java ba56c77 
>   core/src/main/java/org/apache/sqoop/driver/JobRequest.java 2666320 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 976223d 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 1e22759 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 09989e0 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b324f4f 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
>   server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
>   server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
>   server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
>   server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
>   server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
>   shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 
>   shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
>   shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 
>   shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
>   shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
>   test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 06462a3 
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 
> 
> Diff: https://reviews.apache.org/r/27330/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Jarek Cecho <ja...@apache.org>.

> On Oct. 31, 2014, 1:57 p.m., Jarek Cecho wrote:
> >

Thank you Veena for following through my feedback. I think that all my comments have been either addressed or moved to subsequent JIRAs. Thanks!


- Jarek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/#review59331
-----------------------------------------------------------


On Nov. 3, 2014, 2:47 a.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27330/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2014, 2:47 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see JIRA and its parent JIRA for details
> 
> FYI : it does nto include the start/submit and stop/abort renames.
> 
> new tickets have been added to address these
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c 
>   client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a 
>   client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
>   client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
>   client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
>   common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
>   common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
>   common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
>   core/src/main/java/org/apache/sqoop/driver/DriverError.java ddee282 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java ba56c77 
>   core/src/main/java/org/apache/sqoop/driver/JobRequest.java 2666320 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 976223d 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 1e22759 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 09989e0 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b324f4f 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
>   server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
>   server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
>   server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
>   server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
>   server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
>   shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 
>   shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
>   shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 
>   shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
>   shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
>   test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 06462a3 
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 
> 
> Diff: https://reviews.apache.org/r/27330/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Jarek Cecho <ja...@apache.org>.

> On Oct. 31, 2014, 1:57 p.m., Jarek Cecho wrote:
> > client/src/main/java/org/apache/sqoop/client/SqoopClient.java, line 85
> > <https://reviews.apache.org/r/27330/diff/7/?file=743043#file743043line85>
> >
> >     I do feel that "SUBMITTED" and "STARTED" are two different cases. Submitted means that we've created the request to start a new job that will eventually transfer data. Started means that the job has started and is running now.
> >     
> >     This call will only create that request and will return before the actuall job will START. I don't see much different on our testing cluster as Submitted job is started pretty much immediately, however on real clusters the delay between submission and start can be significant as the job can be sitting in a scheduler queue for substantial amount of time before it starts (especially on busy clusters).
> 
> Veena Basavaraj wrote:
>     there are subtle differences, submit and start are used in very different ways. 
>     
>     Think about this from the time we issue a command in the client, going by your explanation the command should be submit. I am utterly confused reading this code and how we have just used started and submitted without much thought.
>     
>     I appreciate if we look at this from the client command / status to the execution engine on what we want to call as submit and what should be start.

I think that the client and REST API have different audiences that have different requirements. Most of the users don't know nor want to know the diffence between Submit and Start. I feel that the fact that those are two independent steps is pretty much an "implementation detail" from their perspective. On the other hand the connector developper or someone who will integrate with the REST API should know the difference and hence it's exposed there. I believe that this is intentional. 

The project do have parts that are meant for different audiences and I think that it's reasonable that different audiences are presented with slightly different point of view. Simplification for users seems as good idea whereas we should say accurate for someone who is extending Sqoop.


> On Oct. 31, 2014, 1:57 p.m., Jarek Cecho wrote:
> > common/src/main/java/org/apache/sqoop/json/JobsBean.java, line 29
> > <https://reviews.apache.org/r/27330/diff/7/?file=743049#file743049line29>
> >
> >     I'm wondering why we are introducing this plural bean? I've noticed that we did something similar for the link recently as well.
> >     
> >     All our beans has been historically written in a way that they supported 1..N objects. Hence they were usable in all cases. This seems unnecessary change to me as now the code using the beans needs to have if-else statements to distinguish what exactly is being send.
> 
> Veena Basavaraj wrote:
>     read the JIRA and the related tickets for 1509, they are two different JSON structures, historically done does not mean it has to stay that unless it is making it obvious.
>     
>     if I sending a JOB, I would see the root to be JOB, if I request a collection it better be JOBS.

I think that we are sending the same JSON structure for given object - e.g. the Job JSON object looks exactly the same in JobBean and JobsBean. The only difference is that JobBean will send the Job JSON structure directly whereas JobsBean will put several Job JSON structures into array. That seems too small difference to me - I feel that it's much easier to simply reuse the JobsBean even when I need to send one Job JSON structure. Your handler s can be simplified as you don't have to know whether server will return only one or multiple, ...


> On Oct. 31, 2014, 1:57 p.m., Jarek Cecho wrote:
> > core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java, lines 508-520
> > <https://reviews.apache.org/r/27330/diff/7/?file=743062#file743062line508>
> >
> >     This move seems unencessary?
> 
> Veena Basavaraj wrote:
>     why? would you care to ask why I felt it is necessary? 
>     
>     when reading code, having all the links related apis in one places makes it wasy for some one to not miss the apis. Whats wrong with moving, you want another RB for it? say that. 
>     
>     Jus think about how you organize your table, when we write code lets do the same, organize things so that at one shot we know what the apis for links are. I would even want to split this up into logical classes as we have groen the repository apis, see how hard it is to add post gres, wish we had thight through this before.

Doing unnecessary moves is breaking "git blame" and "git cherrypick". For easier readability we have all the methods and properties named in a way that most generic part was at the begging and most specific one at the end. This way all the overview tools (like method listing in IDEs) is showing similar methods next to each other.


> On Oct. 31, 2014, 1:57 p.m., Jarek Cecho wrote:
> > core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java, line 392
> > <https://reviews.apache.org/r/27330/diff/7/?file=743063#file743063line392>
> >
> >     Just FYI: Entire code base is written in a way that all methods, variables, properties are from most generic to most specific. So that when you sort all the methods alphabetically (which majority of the tools does), you can see all methods for let say "submission" next to each other. This entire review is changing that on majority of the places to "common english". 
> >     
> >     I'm wondering if there is a technical reason for that?
> 
> Veena Basavaraj wrote:
>     it is not, why do we call it findSbmissions and not Submissions find, why to we call it updateLink than linkUpdate? entire is a strong word
>     
>     How does find become the prefix and not Unfinished.

On this particular class, we have "action" first and then the object structure from most generic to most concrete. My note was applicable for entire review request, so I've probably picked up wrong line to make the point on, sorry for the confusion.


- Jarek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/#review59331
-----------------------------------------------------------


On Oct. 30, 2014, 9:08 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27330/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2014, 9:08 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see JIRA and its parent JIRA for details
> 
> All the WS stuff, I will do it in the end once the functionality is reviewd.
> 
> 
> If someone is wondering why START is changed to submit: there are tons of places in the code and in the java docs, we actually mean submit when we say START
> 
>   DRIVER_0008("Invalid combination of submission and execution engines"),
> 
>   DRIVER_0009("Job has been disabled. Cannot submit this job."),
> 
>   DRIVER_0010("Link for this job has been disabled. Cannot submit this job."),
> 
>   DRIVER_0011("Connector does not support specified direction. Cannot submit this job."),
> 
>   ;
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c 
>   client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a 
>   client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
>   client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
>   client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
>   common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
>   common/src/main/java/org/apache/sqoop/json/LinksBean.java 5858a18 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
>   common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MLink.java 7a9f538 
>   common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
>   common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
>   common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 811cbf0 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartitioner.java 2411169 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java 3ae64f0 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java f6447c6 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 2aeb07e 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ad380d3 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b996a0b 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 4c2d062 
>   server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5694ea5 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
>   server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
>   server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
>   server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
>   server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
>   server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
>   shell/src/main/java/org/apache/sqoop/shell/AbortCommand.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 
>   shell/src/main/java/org/apache/sqoop/shell/StartCommand.java 7c56980 
>   shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
>   shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 
>   shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
>   shell/src/main/java/org/apache/sqoop/shell/StopCommand.java 50b2e81 
>   shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
>   shell/src/main/java/org/apache/sqoop/shell/SubmitCommand.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SubmitJobFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
>   shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 44d5920 
>   shell/src/main/resources/shell-resource.properties 0e63c50 
>   test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java af31769 
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 64b08fc 
> 
> Diff: https://reviews.apache.org/r/27330/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Veena Basavaraj <vb...@cloudera.com>.

> On Oct. 31, 2014, 6:57 a.m., Jarek Cecho wrote:
> > core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java, lines 508-520
> > <https://reviews.apache.org/r/27330/diff/7/?file=743062#file743062line508>
> >
> >     This move seems unencessary?
> 
> Veena Basavaraj wrote:
>     why? would you care to ask why I felt it is necessary? 
>     
>     when reading code, having all the links related apis in one places makes it wasy for some one to not miss the apis. Whats wrong with moving, you want another RB for it? say that. 
>     
>     Jus think about how you organize your table, when we write code lets do the same, organize things so that at one shot we know what the apis for links are. I would even want to split this up into logical classes as we have groen the repository apis, see how hard it is to add post gres, wish we had thight through this before.
> 
> Jarek Cecho wrote:
>     Doing unnecessary moves is breaking "git blame" and "git cherrypick". For easier readability we have all the methods and properties named in a way that most generic part was at the begging and most specific one at the end. This way all the overview tools (like method listing in IDEs) is showing similar methods next to each other.
> 
> Veena Basavaraj wrote:
>     I just gave an example.
>     
>     we call it updateLink, and not linkUpdate, what is the most generic par?
>     
>     Annd if your concern is about git blame, I will do another RB first with these changes. I have no issues with it.

Lets try to name methods like 90% of the people in other projects name it, if we have these special rules in sqoop, I;d like to see it documented and then we take a vote on why we need this.

Until then I suggest we go back to what every one else names their methods by. This is something we should start right now helping contributors to be not confused on how to name a method and have a coherent story.

First thing after this RB is shipped I will start the coding standard wiki and cover these examples


- Veena


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/#review59331
-----------------------------------------------------------


On Oct. 30, 2014, 2:08 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27330/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2014, 2:08 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see JIRA and its parent JIRA for details
> 
> All the WS stuff, I will do it in the end once the functionality is reviewd.
> 
> 
> If someone is wondering why START is changed to submit: there are tons of places in the code and in the java docs, we actually mean submit when we say START
> 
>   DRIVER_0008("Invalid combination of submission and execution engines"),
> 
>   DRIVER_0009("Job has been disabled. Cannot submit this job."),
> 
>   DRIVER_0010("Link for this job has been disabled. Cannot submit this job."),
> 
>   DRIVER_0011("Connector does not support specified direction. Cannot submit this job."),
> 
>   ;
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c 
>   client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a 
>   client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
>   client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
>   client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
>   common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
>   common/src/main/java/org/apache/sqoop/json/LinksBean.java 5858a18 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
>   common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MLink.java 7a9f538 
>   common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
>   common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
>   common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 811cbf0 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartitioner.java 2411169 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java 3ae64f0 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java f6447c6 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 2aeb07e 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ad380d3 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b996a0b 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 4c2d062 
>   server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5694ea5 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
>   server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
>   server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
>   server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
>   server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
>   server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
>   shell/src/main/java/org/apache/sqoop/shell/AbortCommand.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 
>   shell/src/main/java/org/apache/sqoop/shell/StartCommand.java 7c56980 
>   shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
>   shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 
>   shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
>   shell/src/main/java/org/apache/sqoop/shell/StopCommand.java 50b2e81 
>   shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
>   shell/src/main/java/org/apache/sqoop/shell/SubmitCommand.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SubmitJobFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
>   shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 44d5920 
>   shell/src/main/resources/shell-resource.properties 0e63c50 
>   test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java af31769 
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 64b08fc 
> 
> Diff: https://reviews.apache.org/r/27330/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/#review59331
-----------------------------------------------------------



client/src/main/java/org/apache/sqoop/client/SqoopClient.java
<https://reviews.apache.org/r/27330/#comment100597>

    I do feel that "SUBMITTED" and "STARTED" are two different cases. Submitted means that we've created the request to start a new job that will eventually transfer data. Started means that the job has started and is running now.
    
    This call will only create that request and will return before the actuall job will START. I don't see much different on our testing cluster as Submitted job is started pretty much immediately, however on real clusters the delay between submission and start can be significant as the job can be sitting in a scheduler queue for substantial amount of time before it starts (especially on busy clusters).



common/src/main/java/org/apache/sqoop/json/JobsBean.java
<https://reviews.apache.org/r/27330/#comment100598>

    I'm wondering why we are introducing this plural bean? I've noticed that we did something similar for the link recently as well.
    
    All our beans has been historically written in a way that they supported 1..N objects. Hence they were usable in all cases. This seems unnecessary change to me as now the code using the beans needs to have if-else statements to distinguish what exactly is being send.



core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java
<https://reviews.apache.org/r/27330/#comment100600>

    This move seems unencessary?



core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java
<https://reviews.apache.org/r/27330/#comment100599>

    This move seems unencessary?



core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java
<https://reviews.apache.org/r/27330/#comment100601>

    Repository can't submit job as that is a job of execution engine. Repository is just storing the submission metadata. Hence I would prefer to keep the original name as this one seems misleading to me.



core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java
<https://reviews.apache.org/r/27330/#comment100602>

    Just FYI: Entire code base is written in a way that all methods, variables, properties are from most generic to most specific. So that when you sort all the methods alphabetically (which majority of the tools does), you can see all methods for let say "submission" next to each other. This entire review is changing that on majority of the places to "common english". 
    
    I'm wondering if there is a technical reason for that?



core/src/main/java/org/apache/sqoop/repository/Repository.java
<https://reviews.apache.org/r/27330/#comment100603>

    Seems as another unnecessary move?



core/src/main/java/org/apache/sqoop/repository/Repository.java
<https://reviews.apache.org/r/27330/#comment100605>

    Unnecessary move?


- Jarek Cecho


On Oct. 30, 2014, 9:08 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27330/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2014, 9:08 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see JIRA and its parent JIRA for details
> 
> All the WS stuff, I will do it in the end once the functionality is reviewd.
> 
> 
> If someone is wondering why START is changed to submit: there are tons of places in the code and in the java docs, we actually mean submit when we say START
> 
>   DRIVER_0008("Invalid combination of submission and execution engines"),
> 
>   DRIVER_0009("Job has been disabled. Cannot submit this job."),
> 
>   DRIVER_0010("Link for this job has been disabled. Cannot submit this job."),
> 
>   DRIVER_0011("Connector does not support specified direction. Cannot submit this job."),
> 
>   ;
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c 
>   client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a 
>   client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
>   client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
>   client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
>   common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
>   common/src/main/java/org/apache/sqoop/json/LinksBean.java 5858a18 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
>   common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MLink.java 7a9f538 
>   common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
>   common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
>   common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 811cbf0 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartitioner.java 2411169 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java 3ae64f0 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java f6447c6 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 2aeb07e 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ad380d3 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b996a0b 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 4c2d062 
>   server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5694ea5 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
>   server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
>   server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
>   server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
>   server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
>   server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
>   shell/src/main/java/org/apache/sqoop/shell/AbortCommand.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 
>   shell/src/main/java/org/apache/sqoop/shell/StartCommand.java 7c56980 
>   shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
>   shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 
>   shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
>   shell/src/main/java/org/apache/sqoop/shell/StopCommand.java 50b2e81 
>   shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
>   shell/src/main/java/org/apache/sqoop/shell/SubmitCommand.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/SubmitJobFunction.java PRE-CREATION 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
>   shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 44d5920 
>   shell/src/main/resources/shell-resource.properties 0e63c50 
>   test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java af31769 
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 64b08fc 
> 
> Diff: https://reviews.apache.org/r/27330/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/
-----------------------------------------------------------

(Updated Oct. 30, 2014, 2:08 p.m.)


Review request for Sqoop.


Repository: sqoop-sqoop2


Description
-------

see JIRA and its parent JIRA for details

All the WS stuff, I will do it in the end once the functionality is reviewd.


If someone is wondering why START is changed to submit: there are tons of places in the code and in the java docs, we actually mean submit when we say START

  DRIVER_0008("Invalid combination of submission and execution engines"),

  DRIVER_0009("Job has been disabled. Cannot submit this job."),

  DRIVER_0010("Link for this job has been disabled. Cannot submit this job."),

  DRIVER_0011("Connector does not support specified direction. Cannot submit this job."),

  ;


Diffs
-----

  client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c 
  client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a 
  client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
  client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
  client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
  common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
  common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
  common/src/main/java/org/apache/sqoop/json/LinksBean.java 5858a18 
  common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
  common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/model/MLink.java 7a9f538 
  common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
  common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
  common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 811cbf0 
  common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartitioner.java 2411169 
  connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java 3ae64f0 
  core/src/main/java/org/apache/sqoop/driver/JobManager.java f6447c6 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 2aeb07e 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ad380d3 
  core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b996a0b 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 4c2d062 
  server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5694ea5 
  server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
  server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
  server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
  server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
  server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
  server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
  server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a 
  server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
  server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
  server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
  shell/src/main/java/org/apache/sqoop/shell/AbortCommand.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 
  shell/src/main/java/org/apache/sqoop/shell/StartCommand.java 7c56980 
  shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
  shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 
  shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
  shell/src/main/java/org/apache/sqoop/shell/StopCommand.java 50b2e81 
  shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
  shell/src/main/java/org/apache/sqoop/shell/SubmitCommand.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/SubmitJobFunction.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
  shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
  shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 44d5920 
  shell/src/main/resources/shell-resource.properties 0e63c50 
  test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java af31769 
  test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443 
  tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 
  tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 64b08fc 

Diff: https://reviews.apache.org/r/27330/diff/


Testing
-------

yes


Thanks,

Veena Basavaraj

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/
-----------------------------------------------------------

(Updated Oct. 30, 2014, 9:49 a.m.)


Review request for Sqoop.


Changes
-------

Also did a rebase.


Repository: sqoop-sqoop2


Description
-------

see JIRA and its parent JIRA for details

All the WS stuff, I will do it in the end once the functionality is reviewd.


If someone is wondering why START is changed to submit: there are tons of places in the code and in the java docs, we actually mean submit when we say START

  DRIVER_0008("Invalid combination of submission and execution engines"),

  DRIVER_0009("Job has been disabled. Cannot submit this job."),

  DRIVER_0010("Link for this job has been disabled. Cannot submit this job."),

  DRIVER_0011("Connector does not support specified direction. Cannot submit this job."),

  ;


Diffs (updated)
-----

  client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c 
  client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a 
  client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
  client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
  client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
  common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
  common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
  common/src/main/java/org/apache/sqoop/json/LinksBean.java 5858a18 
  common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
  common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/model/MLink.java 7a9f538 
  common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
  common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
  common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 811cbf0 
  common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartitioner.java 2411169 
  connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java 3ae64f0 
  core/src/main/java/org/apache/sqoop/driver/JobManager.java f6447c6 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 2aeb07e 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ad380d3 
  core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b996a0b 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 4c2d062 
  server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5694ea5 
  server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
  server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
  server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
  server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
  server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
  server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
  server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a 
  server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
  server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
  server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
  shell/src/main/java/org/apache/sqoop/shell/AbortCommand.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 
  shell/src/main/java/org/apache/sqoop/shell/StartCommand.java 7c56980 
  shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
  shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 
  shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
  shell/src/main/java/org/apache/sqoop/shell/StopCommand.java 50b2e81 
  shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
  shell/src/main/java/org/apache/sqoop/shell/SubmitCommand.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/SubmitJobFunction.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
  shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
  shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 44d5920 
  shell/src/main/resources/shell-resource.properties 0e63c50 
  test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java af31769 
  test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443 
  tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 
  tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 64b08fc 

Diff: https://reviews.apache.org/r/27330/diff/


Testing
-------

yes


Thanks,

Veena Basavaraj

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/
-----------------------------------------------------------

(Updated Oct. 30, 2014, 8:58 a.m.)


Review request for Sqoop.


Repository: sqoop-sqoop2


Description
-------

see JIRA and its parent JIRA for details

All the WS stuff, I will do it in the end once the functionality is reviewd.


If someone is wondering why START is changed to submit: there are tons of places in the code and in the java docs, we actually mean submit when we say START

  DRIVER_0008("Invalid combination of submission and execution engines"),

  DRIVER_0009("Job has been disabled. Cannot submit this job."),

  DRIVER_0010("Link for this job has been disabled. Cannot submit this job."),

  DRIVER_0011("Connector does not support specified direction. Cannot submit this job."),

  ;


Diffs (updated)
-----

  client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c 
  client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a 
  client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
  client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
  client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
  common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
  common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
  common/src/main/java/org/apache/sqoop/json/LinksBean.java 5858a18 
  common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
  common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/model/MLink.java 7a9f538 
  common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
  common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
  common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 811cbf0 
  common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartitioner.java 2411169 
  connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java 3ae64f0 
  core/src/main/java/org/apache/sqoop/driver/JobManager.java f6447c6 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 2aeb07e 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ad380d3 
  core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b996a0b 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 4c2d062 
  server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5694ea5 
  server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
  server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
  server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
  server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
  server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
  server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
  server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a 
  server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
  server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
  server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
  shell/src/main/java/org/apache/sqoop/shell/AbortCommand.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 
  shell/src/main/java/org/apache/sqoop/shell/StartCommand.java 7c56980 
  shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
  shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 
  shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
  shell/src/main/java/org/apache/sqoop/shell/StopCommand.java 50b2e81 
  shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
  shell/src/main/java/org/apache/sqoop/shell/SubmitCommand.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/SubmitJobFunction.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
  shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
  shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 44d5920 
  shell/src/main/resources/shell-resource.properties 0e63c50 
  test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java af31769 
  test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443 
  tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 
  tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 64b08fc 

Diff: https://reviews.apache.org/r/27330/diff/


Testing
-------

yes


Thanks,

Veena Basavaraj

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/
-----------------------------------------------------------

(Updated Oct. 30, 2014, 8:57 a.m.)


Review request for Sqoop.


Repository: sqoop-sqoop2


Description (updated)
-------

see JIRA and its parent JIRA for details

All the WS stuff, I will do it in the end once the functionality is reviewd.


If someone is wondering why START is changed to submit: there are tons of places in the code and in the java docs, we actually mean submit when we say START

  DRIVER_0008("Invalid combination of submission and execution engines"),

  DRIVER_0009("Job has been disabled. Cannot submit this job."),

  DRIVER_0010("Link for this job has been disabled. Cannot submit this job."),

  DRIVER_0011("Connector does not support specified direction. Cannot submit this job."),

  ;


Diffs
-----

  client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c 
  client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a 
  client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
  client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
  client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
  common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
  common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
  common/src/main/java/org/apache/sqoop/json/LinksBean.java 5858a18 
  common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
  common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/model/MLink.java 7a9f538 
  common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
  common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
  common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 811cbf0 
  common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartitioner.java 2411169 
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfig.java 12ceb21 
  connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java 3ae64f0 
  core/src/main/java/org/apache/sqoop/driver/JobManager.java f6447c6 
  core/src/main/java/org/apache/sqoop/driver/SubmissionEngine.java 3a32e9f 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 2aeb07e 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ad380d3 
  core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b996a0b 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 4c2d062 
  server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5694ea5 
  server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
  server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
  server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
  server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
  server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
  server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
  server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a 
  server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
  server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
  server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
  shell/src/main/java/org/apache/sqoop/shell/AbortCommand.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/AbortJobFunction.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 
  shell/src/main/java/org/apache/sqoop/shell/StartCommand.java 7c56980 
  shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
  shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 
  shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
  shell/src/main/java/org/apache/sqoop/shell/StopCommand.java 50b2e81 
  shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
  shell/src/main/java/org/apache/sqoop/shell/SubmitCommand.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/SubmitJobFunction.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
  shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
  shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 44d5920 
  submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 631ceca 
  test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java af31769 
  test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443 
  tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 
  tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 64b08fc 

Diff: https://reviews.apache.org/r/27330/diff/


Testing
-------

yes


Thanks,

Veena Basavaraj

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/
-----------------------------------------------------------

(Updated Oct. 29, 2014, 10:24 p.m.)


Review request for Sqoop.


Changes
-------

addressed 2 comments related to fromconfig change and string concate


Repository: sqoop-sqoop2


Description
-------

see JIRA and its parent JIRA for details

All the WS stuff, I will do it in the end once the functionality is reviewd.


Diffs (updated)
-----

  client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c 
  client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a 
  client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
  client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
  client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
  common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
  common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
  common/src/main/java/org/apache/sqoop/json/LinksBean.java 5858a18 
  common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
  common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/model/MLink.java 7a9f538 
  common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
  common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
  common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 811cbf0 
  common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartitioner.java 2411169 
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfig.java 12ceb21 
  connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java 3ae64f0 
  core/src/main/java/org/apache/sqoop/driver/JobManager.java f6447c6 
  core/src/main/java/org/apache/sqoop/driver/SubmissionEngine.java 3a32e9f 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 2aeb07e 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ad380d3 
  core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b996a0b 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 4c2d062 
  server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5694ea5 
  server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
  server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
  server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
  server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
  server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
  server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
  server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a 
  server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
  server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
  server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
  shell/src/main/java/org/apache/sqoop/shell/AbortCommand.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/AbortJobFunction.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 
  shell/src/main/java/org/apache/sqoop/shell/StartCommand.java 7c56980 
  shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
  shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 
  shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
  shell/src/main/java/org/apache/sqoop/shell/StopCommand.java 50b2e81 
  shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
  shell/src/main/java/org/apache/sqoop/shell/SubmitCommand.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/SubmitJobFunction.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
  shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
  shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 44d5920 
  submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 631ceca 
  test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java af31769 
  test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443 
  tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 
  tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 64b08fc 

Diff: https://reviews.apache.org/r/27330/diff/


Testing
-------

yes


Thanks,

Veena Basavaraj

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/
-----------------------------------------------------------

(Updated Oct. 29, 2014, 5:04 p.m.)


Review request for Sqoop.


Repository: sqoop-sqoop2


Description
-------

see JIRA and its parent JIRA for details

All the WS stuff, I will do it in the end once the functionality is reviewd.


Diffs (updated)
-----

  client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c 
  client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a 
  client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
  client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
  client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
  common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
  common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
  common/src/main/java/org/apache/sqoop/json/LinksBean.java 5858a18 
  common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
  common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/model/MLink.java 7a9f538 
  common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
  common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
  common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 811cbf0 
  common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartitioner.java 2411169 
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfig.java 12ceb21 
  connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java 3ae64f0 
  core/src/main/java/org/apache/sqoop/driver/JobManager.java f6447c6 
  core/src/main/java/org/apache/sqoop/driver/SubmissionEngine.java 3a32e9f 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 2aeb07e 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ad380d3 
  core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b996a0b 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 4c2d062 
  server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5694ea5 
  server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
  server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
  server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
  server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
  server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
  server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
  server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a 
  server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
  server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
  server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
  shell/src/main/java/org/apache/sqoop/shell/AbortCommand.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/AbortJobFunction.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 
  shell/src/main/java/org/apache/sqoop/shell/StartCommand.java 7c56980 
  shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
  shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 
  shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
  shell/src/main/java/org/apache/sqoop/shell/StopCommand.java 50b2e81 
  shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
  shell/src/main/java/org/apache/sqoop/shell/SubmitCommand.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/SubmitJobFunction.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
  shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
  shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 44d5920 
  submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 631ceca 
  test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java af31769 
  test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443 
  tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 
  tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 64b08fc 

Diff: https://reviews.apache.org/r/27330/diff/


Testing
-------

yes


Thanks,

Veena Basavaraj

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/
-----------------------------------------------------------

(Updated Oct. 29, 2014, 1:30 p.m.)


Review request for Sqoop.


Changes
-------

address this one comment and not rename conenctorID to Id


Repository: sqoop-sqoop2


Description
-------

see JIRA and its parent JIRA for details

All the WS stuff, I will do it in the end once the functionality is reviewd.


Diffs (updated)
-----

  client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c 
  client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a 
  client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
  client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
  client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
  common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
  common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
  common/src/main/java/org/apache/sqoop/json/LinksBean.java 5858a18 
  common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
  common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/model/MLink.java 7a9f538 
  common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
  common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
  common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 811cbf0 
  common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
  core/src/main/java/org/apache/sqoop/driver/JobManager.java f6447c6 
  core/src/main/java/org/apache/sqoop/driver/SubmissionEngine.java 3a32e9f 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 2aeb07e 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ad380d3 
  core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 514b5ac 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 4c2d062 
  server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5694ea5 
  server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
  server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
  server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
  server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
  server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
  server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
  server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a 
  server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
  server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
  server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
  shell/src/main/java/org/apache/sqoop/shell/AbortCommand.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/AbortJobFunction.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 
  shell/src/main/java/org/apache/sqoop/shell/StartCommand.java 7c56980 
  shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
  shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 
  shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
  shell/src/main/java/org/apache/sqoop/shell/StopCommand.java 50b2e81 
  shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
  shell/src/main/java/org/apache/sqoop/shell/SubmitCommand.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/SubmitJobFunction.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
  shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
  shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 44d5920 
  submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 631ceca 
  test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java af31769 
  test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443 
  tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 
  tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 64b08fc 

Diff: https://reviews.apache.org/r/27330/diff/


Testing
-------

yes


Thanks,

Veena Basavaraj

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/
-----------------------------------------------------------

(Updated Oct. 29, 2014, 1:12 p.m.)


Review request for Sqoop.


Changes
-------

Fixed WS
Fixed the client code so the integration tests now pass
addressed comments from Abe


Repository: sqoop-sqoop2


Description
-------

see JIRA and its parent JIRA for details

All the WS stuff, I will do it in the end once the functionality is reviewd.


Diffs (updated)
-----

  client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c 
  client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a 
  client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
  client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
  client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
  common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
  common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
  common/src/main/java/org/apache/sqoop/json/LinksBean.java 5858a18 
  common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
  common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/model/MLink.java 7a9f538 
  common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
  common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
  common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 811cbf0 
  common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
  core/src/main/java/org/apache/sqoop/driver/JobManager.java f6447c6 
  core/src/main/java/org/apache/sqoop/driver/SubmissionEngine.java 3a32e9f 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 2aeb07e 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ad380d3 
  core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 514b5ac 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 4c2d062 
  server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5694ea5 
  server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
  server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
  server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
  server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
  server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
  server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
  server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a 
  server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
  server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
  server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
  shell/src/main/java/org/apache/sqoop/shell/AbortCommand.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/AbortJobFunction.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 
  shell/src/main/java/org/apache/sqoop/shell/StartCommand.java 7c56980 
  shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
  shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 
  shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
  shell/src/main/java/org/apache/sqoop/shell/StopCommand.java 50b2e81 
  shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
  shell/src/main/java/org/apache/sqoop/shell/SubmitCommand.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/SubmitJobFunction.java PRE-CREATION 
  shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
  shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
  shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 44d5920 
  submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 631ceca 
  test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java af31769 
  test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443 
  tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 
  tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 64b08fc 

Diff: https://reviews.apache.org/r/27330/diff/


Testing
-------

yes


Thanks,

Veena Basavaraj

Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes

Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/
-----------------------------------------------------------

(Updated Oct. 29, 2014, 9:52 a.m.)


Review request for Sqoop.


Repository: sqoop-sqoop2


Description (updated)
-------

see JIRA and its parent JIRA for details

All the WS stuff, I will do it in the end once the functionality is reviewd.


Diffs
-----

  client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 
  client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 
  client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 
  common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
  common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
  common/src/main/java/org/apache/sqoop/json/LinksBean.java 5858a18 
  common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
  common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/model/MLink.java 7a9f538 
  common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
  common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
  common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 811cbf0 
  common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
  core/src/main/java/org/apache/sqoop/driver/JobManager.java f6447c6 
  core/src/main/java/org/apache/sqoop/driver/SubmissionEngine.java 3a32e9f 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 2aeb07e 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ad380d3 
  core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 514b5ac 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 4c2d062 
  server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
  server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
  server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c 
  server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
  server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
  server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
  server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a 
  server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
  server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION 
  server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
  shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
  shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
  submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 631ceca 
  tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 
  tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 64b08fc 

Diff: https://reviews.apache.org/r/27330/diff/


Testing
-------

yes


Thanks,

Veena Basavaraj