You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Joe Orton <jo...@manyfish.co.uk> on 2004/07/16 22:22:13 UTC
Re: svn commit: r10343 - branches/1.0.x
On Fri, Jul 16, 2004 at 01:16:14PM -0500, Ben Sussman wrote:
> --- branches/1.0.x/STATUS (original)
> +++ branches/1.0.x/STATUS Fri Jul 16 13:16:13 2004
> @@ -63,3 +63,11 @@
> Votes:
> +1: striker, sussman (though I think he'll change his mind)
> -1: breser (violates compatbility rules)
> +
> + * r10072
> + Have 'svnadmin hotcopy' pass APR_LARGEFILE flag to apr_file_open().
> + Justification: allows this command to copy largefiles, regardless
> + of whether largefile support is compiled into APR.
> + Notes: many users have hit this problem (issue #1819).
I don't think this makes sense. r10072 is a tweak to the new hotcopy
implementation on the trunk, which doesn't use apr_file_copy().
The 1.0.x svnadmin hotcopy uses apr_file_copy() still as far as I can
tell, so it gets large file support as-and-when a 1.0.x release ships
with a more recent snapshot of APR 0.9.x.
joe
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r10343 - branches/1.0.x
Posted by Ben Collins-Sussman <su...@collab.net>.
On Fri, 2004-07-16 at 17:22, Joe Orton wrote:
> On Fri, Jul 16, 2004 at 01:16:14PM -0500, Ben Sussman wrote:
> > --- branches/1.0.x/STATUS (original)
> > +++ branches/1.0.x/STATUS Fri Jul 16 13:16:13 2004
> > @@ -63,3 +63,11 @@
> > Votes:
> > +1: striker, sussman (though I think he'll change his mind)
> > -1: breser (violates compatbility rules)
> > +
> > + * r10072
> > + Have 'svnadmin hotcopy' pass APR_LARGEFILE flag to apr_file_open().
> > + Justification: allows this command to copy largefiles, regardless
> > + of whether largefile support is compiled into APR.
> > + Notes: many users have hit this problem (issue #1819).
>
> I don't think this makes sense. r10072 is a tweak to the new hotcopy
> implementation on the trunk, which doesn't use apr_file_copy().
>
> The 1.0.x svnadmin hotcopy uses apr_file_copy() still as far as I can
> tell, so it gets large file support as-and-when a 1.0.x release ships
> with a more recent snapshot of APR 0.9.x.
Oh cripes, you're right. In order to backport this, we'd have to
backport *all* the changes I made for issue 1819 and 1818. Maybe it's
not worth it. :-/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org