[jira] [Closed] (DAFFODIL-2586) Schema compilation hangs if incorrectly closed attribute

["Dave Thompson (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DAFFODIL-2586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dave Thompson closed DAFFODIL-2586.
-----------------------------------

Verified the specified commit (commit 341479c6aad2c59740c0b3819f21be6c95551b02) is included in the latest pull from the daffodil repository.

Verified, via review, changes identified in the commit comment were implemented. 

Verified the affected daffodil subproject sbt test suites executed successfully, including the added test.

Rolled the commit back to a pre-fix commit, copied the associated sbt test files (UserSubmittedTests.tdml, invalid_xml.dfdl.xsd and TestUserSubmittedTests.scala) from the fix commit. Verified that the added test causes an endless loop.

> Schema compilation hangs if incorrectly closed attribute
> --------------------------------------------------------
>
>                 Key: DAFFODIL-2586
>                 URL: https://issues.apache.org/jira/browse/DAFFODIL-2586
>             Project: Daffodil
>          Issue Type: Bug
>          Components: Front End
>    Affects Versions: 3.2.0
>            Reporter: Steve Lawrence
>            Assignee: Mike McGann
>            Priority: Major
>              Labels: beginner
>             Fix For: 3.5.0
>
>
> Notice below the missing quote with the last attribute of the dfdl:format element. When I parse a DFDL schema containing this dfdl:format element, Daffodil hangs forever.
> {code:xml}
>     <xs:annotation>
>         <xs:appinfo source="http://www.ogf.org/dfdl/">
>             <dfdl:format
>                 textBidi="no"
>                 separatorSuppressionPolicy="trailingEmpty"
>                 floating="no"
>                 encodingErrorPolicy="replace"
>                 outputNewLine="%CR;%LF;"
>                 leadingSkip="0" 
>                 trailingSkip="0"
>                 alignment="1" 
>                 alignmentUnits="bytes"
>                 textPadKind="none"
>                 textTrimKind="none" 
>                 truncateSpecifiedLengthString="no"
>                 escapeSchemeRef=""
>                 representation="binary"
>                 encoding="ASCII"
>                 separator = ""
>                 initiator = ""
>                 terminator = ""
>                 ignoreCase = "yes"
>                 sequenceKind="ordered"
>                 initiatedContent="no"
>                 fillByte="%SP;"
>                 lengthKind="implicit"
>                 byteOrder="littleEndian
>             />
>         </xs:appinfo>
>     </xs:annotation>
> {code}
> Debugging a little bit, it looks like reportSyntaxError is getting called repeatedly with the same error message:
> {quote}
> '<' not allowed in attrib value
> {quote}
> Might be a bug in scala-xml, or might be a bug in our implementation of DaffodilConstructingLoader.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)