You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/05/07 16:29:51 UTC
[GitHub] [shardingsphere] terrymanu opened a new pull request #5459: Remove MasterSlaveDataSourceFactory and related API
terrymanu opened a new pull request #5459:
URL: https://github.com/apache/shardingsphere/pull/5459
For #3691.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io commented on pull request #5459: Remove MasterSlaveDataSourceFactory and related API
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #5459:
URL: https://github.com/apache/shardingsphere/pull/5459#issuecomment-625372568
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5459?src=pr&el=h1) Report
> Merging [#5459](https://codecov.io/gh/apache/shardingsphere/pull/5459?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/630ddceba2fec5096b47bd85ff451d8bf9bb54ec&el=desc) will **increase** coverage by `0.30%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/5459?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5459 +/- ##
============================================
+ Coverage 53.87% 54.18% +0.30%
+ Complexity 422 421 -1
============================================
Files 1170 1166 -4
Lines 20944 20916 -28
Branches 3775 3775
============================================
+ Hits 11284 11333 +49
+ Misses 8949 8866 -83
- Partials 711 717 +6
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5459?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...here/shardingjdbc/api/ShadowDataSourceFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/5459/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9hcGkvU2hhZG93RGF0YVNvdXJjZUZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...gproxy/config/yaml/YamlProxyRuleConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/5459/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZ3Byb3h5L2NvbmZpZy95YW1sL1lhbWxQcm94eVJ1bGVDb25maWd1cmF0aW9uLmphdmE=) | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...arameter/builder/impl/GroupedParameterBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/5459/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1yZXdyaXRlL3NoYXJkaW5nc3BoZXJlLXJld3JpdGUtZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS91bmRlcmx5aW5nL3Jld3JpdGUvcGFyYW1ldGVyL2J1aWxkZXIvaW1wbC9Hcm91cGVkUGFyYW1ldGVyQnVpbGRlci5qYXZh) | `80.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...rdingjdbc/spring/boot/SpringBootConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/5459/diff?src=pr&el=tree#diff-c2hhcmRpbmctc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nLWJvb3Qtc3RhcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdqZGJjL3NwcmluZy9ib290L1NwcmluZ0Jvb3RDb25maWd1cmF0aW9uLmphdmE=) | `84.84% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...YamlOrchestrationMasterSlaveRuleConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/5459/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLW9yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9vcmNoZXN0cmF0aW9uL2ludGVybmFsL3lhbWwvWWFtbE9yY2hlc3RyYXRpb25NYXN0ZXJTbGF2ZVJ1bGVDb25maWd1cmF0aW9uLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...l/summary/RequestLatencySummaryMetricsTracker.java](https://codecov.io/gh/apache/shardingsphere/pull/5459/diff?src=pr&el=tree#diff-c2hhcmRpbmctbWV0cmljcy9zaGFyZGluZy1tZXRyaWNzLXByb21ldGhldXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21ldHJpY3MvcHJvbWV0aGV1cy9pbXBsL3N1bW1hcnkvUmVxdWVzdExhdGVuY3lTdW1tYXJ5TWV0cmljc1RyYWNrZXIuamF2YQ==) | `100.00% <0.00%> (+16.66%)` | `1.00% <0.00%> (ø%)` | |
| [...mpl/counter/SQLStatementCounterMetricsTracker.java](https://codecov.io/gh/apache/shardingsphere/pull/5459/diff?src=pr&el=tree#diff-c2hhcmRpbmctbWV0cmljcy9zaGFyZGluZy1tZXRyaWNzLXByb21ldGhldXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21ldHJpY3MvcHJvbWV0aGV1cy9pbXBsL2NvdW50ZXIvU1FMU3RhdGVtZW50Q291bnRlck1ldHJpY3NUcmFja2VyLmphdmE=) | `100.00% <0.00%> (+22.22%)` | `1.00% <0.00%> (ø%)` | |
| [...mpl/counter/RequestTotalCounterMetricsTracker.java](https://codecov.io/gh/apache/shardingsphere/pull/5459/diff?src=pr&el=tree#diff-c2hhcmRpbmctbWV0cmljcy9zaGFyZGluZy1tZXRyaWNzLXByb21ldGhldXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21ldHJpY3MvcHJvbWV0aGV1cy9pbXBsL2NvdW50ZXIvUmVxdWVzdFRvdGFsQ291bnRlck1ldHJpY3NUcmFja2VyLmphdmE=) | `100.00% <0.00%> (+25.00%)` | `1.00% <0.00%> (ø%)` | |
| [...stogram/RequestLatencyHistogramMetricsTracker.java](https://codecov.io/gh/apache/shardingsphere/pull/5459/diff?src=pr&el=tree#diff-c2hhcmRpbmctbWV0cmljcy9zaGFyZGluZy1tZXRyaWNzLXByb21ldGhldXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21ldHJpY3MvcHJvbWV0aGV1cy9pbXBsL2hpc3RvZ3JhbS9SZXF1ZXN0TGF0ZW5jeUhpc3RvZ3JhbU1ldHJpY3NUcmFja2VyLmphdmE=) | `100.00% <0.00%> (+25.00%)` | `1.00% <0.00%> (ø%)` | |
| [...ingsphere/metrics/facade/MetricsTrackerFacade.java](https://codecov.io/gh/apache/shardingsphere/pull/5459/diff?src=pr&el=tree#diff-c2hhcmRpbmctbWV0cmljcy9zaGFyZGluZy1tZXRyaWNzLWZhY2FkZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbWV0cmljcy9mYWNhZGUvTWV0cmljc1RyYWNrZXJGYWNhZGUuamF2YQ==) | `76.59% <0.00%> (+43.98%)` | `0.00% <0.00%> (ø%)` | |
| ... and [6 more](https://codecov.io/gh/apache/shardingsphere/pull/5459/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5459?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5459?src=pr&el=footer). Last update [630ddce...9688241](https://codecov.io/gh/apache/shardingsphere/pull/5459?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls commented on pull request #5459: Remove MasterSlaveDataSourceFactory and related API
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #5459:
URL: https://github.com/apache/shardingsphere/pull/5459#issuecomment-625375024
## Pull Request Test Coverage Report for [Build 11470](https://coveralls.io/builds/30631667)
* **1** of **2** **(50.0%)** changed or added relevant lines in **2** files are covered.
* **1** unchanged line in **1** file lost coverage.
* Overall coverage increased (+**0.03%**) to **57.683%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/api/ShadowDataSourceFactory.java](https://coveralls.io/builds/30631667/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fapi%2FShadowDataSourceFactory.java#L95) | 0 | 1 | 0.0%
<!-- | **Total:** | **1** | **2** | **50.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-jdbc/sharding-jdbc-orchestration/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/internal/yaml/YamlOrchestrationMasterSlaveRuleConfiguration.java](https://coveralls.io/builds/30631667/source?filename=sharding-jdbc%2Fsharding-jdbc-orchestration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Finternal%2Fyaml%2FYamlOrchestrationMasterSlaveRuleConfiguration.java#L31) | 1 | 0% |
<!-- | **Total:** | **1** | | -->
| Totals | [](https://coveralls.io/builds/30631667) |
| :-- | --: |
| Change from base [Build 11469](https://coveralls.io/builds/30624706): | 0.03% |
| Covered Lines: | 12065 |
| Relevant Lines: | 20916 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org