You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrii Babiichuk <ab...@hortonworks.com> on 2017/07/10 17:58:02 UTC
Review Request 60751: Log Search UI: implement sorting of logs list
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60751/
-----------------------------------------------------------
Review request for Ambari and Aleksandr Kovalenko.
Bugs: AMBARI-21438
https://issues.apache.org/jira/browse/AMBARI-21438
Repository: ambari
Description
-------
User should be able to sort logs list content by component name/level/time etc.
Diffs
-----
ambari-logsearch/ambari-logsearch-web-new/src/app/app.module.ts 72b5ad1
ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-button/dropdown-button.component.html PRE-CREATION
ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-button/dropdown-button.component.less PRE-CREATION
ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-button/dropdown-button.component.spec.ts PRE-CREATION
ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-button/dropdown-button.component.ts PRE-CREATION
ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-list/dropdown-list.component.spec.ts 445ee97
ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-list/dropdown-list.component.ts 6426f6a
ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-button/filter-button.component.spec.ts dda81e6
ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-button/filter-button.component.ts b529686
ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-dropdown/filter-dropdown.component.html bb7a206
ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-dropdown/filter-dropdown.component.less ec8e84b
ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-dropdown/filter-dropdown.component.spec.ts f6d1294
ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-dropdown/filter-dropdown.component.ts 1cf7d41
ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-text-field/filter-text-field.component.html 8fb7659
ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-text-field/filter-text-field.component.spec.ts 9123969
ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-text-field/filter-text-field.component.ts b05000b
ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.html 450ce5a
ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.less 46a157c
ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.spec.ts 1917f7f
ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.ts f42a2bb
ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.html 09b2e1e
ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.less 6ed0463
ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.spec.ts ffcfb83
ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.ts bf80445
ambari-logsearch/ambari-logsearch-web-new/src/app/components/menu-button/menu-button.component.html 5111197
ambari-logsearch/ambari-logsearch-web-new/src/app/components/menu-button/menu-button.component.ts 0c1f840
ambari-logsearch/ambari-logsearch-web-new/src/app/components/variables.less 9a8ea09
ambari-logsearch/ambari-logsearch-web-new/src/app/services/filtering.service.spec.ts 0ad3795
ambari-logsearch/ambari-logsearch-web-new/src/app/services/filtering.service.ts 36bb756
ambari-logsearch/ambari-logsearch-web-new/src/app/services/mock-api-data.service.ts 40645f0
ambari-logsearch/ambari-logsearch-web-new/src/app/services/utils.service.spec.ts PRE-CREATION
ambari-logsearch/ambari-logsearch-web-new/src/app/services/utils.service.ts PRE-CREATION
ambari-logsearch/ambari-logsearch-web-new/src/assets/i18n/en.json 755f307
Diff: https://reviews.apache.org/r/60751/diff/1/
Testing
-------
Executed 47 of 47 SUCCESS (1.178 secs / 1.147 secs)
Thanks,
Andrii Babiichuk
Re: Review Request 60751: Log Search UI: implement sorting of logs
list
Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60751/#review180070
-----------------------------------------------------------
Ship it!
Ship It!
- Aleksandr Kovalenko
On Июль 10, 2017, 5:57 п.п., Andrii Babiichuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60751/
> -----------------------------------------------------------
>
> (Updated Июль 10, 2017, 5:57 п.п.)
>
>
> Review request for Ambari and Aleksandr Kovalenko.
>
>
> Bugs: AMBARI-21438
> https://issues.apache.org/jira/browse/AMBARI-21438
>
>
> Repository: ambari
>
>
> Description
> -------
>
> User should be able to sort logs list content by component name/level/time etc.
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-web-new/src/app/app.module.ts 72b5ad1
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-button/dropdown-button.component.html PRE-CREATION
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-button/dropdown-button.component.less PRE-CREATION
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-button/dropdown-button.component.spec.ts PRE-CREATION
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-button/dropdown-button.component.ts PRE-CREATION
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-list/dropdown-list.component.spec.ts 445ee97
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-list/dropdown-list.component.ts 6426f6a
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-button/filter-button.component.spec.ts dda81e6
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-button/filter-button.component.ts b529686
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-dropdown/filter-dropdown.component.html bb7a206
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-dropdown/filter-dropdown.component.less ec8e84b
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-dropdown/filter-dropdown.component.spec.ts f6d1294
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-dropdown/filter-dropdown.component.ts 1cf7d41
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-text-field/filter-text-field.component.html 8fb7659
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-text-field/filter-text-field.component.spec.ts 9123969
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-text-field/filter-text-field.component.ts b05000b
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.html 450ce5a
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.less 46a157c
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.spec.ts 1917f7f
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.ts f42a2bb
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.html 09b2e1e
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.less 6ed0463
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.spec.ts ffcfb83
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.ts bf80445
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/menu-button/menu-button.component.html 5111197
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/menu-button/menu-button.component.ts 0c1f840
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/variables.less 9a8ea09
> ambari-logsearch/ambari-logsearch-web-new/src/app/services/filtering.service.spec.ts 0ad3795
> ambari-logsearch/ambari-logsearch-web-new/src/app/services/filtering.service.ts 36bb756
> ambari-logsearch/ambari-logsearch-web-new/src/app/services/mock-api-data.service.ts 40645f0
> ambari-logsearch/ambari-logsearch-web-new/src/app/services/utils.service.spec.ts PRE-CREATION
> ambari-logsearch/ambari-logsearch-web-new/src/app/services/utils.service.ts PRE-CREATION
> ambari-logsearch/ambari-logsearch-web-new/src/assets/i18n/en.json 755f307
>
>
> Diff: https://reviews.apache.org/r/60751/diff/1/
>
>
> Testing
> -------
>
> Executed 47 of 47 SUCCESS (1.178 secs / 1.147 secs)
>
>
> Thanks,
>
> Andrii Babiichuk
>
>