[jira] [Commented] (ORC-688) Allow CHAR, VARCHAR to be promoted to STRING

["Panagiotis Garefalakis (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ORC-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239263#comment-17239263 ] 

Panagiotis Garefalakis commented on ORC-688:
--------------------------------------------

Hey [~shardulm] thanks for reporting this. Seems like we are currently missing that conversion opportunity in createStringConvertTreeReader as part of the ConvertTreeReaderFactory. I opened a PR to address this – let me know if there there a particular version you wish to backport to

> Allow CHAR, VARCHAR to be promoted to STRING
> --------------------------------------------
>
>                 Key: ORC-688
>                 URL: https://issues.apache.org/jira/browse/ORC-688
>             Project: ORC
>          Issue Type: Wish
>            Reporter: Shardul Mahadik
>            Assignee: Panagiotis Garefalakis
>            Priority: Major
>
> E.g. For the evolution File type {{struct<x:char(10)>}} Reader type {{struct<x:string>}}
> we currently get the following error
> {code}
> java.lang.IllegalArgumentException: No conversion of type STRING to self needed
> 	at org.apache.orc.impl.ConvertTreeReaderFactory.createStringConvertTreeReader(ConvertTreeReaderFactory.java:1954)
> 	at org.apache.orc.impl.ConvertTreeReaderFactory.createConvertTreeReader(ConvertTreeReaderFactory.java:2267)
> 	at org.apache.orc.impl.TreeReaderFactory.createTreeReader(TreeReaderFactory.java:2804)
> 	at org.apache.orc.impl.TreeReaderFactory$StructTreeReader.<init>(TreeReaderFactory.java:2420)
> 	at org.apache.orc.impl.TreeReaderFactory.createTreeReader(TreeReaderFactory.java:2844)
> 	at org.apache.orc.impl.TreeReaderFactory.createRootReader(TreeReaderFactory.java:2859)
> {code}
> Should we allow such an evolution?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)