You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/27 09:41:55 UTC
[GitHub] [flink] TisonKun commented on a change in pull request #8016: [FLINK-10705][web]: Rework Flink Web Dashboard
TisonKun commented on a change in pull request #8016:
URL: https://github.com/apache/flink/pull/8016#discussion_r415664614
##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/subtask/job-checkpoints-subtask.component.html
##########
@@ -0,0 +1,109 @@
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+
+<div class="subtasks">
+ <strong>SubTasks:</strong>
+ <nz-table
+ class="no-border small"
+ [nzData]="subTaskCheckPoint && subTaskCheckPoint['summary'] ? [''] : []"
+ [nzSize]="'small'"
+ [nzLoading]="isLoading"
+ [nzFrontPagination]="false"
+ [nzShowPagination]="false">
+ <thead>
+ <tr>
+ <th></th>
+ <th><strong>End to End Duration</strong></th>
+ <th><strong>State Size</strong></th>
+ <th><strong>Checkpoint Duration (Sync)</strong></th>
+ <th><strong>Checkpoint Duration (Async)</strong></th>
+ <th><strong>Alignment Buffered</strong></th>
+ <th><strong>Alignment Duration</strong></th>
+ </tr>
+ </thead>
+ <tbody>
+ <ng-container *ngIf="subTaskCheckPoint && subTaskCheckPoint['summary']">
+ <tr>
+ <td><strong>Minimum</strong></td>
+ <td>{{ subTaskCheckPoint['summary']['end_to_end_duration']['min'] | humanizeDuration}}</td>
+ <td>{{ subTaskCheckPoint['summary']['state_size']['min'] | humanizeBytes }}</td>
+ <td>{{ subTaskCheckPoint['summary']['checkpoint_duration']['sync']['min'] | humanizeDuration}}</td>
+ <td>{{ subTaskCheckPoint['summary']['checkpoint_duration']['async']['min'] | humanizeDuration}}</td>
+ <td>{{ subTaskCheckPoint['summary']['alignment']['buffered']['min'] | humanizeBytes }}</td>
+ <td>{{ subTaskCheckPoint['summary']['alignment']['duration']['min'] | humanizeDuration}}</td>
+ </tr>
+ <tr>
+ <td><strong>Average</strong></td>
+ <td>{{ subTaskCheckPoint['summary']['end_to_end_duration']['avg'] | humanizeDuration}}</td>
+ <td>{{ subTaskCheckPoint['summary']['state_size']['avg'] | humanizeBytes }}</td>
+ <td>{{ subTaskCheckPoint['summary']['checkpoint_duration']['sync']['avg'] | humanizeDuration}}</td>
+ <td>{{ subTaskCheckPoint['summary']['checkpoint_duration']['async']['avg'] | humanizeDuration}}</td>
+ <td>{{ subTaskCheckPoint['summary']['alignment']['buffered']['avg'] | humanizeBytes }}</td>
+ <td>{{ subTaskCheckPoint['summary']['alignment']['duration']['avg'] | humanizeDuration}}</td>
+ </tr>
+ <tr>
+ <td><strong>Maximum</strong></td>
+ <td>{{ subTaskCheckPoint['summary']['end_to_end_duration']['max'] | humanizeDuration}}</td>
+ <td>{{ subTaskCheckPoint['summary']['state_size']['max'] | humanizeBytes }}</td>
+ <td>{{ subTaskCheckPoint['summary']['checkpoint_duration']['sync']['max'] | humanizeDuration}}</td>
+ <td>{{ subTaskCheckPoint['summary']['checkpoint_duration']['async']['max'] | humanizeDuration}}</td>
+ <td>{{ subTaskCheckPoint['summary']['alignment']['buffered']['max'] | humanizeBytes }}</td>
+ <td>{{ subTaskCheckPoint['summary']['alignment']['duration']['max'] | humanizeDuration}}</td>
+ </tr>
+ </ng-container>
+ </tbody>
+ </nz-table>
+
+ <nz-table
+ class="no-border small"
+ [nzData]="listOfSubTaskCheckPoint"
+ [nzSize]="'small'"
+ [nzLoading]="isLoading"
+ [nzFrontPagination]="false"
+ [nzShowPagination]="false">
+ <thead (nzSortChange)="sort($event)" nzSingleSort>
+ <tr>
+ <th><strong>ID</strong></th>
+ <th nzSortKey="ack_timestamp" nzShowSort><strong>Acknowledgement Time</strong></th>
+ <th nzSortKey="end_to_end_duration" nzShowSort><strong>E2E Duration</strong></th>
+ <th nzSortKey="state_size" nzShowSort><strong>State Size</strong></th>
+ <th nzSortKey="checkpoint.sync" nzShowSort><strong>Checkpoint Duration (Sync)</strong></th>
+ <th nzSortKey="checkpoint.async" nzShowSort><strong>Checkpoint Duration (Async)</strong></th>
+ <th nzSortKey="alignment.buffered" nzShowSort><strong>Align Buffered</strong></th>
+ <th nzSortKey="alignment.duration" nzShowSort><strong>Align Duration</strong></th>
+ </tr>
+ </thead>
+ <tbody>
+ <tr *ngFor="let subTask of listOfSubTaskCheckPoint">
+ <td>{{ subTask['index'] + 1 }}</td>
Review comment:
Why `+1`?
##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job/overview/backpressure/job-overview-drawer-backpressure.component.html
##########
@@ -0,0 +1,68 @@
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+
+<nz-table
+ class="no-border small full-height"
+ [nzSize]="'small'"
+ [nzLoading]="isLoading"
+ [nzData]="listOfSubTaskBackpressure"
+ [nzScroll]="{y:'calc( 100% - 72px )'}"
+ [nzWidthConfig]="['33.33%','33.33%','33.33%']"
+ [nzFrontPagination]="false"
+ [nzShowPagination]="false">
+ <thead>
+ <tr>
+ <th colspan="3">
+ <span *ngIf="selectedVertex?.detail?.status === 'RUNNING'">
+ Measurement:
+ <span *ngIf="backpressure['end-timestamp']">
+ {{ (now - backpressure['end-timestamp']) | humanizeDuration }} ago
+ </span>
+ <span *ngIf="backpressure['status'] === 'deprecated'">
+ Sampling in progress...
+ </span>
+ <span *ngIf="(!backpressure['end-timestamp']) && (backpressure['status'] !== 'deprecated')">
+ -
+ </span>
+ <nz-divider [nzType]="'vertical'"></nz-divider>
+ Back Pressure Status:
+ <span>
+ <flink-backpressure-badge [state]="backpressure['backpressure-level']"></flink-backpressure-badge>
+ </span>
+ </span>
+ <span *ngIf="selectedVertex?.detail?.status !== 'RUNNING'">
+ Operator is not running. Cannot sample back pressure.
+ </span>
+ </th>
+ </tr>
+ <tr>
+ <th>SubTask</th>
+ <th>Ratio</th>
+ <th>Status</th>
+ </tr>
+ </thead>
+ <tbody>
+ <tr *ngFor="let subtask of listOfSubTaskBackpressure;trackBy:trackBackPressureBy;">
+ <td>{{ subtask['subtask'] + 1 }}</td>
Review comment:
Why `+1`?
##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job/overview/subtasks/job-overview-drawer-subtasks.component.html
##########
@@ -0,0 +1,80 @@
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+
+<nz-table
+ class="no-border small full-height"
+ [nzSize]="'small'"
+ [nzLoading]="isLoading"
+ [nzData]="listOfTask"
+ [nzScroll]="{x:'1430px',y:'calc( 100% - 35px )'}"
+ [nzFrontPagination]="false"
+ [nzShowPagination]="false">
+ <thead (nzSortChange)="sort($event)" nzSingleSort>
+ <tr>
+ <th nzWidth="80px" nzLeft="0px">ID</th>
+ <th nzSortKey="metrics.read-bytes" nzShowSort nzWidth="140px">Bytes Received</th>
+ <th nzSortKey="metrics.read-records" nzShowSort nzWidth="150px">Records Received</th>
+ <th nzSortKey="metrics.write-bytes" nzShowSort nzWidth="120px">Bytes Sent</th>
+ <th nzSortKey="metrics.write-records" nzShowSort nzWidth="120px">Records Sent</th>
+ <th nzSortKey="attempt" nzShowSort nzWidth="100px">Attempt</th>
+ <th nzSortKey="host" nzShowSort nzWidth="200px">Host</th>
+ <th nzSortKey="start_time" nzShowSort nzWidth="150px">Start Time</th>
+ <th nzSortKey="duration" nzShowSort nzWidth="100px">Duration</th>
+ <th nzSortKey="end-time" nzShowSort nzWidth="150px">End Time</th>
+ <th nzSortKey="status" nzShowSort nzWidth="120px" nzRight="0px">Status</th>
+ </tr>
+ </thead>
+ <tbody>
+ <tr *ngFor="let task of listOfTask; trackBy:trackTaskBy;">
+ <td nzLeft="0">
+ {{ task.subtask }}
Review comment:
And here we not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org