You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by aaltay <gi...@git.apache.org> on 2016/12/23 01:10:47 UTC

[GitHub] incubator-beam pull request #1692: [BEAM-1090] Skip the test_memory_usage te...

GitHub user aaltay opened a pull request:

    https://github.com/apache/incubator-beam/pull/1692

    [BEAM-1090] Skip the test_memory_usage test on macos. 

    The underlying implementation for getting the used memory does
    not use standard units and varies across macos versions (bytes vs kbytes),
    causing Travis errors. Linux version is stable and use the documented 
    units (kbytes).
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aaltay/incubator-beam oom

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1692.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1692
    
----
commit c9dee42a781b4985e208efa392760f87aa733cd2
Author: Ahmet Altay <al...@google.com>
Date:   2016-12-23T01:07:18Z

    Skip the test_memory_usage test on macos. The underlying implementation
    for getting the used memory does not use standard units and varies
        across macos versions (bytes vs kbytes), causing Travis errors.
        Linux version is stable and use the documented units (kbytes)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-beam pull request #1692: [BEAM-1090] Skip the test_memory_usage te...

Posted by aaltay <gi...@git.apache.org>.
Github user aaltay closed the pull request at:

    https://github.com/apache/incubator-beam/pull/1692


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---