You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Denis Dzenskevich (JIRA)" <ji...@apache.org> on 2011/04/30 21:26:03 UTC
[jira] [Commented] (HTTPASYNC-3) Async SessionPool does not
correctly handle expired I/O sessions
[ https://issues.apache.org/jira/browse/HTTPASYNC-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027363#comment-13027363 ]
Denis Dzenskevich commented on HTTPASYNC-3:
-------------------------------------------
Does NOT work.
I also found the deterministic test, maybe it can help with debugging. I use Jetty here to simulate slow response and socket timeout. The errors are similar in both this test and the one originally reported.
import org.apache.http.HttpResponse;
import org.apache.http.client.methods.HttpGet;
import org.apache.http.impl.nio.client.DefaultHttpAsyncClient;
import org.apache.http.impl.nio.conn.PoolingClientConnectionManager;
import org.apache.http.nio.concurrent.FutureCallback;
import org.mortbay.jetty.Server;
import org.mortbay.jetty.nio.SelectChannelConnector;
import org.mortbay.jetty.servlet.Context;
import org.mortbay.jetty.servlet.ServletHolder;
import javax.servlet.ServletException;
import javax.servlet.http.HttpServlet;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import java.io.IOException;
public class Test2 {
public static void main(String[] args) throws Exception {
final Server server = new Server(8080);
server.addConnector(new SelectChannelConnector());
Context root = new Context(server, "/", Context.NO_SESSIONS);
ServletHolder servletHolder = new ServletHolder(new SimpleServlet());
root.addServlet(servletHolder, "/");
Thread serverThread = new Thread(new Runnable() {
public void run() {
try {
server.start();
} catch (Exception e) {
e.printStackTrace();
}
}
});
serverThread.start();
while (!server.isStarted())
Thread.sleep(0);
DefaultHttpAsyncClient client = new DefaultHttpAsyncClient();
client.getParams().setParameter("http.socket.timeout", 1000);
((PoolingClientConnectionManager)client.getConnectionManager()).setDefaultMaxPerHost(1);
((PoolingClientConnectionManager)client.getConnectionManager()).setTotalMax(1);
client.start();
client.execute(new HttpGet("http://localhost:8080/1"), new MyFutureCallback(1));
client.execute(new HttpGet("http://localhost:8080/2"), new MyFutureCallback(2))
.get();
System.exit(0);
}
public static class SimpleServlet extends HttpServlet {
@Override protected void service(HttpServletRequest req, HttpServletResponse resp) throws ServletException, IOException {
try {
Thread.sleep(100000);
} catch (InterruptedException ignore) {
}
resp.setContentType("text/plain");
resp.setCharacterEncoding("utf-8");
resp.setStatus(HttpServletResponse.SC_OK);
resp.getWriter().println("Requested: " + req.getRequestURI());
}
}
private static class MyFutureCallback implements FutureCallback<HttpResponse> {
private final int i;
public MyFutureCallback(int i) {
this.i = i;
}
public void completed(HttpResponse result) {
System.err.println("completed: " + i + ": " + result.getStatusLine().getStatusCode());
}
public void failed(Exception ex) {
System.err.println("failed: " + i + ": " + ex.getMessage());
}
public void cancelled() {
System.err.println("cancelled: " + i);
}
}
}
> Async SessionPool does not correctly handle expired I/O sessions
> ----------------------------------------------------------------
>
> Key: HTTPASYNC-3
> URL: https://issues.apache.org/jira/browse/HTTPASYNC-3
> Project: HttpComponents HttpAsyncClient
> Issue Type: Bug
> Affects Versions: 4.0-alpha1
> Reporter: Lokesh
> Priority: Critical
> Fix For: 4.0-alpha2
>
> Original Estimate: 1m
> Remaining Estimate: 1m
>
> here is an example code to use the HTTP AsyncClient and seeing an exception. Please also let me know how to deal with this issue,
> /*
> * To change this template, choose Tools | Templates
> * and open the template in the editor.
> */
> package httpanalysis.apache;
> import java.util.concurrent.CountDownLatch;
> import java.util.concurrent.Future;
> import java.util.concurrent.TimeUnit;
> import java.util.logging.Level;
> import java.util.logging.Logger;
> import org.apache.http.HttpHost;
> import org.apache.http.HttpResponse;
> import org.apache.http.client.methods.HttpGet;
> import org.apache.http.impl.nio.client.DefaultHttpAsyncClient;
> import org.apache.http.impl.nio.conn.PoolingClientConnectionManager;
> import org.apache.http.impl.nio.reactor.DefaultConnectingIOReactor;
> import org.apache.http.nio.client.HttpAsyncClient;
> import org.apache.http.nio.conn.scheme.Scheme;
> import org.apache.http.nio.conn.scheme.SchemeRegistry;
> import org.apache.http.nio.reactor.ConnectingIOReactor;
> import org.apache.http.nio.reactor.IOReactorException;
> import org.apache.http.params.BasicHttpParams;
> import org.apache.http.params.CoreConnectionPNames;
> /**
> *
> * @author lokesh
> */
> public class HttpAnalysis {
> PoolingClientConnectionManager poolManager;
> HttpAsyncClient httpclient = null;
> private PoolingClientConnectionManager sessionManager;
> /**
> * @param args the command line arguments
> */
> public static void main(String[] args) {
> HttpAnalysis analysis = new HttpAnalysis();
> analysis.process();
> }
> public HttpAnalysis() {
> try {
> BasicHttpParams basicHttpParams = new BasicHttpParams();
> basicHttpParams.setParameter(CoreConnectionPNames.CONNECTION_TIMEOUT, 1);
> basicHttpParams.setParameter(CoreConnectionPNames.SO_TIMEOUT, 2);
> basicHttpParams.setParameter(CoreConnectionPNames.SOCKET_BUFFER_SIZE, 2 * 1024);
> basicHttpParams.setParameter(CoreConnectionPNames.STALE_CONNECTION_CHECK, false);
> basicHttpParams.setParameter(CoreConnectionPNames.SO_REUSEADDR, false);
>
>
>
>
> ConnectingIOReactor ioReactor = new DefaultConnectingIOReactor(2, basicHttpParams);
> SchemeRegistry schemeRegistry = new SchemeRegistry();
> schemeRegistry.register(new Scheme("http", 80, null));
> this.sessionManager = new PoolingClientConnectionManager(ioReactor, schemeRegistry, 5, TimeUnit.MINUTES);
> sessionManager.setTotalMax(50);
> sessionManager.setDefaultMaxPerHost(25);
>
> this.httpclient = new DefaultHttpAsyncClient(ioReactor, sessionManager,basicHttpParams);
> } catch (IOReactorException ex) {
> Logger.getLogger(HttpAnalysis.class.getName()).log(Level.SEVERE, null, ex);
> }
> }
> private void process() {
> try {
> int numRequests = 10000;
> httpclient.start();
> long startTime = System.currentTimeMillis();
> final CountDownLatch countDownLatch = new CountDownLatch(numRequests);
> for (int i = 0; i < numRequests; i++) {
> HttpGet request = new HttpGet("http://hc.apache.org/");
> Future<HttpResponse> future = httpclient.execute(request, new HttpCallback(this, countDownLatch));
> if(future == null){
> countDownLatch.countDown();
> }
> System.out.println("Request number = " + i);
> //sessionManager.closeExpiredConnections();
> }
> countDownLatch.await();
> System.out.println((System.currentTimeMillis() - startTime));
> System.exit(1);
> } catch (Exception ex) {
> Logger.getLogger(HttpAnalysis.class.getName()).log(Level.SEVERE, null, ex);
> }
> }
> }
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org