[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9349: Set SkipTimeValueCheck from table config

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on code in PR #9349:
URL: https://github.com/apache/pinot/pull/9349#discussion_r966520449


##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/IndexingConfig.java:
##########
@@ -55,6 +55,7 @@ public class IndexingConfig extends BaseJsonConfig {
   private boolean _nullHandlingEnabled;
   private boolean _continueOnError;
   private boolean _validateTimeValue;
+  private boolean _skipTimeValueCheck;

Review Comment:
   It is kind of confusing to have both `validateTimeValue` and `skipTimeValueCheck`, where they are not for the same purpose:
   validateTimeValue: per record time value check
   skipTimeValueCheck: per segment time range check
   
   We should rename them so that it is more clear. Also we should move `continueOnError`, `validateTimeValue` and `skipTimeValueCheck` into the `IngestionConfig`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org