[jira] Commented: (THRIFT-485) Generated validate methods that reference external thrift files' types are not referenced correctly

["Kevin Clark (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12706125#action_12706125 ] 

Kevin Clark commented on THRIFT-485:
------------------------------------

Looks like a good fix. +1

> Generated validate methods that reference external thrift files' types are not referenced correctly
> ---------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-485
>                 URL: https://issues.apache.org/jira/browse/THRIFT-485
>             Project: Thrift
>          Issue Type: Bug
>          Components: Compiler (Ruby)
>    Affects Versions: 0.1, 0.2
>            Reporter: Bryan Duxbury
>            Assignee: Bryan Duxbury
>             Fix For: 0.2
>
>         Attachments: thrift-485.patch
>
>
> If you have an enum in one thrift file and a struct with a field of that enum in another thrift file, the generated ruby code will try to validate the field's value against the enum's class, but without the namespace, resulting in errors. 
> Also, I found one other place where we should use the fully qualified type name instead of just the type name - when rendering constants of a struct.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.