[jira] [Commented] (YARN-5663) Possible resource leak

["Daniel Templeton (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-5663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15513754#comment-15513754 ] 

Daniel Templeton commented on YARN-5663:
----------------------------------------

I don't think that's actually a leak, but I don't mind the refactor to make it simpler.  Please remove the semicolon from the _try_ line.  Also, the indentation on line 864 was correct before you modified it.  Please put it back where it was.  I always like to see unit tests, especially with refactoring, but this one's fundamental enough that it's probably OK to let it slide.

> Possible resource leak
> ----------------------
>
>                 Key: YARN-5663
>                 URL: https://issues.apache.org/jira/browse/YARN-5663
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Oleksii Dymytrov
>            Priority: Minor
>         Attachments: YARN_5663_v1_001_patch.patch
>
>
> ByteArrayOutputStream resource will not be freed in case of errors in write method



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org