You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by nj...@apache.org on 2016/06/17 07:26:09 UTC
[2/3] kylin git commit: Modify the log info
Modify the log info
Project: http://git-wip-us.apache.org/repos/asf/kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/7b80edb1
Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/7b80edb1
Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/7b80edb1
Branch: refs/heads/1.4-rc
Commit: 7b80edb1b79272bdb9cd26bbb576f13bcb9c38c4
Parents: 5872447
Author: kyotoYaho <nj...@apache.org>
Authored: Fri Jun 17 15:24:16 2016 +0800
Committer: kyotoYaho <nj...@apache.org>
Committed: Fri Jun 17 15:24:16 2016 +0800
----------------------------------------------------------------------
.../src/main/java/org/apache/kylin/cube/kv/RowKeyEncoder.java | 3 ++-
.../org/apache/kylin/metadata/filter/ConstantTupleFilter.java | 5 -----
2 files changed, 2 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kylin/blob/7b80edb1/core-cube/src/main/java/org/apache/kylin/cube/kv/RowKeyEncoder.java
----------------------------------------------------------------------
diff --git a/core-cube/src/main/java/org/apache/kylin/cube/kv/RowKeyEncoder.java b/core-cube/src/main/java/org/apache/kylin/cube/kv/RowKeyEncoder.java
index 990cf06..3f67213 100644
--- a/core-cube/src/main/java/org/apache/kylin/cube/kv/RowKeyEncoder.java
+++ b/core-cube/src/main/java/org/apache/kylin/cube/kv/RowKeyEncoder.java
@@ -89,7 +89,8 @@ public class RowKeyEncoder extends AbstractRowKeyEncoder {
@Override
public void encode(ByteArray bodyBytes, ByteArray outputBuf) {
- Preconditions.checkState(bodyBytes.length() == bodyLength);
+ Preconditions.checkState(bodyBytes.length() == bodyLength,//
+ "bodybytes length: " + bodyBytes.length() + " merged body length: " + bodyLength);
Preconditions.checkState(bodyBytes.length() + getHeaderLength() == outputBuf.length(),//
"bodybytes length: " + bodyBytes.length() + " outputBuf length: " + outputBuf.length() + " header length: " + getHeaderLength());
System.arraycopy(bodyBytes.array(), bodyBytes.offset(), outputBuf.array(), getHeaderLength(), bodyLength);
http://git-wip-us.apache.org/repos/asf/kylin/blob/7b80edb1/core-metadata/src/main/java/org/apache/kylin/metadata/filter/ConstantTupleFilter.java
----------------------------------------------------------------------
diff --git a/core-metadata/src/main/java/org/apache/kylin/metadata/filter/ConstantTupleFilter.java b/core-metadata/src/main/java/org/apache/kylin/metadata/filter/ConstantTupleFilter.java
index a92c699..0246e08 100644
--- a/core-metadata/src/main/java/org/apache/kylin/metadata/filter/ConstantTupleFilter.java
+++ b/core-metadata/src/main/java/org/apache/kylin/metadata/filter/ConstantTupleFilter.java
@@ -101,13 +101,8 @@ public class ConstantTupleFilter extends TupleFilter {
buffer = ByteBuffer.allocate(bufferSize);
int size = this.constantValues.size();
BytesUtil.writeVInt(size, buffer);
- logger.info("constantValues.size: {}", size);
for (Object val : this.constantValues) {
- if(! (val instanceof String)){
- logger.error("Problematic constant value:" + val);
- }
cs.serialize(val, buffer);
- logger.info("Buffer Position: {}", buffer.position());
}
break;
}catch (BufferOverflowException e) {