You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Lukasz Lenart (JIRA)" <ji...@apache.org> on 2016/09/06 07:19:20 UTC
[jira] [Updated] (WW-4674) StrutsPrepareAndExecuteFilter should
check for response commited status
[ https://issues.apache.org/jira/browse/WW-4674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lukasz Lenart updated WW-4674:
------------------------------
Description:
In StrutsPrepareAndExecuteFilter in doFilter method there is a code fragment
{code}
ActionMapping mapping = this.prepare.findActionMapping(request, response, true);
if(mapping == null) {
boolean handled = this.execute.executeStaticResourceRequest(request, response);
if(!handled) {
chain.doFilter(request, response);
}
} else {
this.execute.executeAction(request, response, mapping);
}
{code}
Problem is that {{this.prepare.findActionMapping(request, response, true)}} can commit response (in case of exception), but filter continues with execution of chain, in my case causing problems up in the chain.
was:
In StrutsPrepareAndExecuteFilter in doFilter method there is a code fragment
{code}
ActionMapping mapping = this.prepare.findActionMapping(request, response, true);
if(mapping == null) {
boolean handled = this.execute.executeStaticResourceRequest(request, response);
if(!handled) {
chain.doFilter(request, response);
}
} else {
this.execute.executeAction(request, response, mapping);
}
{code}
Problem is that this.prepare.findActionMapping(request, response, true) can commit response (in case of exception), but filter continues with execution of chain, in my case causing problems up in the chain.
> StrutsPrepareAndExecuteFilter should check for response commited status
> ------------------------------------------------------------------------
>
> Key: WW-4674
> URL: https://issues.apache.org/jira/browse/WW-4674
> Project: Struts 2
> Issue Type: Improvement
> Affects Versions: 2.3.30
> Reporter: Mirek Hankus
> Fix For: 2.3.31, 2.5.3
>
>
> In StrutsPrepareAndExecuteFilter in doFilter method there is a code fragment
> {code}
> ActionMapping mapping = this.prepare.findActionMapping(request, response, true);
> if(mapping == null) {
> boolean handled = this.execute.executeStaticResourceRequest(request, response);
> if(!handled) {
> chain.doFilter(request, response);
> }
> } else {
> this.execute.executeAction(request, response, mapping);
> }
> {code}
> Problem is that {{this.prepare.findActionMapping(request, response, true)}} can commit response (in case of exception), but filter continues with execution of chain, in my case causing problems up in the chain.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)