[GitHub] [incubator-doris] morningman commented on a change in pull request #7148: [Lateral View] Pruning output slot of TableFunctionNode

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #7148:
URL: https://github.com/apache/incubator-doris/pull/7148#discussion_r752289824



##########
File path: fe/fe-core/src/main/java/org/apache/doris/planner/TableFunctionNode.java
##########
@@ -29,14 +32,22 @@
 import org.apache.doris.thrift.TTableFunctionNode;
 
 import java.util.List;
+import java.util.Set;
 import java.util.stream.Collectors;
 
+import com.clearspring.analytics.util.Lists;
+import org.glassfish.jersey.internal.guava.Sets;

Review comment:
       wrong imports

##########
File path: gensrc/thrift/PlanNodes.thrift
##########
@@ -658,6 +658,7 @@ struct TOlapRewriteNode {
 
 struct TTableFunctionNode {
     1: required list<Exprs.TExpr> fnCallExprList
+    2: required list<Types.TSlotId> outputSlotIds

Review comment:
       Better to change both fields as `optional`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org