You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/04/22 13:23:23 UTC
[GitHub] [skywalking-data-collect-protocol] kezhenxu94 opened a new pull request #51: Add throughput field for ServiceMeshMetric
kezhenxu94 opened a new pull request #51:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/51
Add a field to store the throughput of TCP services
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-data-collect-protocol] wu-sheng commented on a change in pull request #51: Add throughput field for ServiceMeshMetric
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #51:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/51#discussion_r618430896
##########
File path: service-mesh-probe/service-mesh.proto
##########
@@ -56,6 +56,9 @@ message ServiceMeshMetric {
// The sidecar/proxy internal error code, the value bases on the implementation.
// The envoy internal error codes are listed here, https://www.envoyproxy.io/docs/envoy/latest/api-v2/data/accesslog/v2/accesslog.proto#data-accesslog-v2-responseflags
string internalErrorCode = 14;
+
+ // The throughput detail of the mesh metrics.
+ Throughput throughput = 15;
Review comment:
My point is, TCP should be separate object or only an extra field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-data-collect-protocol] wu-sheng commented on a change in pull request #51: Add throughput field for ServiceMeshMetric
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #51:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/51#discussion_r618463002
##########
File path: service-mesh-probe/service-mesh.proto
##########
@@ -56,6 +56,9 @@ message ServiceMeshMetric {
// The sidecar/proxy internal error code, the value bases on the implementation.
// The envoy internal error codes are listed here, https://www.envoyproxy.io/docs/envoy/latest/api-v2/data/accesslog/v2/accesslog.proto#data-accesslog-v2-responseflags
string internalErrorCode = 14;
+
+ // The throughput detail of the mesh metrics.
+ Throughput throughput = 15;
Review comment:
I don't want throughput or traffic. As this is an access metric, it is basically duplicated information.
Also, if one day, we need to add more fields related to TCP, it is better naming as TCP directly, such as resent packages/bytes(guessing only)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-data-collect-protocol] wu-sheng merged pull request #51: Add throughput field for ServiceMeshMetric
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #51:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-data-collect-protocol] wu-sheng commented on a change in pull request #51: Add throughput field for ServiceMeshMetric
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #51:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/51#discussion_r618481446
##########
File path: service-mesh-probe/service-mesh.proto
##########
@@ -56,6 +56,9 @@ message ServiceMeshMetric {
// The sidecar/proxy internal error code, the value bases on the implementation.
// The envoy internal error codes are listed here, https://www.envoyproxy.io/docs/envoy/latest/api-v2/data/accesslog/v2/accesslog.proto#data-accesslog-v2-responseflags
string internalErrorCode = 14;
+
+ // The throughput detail of the mesh metrics.
+ Throughput throughput = 15;
Review comment:
Whether do we need `Throughput`, seems not very important.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-data-collect-protocol] kezhenxu94 commented on a change in pull request #51: Add throughput field for ServiceMeshMetric
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #51:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/51#discussion_r618920186
##########
File path: service-mesh-probe/service-mesh.proto
##########
@@ -67,11 +67,11 @@ enum Protocol {
TCP = 2;
}
-message Throughput {
+message Tcp {
Review comment:
Renamed to `TCPInfo` because `TCP` is defined in `enum Protocol`, in the same package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-data-collect-protocol] kezhenxu94 commented on a change in pull request #51: Add throughput field for ServiceMeshMetric
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #51:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/51#discussion_r618460177
##########
File path: service-mesh-probe/service-mesh.proto
##########
@@ -56,6 +56,9 @@ message ServiceMeshMetric {
// The sidecar/proxy internal error code, the value bases on the implementation.
// The envoy internal error codes are listed here, https://www.envoyproxy.io/docs/envoy/latest/api-v2/data/accesslog/v2/accesslog.proto#data-accesslog-v2-responseflags
string internalErrorCode = 14;
+
+ // The throughput detail of the mesh metrics.
+ Throughput throughput = 15;
Review comment:
> Let's rename this to TCP?
Do you mean `tcpThroughput`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-data-collect-protocol] wu-sheng merged pull request #51: Add throughput field for ServiceMeshMetric
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #51:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-data-collect-protocol] wu-sheng commented on a change in pull request #51: Add throughput field for ServiceMeshMetric
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #51:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/51#discussion_r618454791
##########
File path: service-mesh-probe/service-mesh.proto
##########
@@ -56,6 +56,9 @@ message ServiceMeshMetric {
// The sidecar/proxy internal error code, the value bases on the implementation.
// The envoy internal error codes are listed here, https://www.envoyproxy.io/docs/envoy/latest/api-v2/data/accesslog/v2/accesslog.proto#data-accesslog-v2-responseflags
string internalErrorCode = 14;
+
+ // The throughput detail of the mesh metrics.
+ Throughput throughput = 15;
Review comment:
> do you mean the latency would be counted twice for Tcp services? If so, it is not the case.
Yes. that was my question. So, it is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-data-collect-protocol] wu-sheng commented on a change in pull request #51: Add throughput field for ServiceMeshMetric
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #51:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/51#discussion_r618490539
##########
File path: service-mesh-probe/service-mesh.proto
##########
@@ -56,6 +56,9 @@ message ServiceMeshMetric {
// The sidecar/proxy internal error code, the value bases on the implementation.
// The envoy internal error codes are listed here, https://www.envoyproxy.io/docs/envoy/latest/api-v2/data/accesslog/v2/accesslog.proto#data-accesslog-v2-responseflags
string internalErrorCode = 14;
+
+ // The throughput detail of the mesh metrics.
+ Throughput throughput = 15;
Review comment:
Yes, is this good to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-data-collect-protocol] wu-sheng commented on a change in pull request #51: Add throughput field for ServiceMeshMetric
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #51:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/51#discussion_r618447490
##########
File path: service-mesh-probe/service-mesh.proto
##########
@@ -56,6 +56,9 @@ message ServiceMeshMetric {
// The sidecar/proxy internal error code, the value bases on the implementation.
// The envoy internal error codes are listed here, https://www.envoyproxy.io/docs/envoy/latest/api-v2/data/accesslog/v2/accesslog.proto#data-accesslog-v2-responseflags
string internalErrorCode = 14;
+
+ // The throughput detail of the mesh metrics.
+ Throughput throughput = 15;
Review comment:
But we have OAL related to the latency, if you share the existing one, I think the metrics there would be wrong.
What do you think? Should we have ServiceMeshTCPMetric?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-data-collect-protocol] kezhenxu94 commented on a change in pull request #51: Add throughput field for ServiceMeshMetric
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #51:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/51#discussion_r618466859
##########
File path: service-mesh-probe/service-mesh.proto
##########
@@ -56,6 +56,9 @@ message ServiceMeshMetric {
// The sidecar/proxy internal error code, the value bases on the implementation.
// The envoy internal error codes are listed here, https://www.envoyproxy.io/docs/envoy/latest/api-v2/data/accesslog/v2/accesslog.proto#data-accesslog-v2-responseflags
string internalErrorCode = 14;
+
+ // The throughput detail of the mesh metrics.
+ Throughput throughput = 15;
Review comment:
OK hope I understand correctly, do you mean rename `Throughput` to `TCP`, and make `throughput` a field of `TCP`?
```
message ServiceMeshMetric {
//...
TCP tcp = 15;
//...
}
message TCP {
Throughput throughput = 1;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-data-collect-protocol] kezhenxu94 commented on a change in pull request #51: Add throughput field for ServiceMeshMetric
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #51:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/51#discussion_r618920186
##########
File path: service-mesh-probe/service-mesh.proto
##########
@@ -67,11 +67,11 @@ enum Protocol {
TCP = 2;
}
-message Throughput {
+message Tcp {
Review comment:
Renamed to `TCPInfo` because `TCP` is defined in `enum Protocol`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-data-collect-protocol] wu-sheng commented on a change in pull request #51: Add throughput field for ServiceMeshMetric
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #51:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/51#discussion_r618455496
##########
File path: service-mesh-probe/service-mesh.proto
##########
@@ -56,6 +56,9 @@ message ServiceMeshMetric {
// The sidecar/proxy internal error code, the value bases on the implementation.
// The envoy internal error codes are listed here, https://www.envoyproxy.io/docs/envoy/latest/api-v2/data/accesslog/v2/accesslog.proto#data-accesslog-v2-responseflags
string internalErrorCode = 14;
+
+ // The throughput detail of the mesh metrics.
+ Throughput throughput = 15;
Review comment:
Let's rename this to TCP?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-data-collect-protocol] kezhenxu94 commented on a change in pull request #51: Add throughput field for ServiceMeshMetric
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #51:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/51#discussion_r618452075
##########
File path: service-mesh-probe/service-mesh.proto
##########
@@ -56,6 +56,9 @@ message ServiceMeshMetric {
// The sidecar/proxy internal error code, the value bases on the implementation.
// The envoy internal error codes are listed here, https://www.envoyproxy.io/docs/envoy/latest/api-v2/data/accesslog/v2/accesslog.proto#data-accesslog-v2-responseflags
string internalErrorCode = 14;
+
+ // The throughput detail of the mesh metrics.
+ Throughput throughput = 15;
Review comment:
> But we have OAL related to the latency, if you share the existing one, I think the metrics there would be wrong.
Both of Tcp and Http share the same field `latency`, that said, for TCP, `latency = round trip time`, for HTTP it's what it is now, do you mean the latency would be counted twice for Tcp services? If so, it is not the case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-data-collect-protocol] kezhenxu94 commented on a change in pull request #51: Add throughput field for ServiceMeshMetric
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #51:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/51#discussion_r618489586
##########
File path: service-mesh-probe/service-mesh.proto
##########
@@ -56,6 +56,9 @@ message ServiceMeshMetric {
// The sidecar/proxy internal error code, the value bases on the implementation.
// The envoy internal error codes are listed here, https://www.envoyproxy.io/docs/envoy/latest/api-v2/data/accesslog/v2/accesslog.proto#data-accesslog-v2-responseflags
string internalErrorCode = 14;
+
+ // The throughput detail of the mesh metrics.
+ Throughput throughput = 15;
Review comment:
Like this?
```
message ServiceMeshMetric {
//...
TCP tcp = 15;
//...
}
message TCP {
// The received data in bytes
int64 received = 1;
// The sent data in bytes
int64 sent = 2;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-data-collect-protocol] kezhenxu94 commented on a change in pull request #51: Add throughput field for ServiceMeshMetric
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #51:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/51#discussion_r618493323
##########
File path: service-mesh-probe/service-mesh.proto
##########
@@ -56,6 +56,9 @@ message ServiceMeshMetric {
// The sidecar/proxy internal error code, the value bases on the implementation.
// The envoy internal error codes are listed here, https://www.envoyproxy.io/docs/envoy/latest/api-v2/data/accesslog/v2/accesslog.proto#data-accesslog-v2-responseflags
string internalErrorCode = 14;
+
+ // The throughput detail of the mesh metrics.
+ Throughput throughput = 15;
Review comment:
> Yes, is this good to you?
Good to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-data-collect-protocol] kezhenxu94 commented on a change in pull request #51: Add throughput field for ServiceMeshMetric
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #51:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/51#discussion_r618438787
##########
File path: service-mesh-probe/service-mesh.proto
##########
@@ -56,6 +56,9 @@ message ServiceMeshMetric {
// The sidecar/proxy internal error code, the value bases on the implementation.
// The envoy internal error codes are listed here, https://www.envoyproxy.io/docs/envoy/latest/api-v2/data/accesslog/v2/accesslog.proto#data-accesslog-v2-responseflags
string internalErrorCode = 14;
+
+ // The throughput detail of the mesh metrics.
+ Throughput throughput = 15;
Review comment:
Nearly all the current fields (except for `endpoint`, `responseCode`, `status`) exist in TCP, I can't come out with a better place to put `throughput` atm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-data-collect-protocol] wu-sheng commented on a change in pull request #51: Add throughput field for ServiceMeshMetric
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #51:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/51#discussion_r618845150
##########
File path: service-mesh-probe/service-mesh.proto
##########
@@ -67,11 +67,11 @@ enum Protocol {
TCP = 2;
}
-message Throughput {
+message Tcp {
Review comment:
Should be all upper case, I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-data-collect-protocol] wu-sheng commented on a change in pull request #51: Add throughput field for ServiceMeshMetric
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #51:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/51#discussion_r618430486
##########
File path: service-mesh-probe/service-mesh.proto
##########
@@ -56,6 +56,9 @@ message ServiceMeshMetric {
// The sidecar/proxy internal error code, the value bases on the implementation.
// The envoy internal error codes are listed here, https://www.envoyproxy.io/docs/envoy/latest/api-v2/data/accesslog/v2/accesslog.proto#data-accesslog-v2-responseflags
string internalErrorCode = 14;
+
+ // The throughput detail of the mesh metrics.
+ Throughput throughput = 15;
Review comment:
What is the relationship between TCP and HTTP about the traffic? Does TCP have latency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org