You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "hanahmily (via GitHub)" <gi...@apache.org> on 2023/02/23 15:16:12 UTC

[GitHub] [skywalking-banyandb-java-client] hanahmily opened a new pull request, #36: Tweak Group builders for property operations

hanahmily opened a new pull request, #36:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/36

   This PR is related to https://github.com/apache/skywalking/issues/10413.
   
   The client validated the nullable fields of a `Group`. In this commit, I removed those checkers, adding new `create` functions to build groups for storing properties.
   
   I also update IT's banyandb sha to verify the changes on v0.3.1.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-banyandb-java-client] hanahmily commented on pull request #36: Tweak Group builders for property operations

Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily commented on PR #36:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/36#issuecomment-1442024447

   It looks like I have to release 0.3.1 once this commit gets merged.
   
   On Thu, Feb 23, 2023 at 23:19 吴晟 Wu Sheng ***@***.***> wrote:
   
   > The issue is in the 9.4.0 OAP, do you plan another 0.3.1 client release
   > after this?
   >
   > —
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/skywalking-banyandb-java-client/pull/36#issuecomment-1441965336>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AAO6UWIF43353ZYW53N6ECTWY55WLANCNFSM6AAAAAAVFYPOVQ>
   > .
   > You are receiving this because you authored the thread.Message ID:
   > ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-banyandb-java-client] wu-sheng commented on pull request #36: Tweak Group builders for property operations

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #36:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/36#issuecomment-1442028795

   Let's do that. I just feel maybe we will need 0.3.2 for topN(only feeling :P)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-banyandb-java-client] wu-sheng merged pull request #36: Tweak Group builders for property operations

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #36:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/36


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-banyandb-java-client] wu-sheng commented on pull request #36: Tweak Group builders for property operations

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #36:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/36#issuecomment-1441965336

   The issue is in the 9.4.0 OAP, do you plan another 0.3.1 client release after this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org