[GitHub] rhtyd commented on a change in pull request #2630: Host Affinity plugin

[GitBox <gi...@apache.org>]

rhtyd commented on a change in pull request #2630: Host Affinity plugin
URL: https://github.com/apache/cloudstack/pull/2630#discussion_r186992914
 
 

 ##########
 File path: server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java
 ##########
 @@ -1212,11 +1213,12 @@ private boolean canAvoidCluster(Cluster clusterVO, ExcludeList avoids, ExcludeLi
     }
 
     protected Pair<Host, Map<Volume, StoragePool>> findPotentialDeploymentResources(List<Host> suitableHosts, Map<Volume, List<StoragePool>> suitableVolumeStoragePools,
-            ExcludeList avoid, DeploymentPlanner.PlannerResourceUsage resourceUsageRequired, List<Volume> readyAndReusedVolumes) {
+            ExcludeList avoid, DeploymentPlanner.PlannerResourceUsage resourceUsageRequired, List<Volume> readyAndReusedVolumes, List<Long> preferredHosts) {
         s_logger.debug("Trying to find a potenial host and associated storage pools from the suitable host/pool lists for this VM");
 
         boolean hostCanAccessPool = false;
         boolean haveEnoughSpace = false;
+        boolean hostAffinity = true;
 
 Review comment:
   @nvazquez how about keeping the value to `false` unless the preferredHost list is not? This is fine as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services