You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Benedikt Ritter <br...@apache.org> on 2015/01/28 14:40:56 UTC
Re: svn commit: r1655299 - /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingDataSource.java
Hi Phil,
I prefer {@link Connection Connections}. Looks better in the javadoc report.
Benedikt
2015-01-28 14:27 GMT+01:00 <ps...@apache.org>:
> Author: psteitz
> Date: Wed Jan 28 13:27:51 2015
> New Revision: 1655299
>
> URL: http://svn.apache.org/r1655299
> Log:
> Javadoc typo.
>
> Modified:
>
> commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingDataSource.java
>
> Modified:
> commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingDataSource.java
> URL:
> http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingDataSource.java?rev=1655299&r1=1655298&r2=1655299&view=diff
>
> ==============================================================================
> ---
> commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingDataSource.java
> (original)
> +++
> commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingDataSource.java
> Wed Jan 28 13:27:51 2015
> @@ -46,7 +46,7 @@ import org.apache.commons.pool2.impl.Gen
> public class PoolingDataSource<C extends Connection> implements
> DataSource, AutoCloseable {
>
> private static final Log log =
> LogFactory.getLog(PoolingDataSource.class);
> -
> +
> /** Controls access to the underlying connection */
> private boolean accessToUnderlyingConnectionAllowed = false;
>
> @@ -71,7 +71,7 @@ public class PoolingDataSource<C extends
> }
>
> /**
> - * Close and free all {@link Connections}s from the pool.
> + * Close and free all {@link Connection}s from the pool.
> * @since 2.1
> */
> @Override
>
>
>
--
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter
Re: svn commit: r1655299 - /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingDataSource.java
Posted by Phil Steitz <ph...@gmail.com>.
On 1/28/15 6:40 AM, Benedikt Ritter wrote:
> Hi Phil,
>
> I prefer {@link Connection Connections}. Looks better in the javadoc report.
Fine by me.
Phil
>
> Benedikt
>
> 2015-01-28 14:27 GMT+01:00 <ps...@apache.org>:
>
>> Author: psteitz
>> Date: Wed Jan 28 13:27:51 2015
>> New Revision: 1655299
>>
>> URL: http://svn.apache.org/r1655299
>> Log:
>> Javadoc typo.
>>
>> Modified:
>>
>> commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingDataSource.java
>>
>> Modified:
>> commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingDataSource.java
>> URL:
>> http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingDataSource.java?rev=1655299&r1=1655298&r2=1655299&view=diff
>>
>> ==============================================================================
>> ---
>> commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingDataSource.java
>> (original)
>> +++
>> commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingDataSource.java
>> Wed Jan 28 13:27:51 2015
>> @@ -46,7 +46,7 @@ import org.apache.commons.pool2.impl.Gen
>> public class PoolingDataSource<C extends Connection> implements
>> DataSource, AutoCloseable {
>>
>> private static final Log log =
>> LogFactory.getLog(PoolingDataSource.class);
>> -
>> +
>> /** Controls access to the underlying connection */
>> private boolean accessToUnderlyingConnectionAllowed = false;
>>
>> @@ -71,7 +71,7 @@ public class PoolingDataSource<C extends
>> }
>>
>> /**
>> - * Close and free all {@link Connections}s from the pool.
>> + * Close and free all {@link Connection}s from the pool.
>> * @since 2.1
>> */
>> @Override
>>
>>
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org