You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by JoshRosen <gi...@git.apache.org> on 2014/09/21 01:52:15 UTC
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
GitHub user JoshRosen opened a pull request:
https://github.com/apache/spark/pull/2474
[SPARK-3616] Add basic Selenium tests to WebUISuite
This patch adds Selenium tests for Spark's web UI. To avoid adding extra
dependencies to the test environment, the tests use Selenium's HtmlUnitDriver,
which is pure-Java, instead of, say, ChromeDriver.
I added new tests to try to reproduce a few UI bugs reported on JIRA, namely
SPARK-3021, SPARK-2105, and SPARK-2527. I wasn't able to reproduce these bugs;
I suspect that the older ones might have been fixed by other patches.
In order to use HtmlUnitDriver, I added an explicit dependency on the
org.apache.httpcomponents version of httpclient in order to prevent jets3t's
older version from taking precedence on the classpath.
I also upgraded ScalaTest to 2.2.1.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JoshRosen/spark webui-selenium-tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/2474.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2474
----
commit fb2a0f95b872267440260a36530ae10a51c3e468
Author: Josh Rosen <jo...@apache.org>
Date: 2014-09-17T03:55:28Z
[SPARK-3616] Add basic Selenium tests to WebUISuite.
This patch adds Selenium tests for Spark's web UI. To avoid adding extra
dependencies to the test environment, the tests use Selenium's HtmlUnitDriver,
which is pure-Java, instead of, say, ChromeDriver.
I added new tests to try to reproduce a few UI bugs reported on JIRA, namely
SPARK-3021, SPARK-2105, and SPARK-2527. I wasn't able to reproduce these bugs;
I suspect that the older ones might have been fixed by other patches.
In order to use HtmlUnitDriver, I added an explicit dependency on the
org.apache.httpcomponents version of httpclient in order to prevent jets3t's
older version from taking precedence on the classpath.
I also upgraded ScalaTest to 2.2.1.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-56908052
I'm going to give up and return to this later. Even if I look at the actual classloader that loads BrowserCompatSpecFactory using
```scala
classOf[BrowserCompatSpecFactory].getClassLoader.asInstanceOf[URLClassLoader].getURLs().foreach(println)
```
I _still_ don't see the outdated `httpclient` on the classpath, _nor_ do I see the entire `lib_managed/jars` directory or any other wildcards that might explain why classes are being loaded from the old jar.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-60507640
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22233/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-60502766
[Test build #22226 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22226/consoleFull) for PR 2474 at commit [`510e54a`](https://github.com/apache/spark/commit/510e54aaf9aa56ba2f3e2e892906a08b99827458).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-60501517
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22224/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-56861159
@aniketbhatnagar It looks like both of our patches replace `commons.httpclient` with `httpcomponents`. In this PR, I configured Spark Core to use version 4.3.5 of HttpComponents HttpClient because it seems to be the latest version.
One question, though: how backwards-compatible is the HttpComponents version of HttpClient? Do different versions provide different compatibility guarantees? I found a blog post suggesting that it's not fully compatible: http://blog.teamextension.com/migrating-from-httpclient-3-1-to-4-0-34.
Are there newer versions of the dependencies that depend on HttpClient (e.g. jets3t) which use the newer version?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-56905615
Making a little more progress:
If I add
```scala
import org.apache.http.impl.cookie.BrowserCompatSpecFactory
System.getProperty("java.class.path").split(":").foreach(println)
val f = new File(classOf[BrowserCompatSpecFactory].getProtectionDomain().getCodeSource().getLocation().getPath());
println(f.getAbsolutePath)
```
to the top of UISuite, then it looks like only `/Users/joshrosen/Documents/spark/lib_managed/jars/httpclient-4.3.2.jar` appears on `java.class.path` while it appears that BrowserCompatSpecFactory is being loaded from `/Users/joshrosen/Documents/spark/lib_managed/jars/httpclient-4.1.3.jar` (according to that last print statement).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2474
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-60507639
[Test build #22233 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22233/consoleFull) for PR 2474 at commit [`510e54a`](https://github.com/apache/spark/commit/510e54aaf9aa56ba2f3e2e892906a08b99827458).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-56290962
If the only issue here is test speed, maybe we can disable the slower tests by default on Jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-56871752
Yes, as I recall, Hadoop 1 + S3 requires jets3t 0.7 to work correctly. (Or else we would have also updated it to 0.9). I also believe that 3.x and 4.x of the HTTP libraries are fairly incompatible. Are they actually different artifacts though? Can you let jets3t use 3.x of the old artifact and still freely adjust what version of the 4.x artifact you use? this part I forget, whether they made brand new artifact names for 4.x.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-57027836
Rather than bumping `httpclient`'s version across the board (since there might be binary compatibility issues), I'm going to try changing this PR to specify the newer version only in test-scope.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-56290881
Hmm - O(seconds) is a lot for new tests considering the quantity of tests we have. Is there a constant overhead in launching selenium that gets amortized over future tests we add here? If that's the case it seems fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-60507920
Oh, I see: "scalautils" was renamed to "scalactic" in ScalaTest 2.2.0+. I'd still like to bump ScalaTest so that we're using the newest version of the ScalaTest's Selenium integration and so that we benefit from the [tagged tests improvements](http://www.scalatest.org/release_notes/2.2.0#otherEnhancements):
> Allow multiple -l and -n parameters passed to Runner. The driving use case for this change is to make it easier to write sbt code that will include or exclude different tags in different situations.
I'll push a fixup commit to port us over to the new ScalaTest.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-60501514
[Test build #22224 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22224/consoleFull) for PR 2474 at commit [`510e54a`](https://github.com/apache/spark/commit/510e54aaf9aa56ba2f3e2e892906a08b99827458).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-60510068
[Test build #22236 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22236/consoleFull) for PR 2474 at commit [`fcc9e83`](https://github.com/apache/spark/commit/fcc9e83341127fe7ced3c9c800e8331f0d9bbf18).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by aniketbhatnagar <gi...@git.apache.org>.
Github user aniketbhatnagar commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-56944812
@JoshRosen adding to what mentioned, here is a gist of dependency tree before and after my patch would be applied - https://gist.github.com/aniketbhatnagar/b39e587d4f4a014870d1
As @srowen, httpclient seems to be coming from Thrift via Hive and what my patch attempts to do is force a newer (& compatible) version of the library in Kinesis-asl profile only.
Hope it helps.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-56903432
It looks like this isn't an issue in the Maven build. Investigating to see if I can figure out how the older JAR is winding up on the SBT test classpath.
When I run `sbt/sbt "show core/test:full-classpath"`,`httpclient-4.1.3.jar` doesn't show up in the list, but it definitely seems to be getting used at runtime...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-56284177
[QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20614/consoleFull) for PR 2474 at commit [`fb2a0f9`](https://github.com/apache/spark/commit/fb2a0f95b872267440260a36530ae10a51c3e468).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-56285340
[QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20614/consoleFull) for PR 2474 at commit [`fb2a0f9`](https://github.com/apache/spark/commit/fb2a0f95b872267440260a36530ae10a51c3e468).
* This patch **passes** unit tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `abstract class LogicalPlan extends QueryPlan[LogicalPlan] with Logging `
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-56411152
Note to self / reviewers: #2489 addresses another httpclient dependency issue and will probably conflict with this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-60503604
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22226/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-56932682
@JoshRosen It looks like HttpClient 4.1.3 comes in from Thrift via Hive:
```
mvn dependency:tree
...
[INFO] org.apache.spark:spark-hive_2.10:jar:1.2.0-SNAPSHOT
...
[INFO] +- org.spark-project.hive:hive-serde:jar:0.12.0:compile
[INFO] | +- org.spark-project.hive:hive-common:jar:0.12.0:compile
[INFO] | | +- org.spark-project.hive:hive-shims:jar:0.12.0:compile
[INFO] | | \- commons-cli:commons-cli:jar:1.2:compile
[INFO] | +- org.mockito:mockito-all:jar:1.9.0:test (version managed from 1.8.2; scope managed from compile)
[INFO] | \- org.apache.thrift:libfb303:jar:0.9.0:compile
[INFO] | \- org.apache.thrift:libthrift:jar:0.9.0:compile
[INFO] | +- org.apache.httpcomponents:httpclient:jar:4.1.3:compile
[INFO] | \- org.apache.httpcomponents:httpcore:jar:4.1.3:compile
```
... but that's weird if it has some effect on core tests, of course. This could be a red herring, but that's where 4.1.3 may be coming from, and then sticking around and getting put on some classpath.
This method went in late November 2012:
https://apache.googlesource.com/httpclient/+blame/ff1acb48a875b54319fed9da87d1942d4d0d9db3/httpclient/src/main/java/org/apache/http/impl/cookie/BrowserCompatSpecFactory.java
So would be in about version 4.2.3 or higher:
https://hc.apache.org/news.html
... which you probably already figured, that 4.1.3 (or some copy from earlier than about 4.2.3) must be the problem. (I think that the 3.x artifacts aren't an issue, because they're different artifacts.)
In your patch, you don't make `httpclient` a `test` scope dependency. I would try that as I know the transitive dep rules are weird in `test` scope. Maybe that actually forces the desired behavior. Try `mvn dependency:tree` as well to get its opinion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-60506745
Jenkins, this is ok to test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-56908350
Actually, @ScrapCodes, do you have any ideas of what I should try here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-60506747
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-60507546
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22232/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-56286298
@JoshRosen how much time does this add to the test harness?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by aniketbhatnagar <gi...@git.apache.org>.
Github user aniketbhatnagar commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-56822657
Agreed that this can indeed cause conflicts. @JoshRosen, do you know which version of httpclient does this change effectively resolves to?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-60503603
[Test build #22226 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22226/consoleFull) for PR 2474 at commit [`510e54a`](https://github.com/apache/spark/commit/510e54aaf9aa56ba2f3e2e892906a08b99827458).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-56286662
@pwendell [According to Jenkins](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20614/testReport/org.apache.spark.ui/UISuite/), UISuite took ~11 seconds to run, [compared to ~2.9 seconds](https://amplab.cs.berkeley.edu/jenkins/job/Spark-Master-SBT/700/AMPLAB_JENKINS_BUILD_PROFILE=hadoop1.0,label=centos/testReport/org.apache.spark.ui/UISuite/) before this PR (although three of the tests were previously disabled).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-60526870
I've merged this into master. I'm going to close out a few of the old, unreproducible UI JIRAs for which I've added Selenium regression tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-56892116
> Are they actually different artifacts though? Can you let jets3t use 3.x of the old artifact and still freely adjust what version of the 4.x artifact you use?
Hmm, they _are_ actually different artifacts. Maybe HttpClient itself isn't the problem here. Here's the actual exception that I get if I undo my Maven changes:
```
[error] Uncaught exception when running org.apache.spark.ui.UISuite: java.lang.NoSuchMethodError: org.apache.http.impl.cookie.BrowserCompatSpecFactory.create(Lorg/apache/http/protocol/HttpContext;)Lorg/apache/http/cookie/CookieSpec;
sbt.ForkMain$ForkError: org.apache.http.impl.cookie.BrowserCompatSpecFactory.create(Lorg/apache/http/protocol/HttpContext;)Lorg/apache/http/cookie/CookieSpec;
at com.gargoylesoftware.htmlunit.CookieManager.<init>(CookieManager.java:61)
at com.gargoylesoftware.htmlunit.WebClient.<init>(WebClient.java:132)
at org.openqa.selenium.htmlunit.HtmlUnitDriver.newWebClient(HtmlUnitDriver.java:288)
at org.openqa.selenium.htmlunit.HtmlUnitDriver.createWebClient(HtmlUnitDriver.java:262)
at org.openqa.selenium.htmlunit.HtmlUnitDriver.<init>(HtmlUnitDriver.java:147)
at org.openqa.selenium.htmlunit.HtmlUnitDriver.<init>(HtmlUnitDriver.java:191)
at org.openqa.selenium.htmlunit.HtmlUnitDriver.<init>(HtmlUnitDriver.java:187)
at org.apache.spark.ui.UISuite.<init>(UISuite.scala:40)
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57)
at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:526)
at java.lang.Class.newInstance(Class.java:374)
at org.scalatest.tools.Framework$ScalaTestTask.execute(Framework.scala:641)
at sbt.ForkMain$Run$2.call(ForkMain.java:294)
at sbt.ForkMain$Run$2.call(ForkMain.java:284)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-57026691
@srowen
> In your patch, you don't make httpclient a test scope dependency.
Actually, the code in this PR works fine (note that the SparkQA tests passed). The issue that I was referring to crops up when I remove the `httpclient` dependencies added by this PR and attempt to run the `UISuite` tests. In that case, it seems that the older JAR is somehow being used even though it doesn't appear on the classpath _and_ doesn't appear in SBT's dependency-tree.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-60506855
[Test build #22233 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22233/consoleFull) for PR 2474 at commit [`510e54a`](https://github.com/apache/spark/commit/510e54aaf9aa56ba2f3e2e892906a08b99827458).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-60500321
Thanks to the Hive 13 patch being merged, it's no longer necessary for me to add an explicit version of httpclient. I've pushed a new commit which moves these Selenium tests to their own suite which isn't run by default. For now, the only way to run this suite is to manually uncomment the `@DoNotDiscover` annotation; I've opened a ticket with ScalaTest to fix support for manually running this test in SBT (https://github.com/scalatest/scalatest/issues/417).
Once this passes tests, I'm going to merge this so that I can use this basic test framework in some subsequent PRs to fix a few display bugs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-56896479
When I wiped out my `lib_managed/jars` directory and ran `sbt/sbt clean package` followed by an interactive sbt session where I ran
```
project core
test-only org.apache.spark.ui.UISuite
```
then it looks like `httpclient-4.1.3.jar` somehow gets downloaded into `lib_managed` and ends up on the classpath during tests, even though nothing seems to depend on it, at least according to `dependency-graph`. This is puzzling.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-60507817
I tried downloading and building this locally and it looks like there's a legitimate build failure in Catalyst:
```
[info] Compiling 19 Scala sources to /Users/joshrosen/Documents/spark/sql/catalyst/target/scala-2.10/test-classes...
[error] /Users/joshrosen/Documents/spark/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvaluationSuite.scala:26: object scalautils is not a member of package org
[error] import org.scalautils.TripleEqualsSupport.Spread
[error] ^
[error] /Users/joshrosen/Documents/spark/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvaluationSuite.scala:137: not found: type Spread
[error] def checkDoubleEvaluation(expression: Expression, expected: Spread[Double], inputRow: Row = EmptyRow): Unit = {
[error] ^
[error] /Users/joshrosen/Documents/spark/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvaluationSuite.scala:141: Cannot prove that Double <:< AnyRef.
[error] actual.asInstanceOf[Double] shouldBe expected
[error] ^
[error] three errors found
[error] (catalyst/test:compile) Compilation failed
[error] Total time: 64 s, completed Oct 25, 2014 11:07:55 PM
```
This looks like a legitimate build failure, but I'm not sure how this PR could have caused it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-60502653
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-56866626
It looks like we determine the jets3t version based on which Hadoop version we're using. Based on discussion in #629, it looks like we need to keep doing this rather than updating to 0.9.x across the board, since older Hadoop versions need the older version. Unfortunately, jets3t 0.7. depends on commons-httpclient:3.1. @srowen, do you have any thoughts here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-60510069
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22236/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-60506754
[Test build #22232 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22232/consoleFull) for PR 2474 at commit [`510e54a`](https://github.com/apache/spark/commit/510e54aaf9aa56ba2f3e2e892906a08b99827458).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-60500399
[Test build #22224 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22224/consoleFull) for PR 2474 at commit [`510e54a`](https://github.com/apache/spark/commit/510e54aaf9aa56ba2f3e2e892906a08b99827458).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-60507543
[Test build #22232 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22232/consoleFull) for PR 2474 at commit [`510e54a`](https://github.com/apache/spark/commit/510e54aaf9aa56ba2f3e2e892906a08b99827458).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3616] Add basic Selenium tests to WebUI...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2474#issuecomment-60508440
[Test build #22236 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22236/consoleFull) for PR 2474 at commit [`fcc9e83`](https://github.com/apache/spark/commit/fcc9e83341127fe7ced3c9c800e8331f0d9bbf18).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org