[jira] [Commented] (HADOOP-17098) Reduce Guava dependency in Hadoop source code

["Ahmed Hussein (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-17098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149460#comment-17149460 ] 

Ahmed Hussein commented on HADOOP-17098:
----------------------------------------

Thanks you everyone for the feedback.

{quote}Thanx Ahmed Hussein for initiating this, Shall be great if this can be done. Let me know for any help on this{quote}

I am going to need help definitely especially for reviewing and committing the subtasks. I am not sure what is the best way to coordinate the reviews moving forward.
I was thinking about creating Google sheet, but I am reluctant that it will add more overhead on reviewers. Let me know if you have any suggestions.

Please feel free to create subtasks or assign any of the tasks to other developers as well.
Some tasks can be suitable for onboarding and newbies. There is a lot of work to be done here anyway.

> Reduce Guava dependency in Hadoop source code
> ---------------------------------------------
>
>                 Key: HADOOP-17098
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17098
>             Project: Hadoop Common
>          Issue Type: Task
>            Reporter: Ahmed Hussein
>            Assignee: Ahmed Hussein
>            Priority: Major
>
> Relying on Guava implementation in Hadoop has been painful due to compatibility and vulnerability issues.
>  Guava updates tend to break/deprecate APIs. This made It hard to maintain backward compatibility within hadoop versions and clients/downstreams.
> With 3.x uses java8+, the java 8 features should preferred to Guava, reducing the footprint, and giving stability to source code.
> This jira should serve as an umbrella toward an incremental effort to reduce the usage of Guava in the source code and to create subtasks to replace Guava classes with Java features.
> Furthermore, it will be good to add a rule in the pre-commit build to warn against introducing a new Guava usage in certain modules.
> Any one willing to take part in this code refactoring has to:
>  # Focus on one module at a time in order to reduce the conflicts and the size of the patch. This will significantly help the reviewers.
>  # Run all the unit tests related to the module being affected by the change. It is critical to verify that any change will not break the unit tests, or cause a stable test case to become flaky.
>  
> A list of sub tasks replacing Guava APIs with java8 features:
> {code:java}
> com.google.common.io.BaseEncoding#base64()	java.util.Base64
> com.google.common.io.BaseEncoding#base64Url()	java.util.Base64
> com.google.common.base.Joiner.on()	                        java.lang.String#join() or 
>                                                                                          java.util.stream.Collectors#joining()
> com.google.common.base.Optional#of()	                java.util.Optional#of()
> com.google.common.base.Optional#absent()	        java.util.Optional#empty()
> com.google.common.base.Optional#fromNullable()	java.util.Optional#ofNullable()
> com.google.common.base.Optional	                        java.util.Optional
> com.google.common.base.Predicate	                        java.util.function.Predicate
> com.google.common.base.Function	                        java.util.function.Function
> com.google.common.base.Supplier	                        java.util.function.Supplier
> {code}
>  
> I also vote for the replacement of {{Precondition}} with either a wrapper, or Apache commons lang.
> I believe you guys have dealt with Guava compatibilities in the past and probably have better insights. Any thoughts? [~weichiu], [~gabor.bota], [~stevel@apache.org], [~ayushtkn], [~busbey], [~jeagles], [~kihwal]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org