[GitHub] [spark] Tonix517 opened a new pull request #25055: [SPARK-28189] Use semanticEquals in Dataset drop method for attributes comparison

[GitBox <gi...@apache.org>]

Tonix517 opened a new pull request #25055: [SPARK-28189] Use semanticEquals in Dataset drop method for attributes comparison
URL: https://github.com/apache/spark/pull/25055
 
 
   ## What changes were proposed in this pull request?
   
   In Dataset drop(col: Column) method, the `equals` comparison method was used instead of `semanticEquals`, which caused the problem of abnormal case-sensitivity behavior. When attributes of LogicalPlan are checked for equality, `semanticEquals` should be used instead.
   
   A similar PR I referred to: https://github.com/apache/spark/pull/22713 created by @mgaido91 
   
   ## How was this patch tested?
   
   - Added new unit test case in DataFrameSuite
   - ./build/sbt "testOnly org.apache.spark.sql.*"
   - The python code from ticket reporter at https://issues.apache.org/jira/browse/SPARK-28189
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org