You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Henri Yandell (JIRA)" <ji...@apache.org> on 2008/02/28 06:47:51 UTC

[jira] Updated: (SANDBOX-219) ExtendedBufferedReader does too much

     [ https://issues.apache.org/jira/browse/SANDBOX-219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henri Yandell updated SANDBOX-219:
----------------------------------

    Attachment: SANDBOX-219.patch

Patch that strips out the unnecessary code. Class has already been made package private.

> ExtendedBufferedReader does too much
> ------------------------------------
>
>                 Key: SANDBOX-219
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-219
>             Project: Commons Sandbox
>          Issue Type: Task
>          Components: CSV
>            Reporter: Henri Yandell
>         Attachments: SANDBOX-219.patch
>
>
> There is unnecessary work in ExtendedBufferedReader. 
> It offers:
> skip(long)
> skipUntil(char)
> readUntil(char)
> none are ever called. skip(long) is required to fulfill the superclass, but could be stubbed out as it's never called.
> The class is also unnecessarily public for CSV's uses.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.