You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/24 18:05:43 UTC

[GitHub] [spark] tanelk commented on a change in pull request #31955: [SPARK-34829][SQL] Fix typed ScalaUDF result conversion

tanelk commented on a change in pull request #31955:
URL: https://github.com/apache/spark/pull/31955#discussion_r600734387



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
##########
@@ -2755,6 +2755,13 @@ class DataFrameSuite extends QueryTest
     )
     checkAnswer(test.select($"best_name.name"), Row("bob") :: Row("bob") :: Row("sam") :: Nil)
   }
+
+  test("SPARK-34829: Typed ScalaUDF result conversion works") {

Review comment:
       You made a change in both branches of the `if (enc.isSerializedAsStructForTopLevel)`. Does this UT cover them both?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org