You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/09/26 20:01:45 UTC
Review Request: Minor tweaks to ZooKeeper libprocess wrapper (a comment
update and a minor change to be more conservative with use cases).
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7294/
-----------------------------------------------------------
Review request for mesos, John Sirois, Vinod Kone, and Ben Mahler.
Description
-------
See summary (6 of 7).
Diffs
-----
src/zookeeper/watcher.hpp b29bf7b
Diff: https://reviews.apache.org/r/7294/diff/
Testing
-------
make check (but test from https://reviews.apache.org/r/7293 is still failing).
Thanks,
Benjamin Hindman
Re: Review Request: Minor tweaks to ZooKeeper libprocess wrapper (a comment
update and a minor change to be more conservative with use cases).
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7294/#review11944
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Sept. 26, 2012, 6:01 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7294/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2012, 6:01 p.m.)
>
>
> Review request for mesos, John Sirois, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> See summary (6 of 7).
>
>
> Diffs
> -----
>
> src/zookeeper/watcher.hpp b29bf7b
>
> Diff: https://reviews.apache.org/r/7294/diff/
>
>
> Testing
> -------
>
> make check (but test from https://reviews.apache.org/r/7293 is still failing).
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Minor tweaks to ZooKeeper libprocess wrapper (a comment
update and a minor change to be more conservative with use cases).
Posted by John Sirois <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7294/#review11954
-----------------------------------------------------------
Ship it!
Ship It!
- John Sirois
On Sept. 26, 2012, 6:01 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7294/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2012, 6:01 p.m.)
>
>
> Review request for mesos, John Sirois, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> See summary (6 of 7).
>
>
> Diffs
> -----
>
> src/zookeeper/watcher.hpp b29bf7b
>
> Diff: https://reviews.apache.org/r/7294/diff/
>
>
> Testing
> -------
>
> make check (but test from https://reviews.apache.org/r/7293 is still failing).
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Minor tweaks to ZooKeeper libprocess wrapper (a comment
update and a minor change to be more conservative with use cases).
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Sept. 27, 2012, 9:31 p.m., Ben Mahler wrote:
> > src/zookeeper/watcher.hpp, line 12
> > <https://reviews.apache.org/r/7294/diff/1/?file=160215#file160215line12>
> >
> > So why do we want to re-use watchers? Seems like it's adding complexity..?
It's more for safety (can't easily keep someone from reusing the watcher, so it's better to be conservative and assume it might happen).
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7294/#review12001
-----------------------------------------------------------
On Sept. 26, 2012, 6:01 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7294/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2012, 6:01 p.m.)
>
>
> Review request for mesos, John Sirois, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> See summary (6 of 7).
>
>
> Diffs
> -----
>
> src/zookeeper/watcher.hpp b29bf7b
>
> Diff: https://reviews.apache.org/r/7294/diff/
>
>
> Testing
> -------
>
> make check (but test from https://reviews.apache.org/r/7293 is still failing).
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Minor tweaks to ZooKeeper libprocess wrapper (a comment
update and a minor change to be more conservative with use cases).
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7294/#review12001
-----------------------------------------------------------
src/zookeeper/watcher.hpp
<https://reviews.apache.org/r/7294/#comment25569>
So why do we want to re-use watchers? Seems like it's adding complexity..?
- Ben Mahler
On Sept. 26, 2012, 6:01 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7294/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2012, 6:01 p.m.)
>
>
> Review request for mesos, John Sirois, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> See summary (6 of 7).
>
>
> Diffs
> -----
>
> src/zookeeper/watcher.hpp b29bf7b
>
> Diff: https://reviews.apache.org/r/7294/diff/
>
>
> Testing
> -------
>
> make check (but test from https://reviews.apache.org/r/7293 is still failing).
>
>
> Thanks,
>
> Benjamin Hindman
>
>