You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/12/16 01:06:00 UTC
[GitHub] [superset] graceguo-supercat commented on a change in pull request #17751: fix: [alert] add tooltip message for alert threshold value
graceguo-supercat commented on a change in pull request #17751:
URL: https://github.com/apache/superset/pull/17751#discussion_r770150996
##########
File path: superset-frontend/src/views/CRUD/alert/AlertReportModal.tsx
##########
@@ -1183,7 +1184,12 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({
</StyledInputContainer>
<StyledInputContainer>
<div className="control-label">
- {t('Value')}
+ {t('Value')}{' '}
+ <InfoTooltipWithTrigger
+ tooltip={t(
+ 'Threshold value should be double precision number',
Review comment:
double precision number could be integer or float right?
And, if you type in `3.14159265358979323846264338327950288419716939937510` it will be truncated to `3.141592653589793`. I think it is necessary to let users know there is a limit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org