You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2020/06/05 22:47:33 UTC
[Impala-ASF-CR] IMPALA-9835: make kudu scan token binary
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16040
Change subject: IMPALA-9835: make kudu_scan_token binary
......................................................................
IMPALA-9835: make kudu_scan_token binary
We got log spam from protobufs because the scan
tokens are not valid UTF-8 (and not intended to
be).
Change-Id: I2db9e4aad777065f6bf6ab1c9add3c99e8a0cf0a
---
M common/protobuf/planner.proto
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/16040/1
--
To view, visit http://gerrit.cloudera.org:8080/16040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2db9e4aad777065f6bf6ab1c9add3c99e8a0cf0a
Gerrit-Change-Number: 16040
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9835: make kudu scan token binary
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16040 )
Change subject: IMPALA-9835: make kudu_scan_token binary
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2db9e4aad777065f6bf6ab1c9add3c99e8a0cf0a
Gerrit-Change-Number: 16040
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Jun 2020 15:18:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9835: make kudu scan token binary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16040 )
Change subject: IMPALA-9835: make kudu_scan_token binary
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6228/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2db9e4aad777065f6bf6ab1c9add3c99e8a0cf0a
Gerrit-Change-Number: 16040
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Jun 2020 23:34:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9835: make kudu scan token binary
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16040 )
Change subject: IMPALA-9835: make kudu_scan_token binary
......................................................................
IMPALA-9835: make kudu_scan_token binary
We got log spam from protobufs because the scan
tokens are not valid UTF-8 (and not intended to
be).
Change-Id: I2db9e4aad777065f6bf6ab1c9add3c99e8a0cf0a
Reviewed-on: http://gerrit.cloudera.org:8080/16040
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Thomas Tauber-Marshall <tm...@cloudera.com>
---
M common/protobuf/planner.proto
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Verified
Thomas Tauber-Marshall: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2db9e4aad777065f6bf6ab1c9add3c99e8a0cf0a
Gerrit-Change-Number: 16040
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
[Impala-ASF-CR] IMPALA-9835: make kudu scan token binary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16040 )
Change subject: IMPALA-9835: make kudu_scan_token binary
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5952/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/16040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2db9e4aad777065f6bf6ab1c9add3c99e8a0cf0a
Gerrit-Change-Number: 16040
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Jun 2020 22:48:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9835: make kudu scan token binary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16040 )
Change subject: IMPALA-9835: make kudu_scan_token binary
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2db9e4aad777065f6bf6ab1c9add3c99e8a0cf0a
Gerrit-Change-Number: 16040
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 06 Jun 2020 04:08:06 +0000
Gerrit-HasComments: No