You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/05/14 11:11:03 UTC

[GitHub] [cordova-plugin-inappbrowser] flexaddicted opened a new pull request #874: feat(iOS): Integrate Auto Layout to render UI

flexaddicted opened a new pull request #874:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/874


   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   iOS
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   
   The changes proposed through this PR have been introduced to make easier the management of the User Interface through Auto Layout. In fact, Auto Layout is now the de facto standard to handle layout in iOS.
   Additionally the creation of the components has been refactored in order to have identify clearly them within the code.
   
   ### Description
   <!-- Describe your changes in detail -->
   
   These are the changes in detail:
   
   - Replace frame based layout with Auto Layout.
   - Create separate methods used to create all the elements of the user interface.
   - Add an additional property, called `extendwebviewtobottom`, to extend the web view besides the bottom safe area.
   - Code cleanup.
   - Remove unused or deprecated code.
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   
   I've tested all the possible configuration available with the web UI.
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [x] I've updated the documentation if necessary
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-plugin-inappbrowser] flexaddicted edited a comment on pull request #874: feat(iOS): Integrate Auto Layout to render UI

Posted by GitBox <gi...@apache.org>.
flexaddicted edited a comment on pull request #874:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/874#issuecomment-841180292


   @NiklasMerz hope this PR will help to improve this plugin for future changes...there is a lot of work to be done but I think this is just a start.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-plugin-inappbrowser] flexaddicted commented on pull request #874: feat(iOS): Integrate Auto Layout to render UI

Posted by GitBox <gi...@apache.org>.
flexaddicted commented on pull request #874:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/874#issuecomment-841180292


   @NiklasMerz hope this PR will help to build improve this plugin for future changes...there is a lot of work to be done but I think this is just a start.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org