You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-dev@hadoop.apache.org by "Jakob Homan (JIRA)" <ji...@apache.org> on 2010/10/18 23:10:37 UTC
[jira] Resolved: (HDFS-1456) Provide builder for constructing
instances of MiniDFSCluster
[ https://issues.apache.org/jira/browse/HDFS-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan resolved HDFS-1456.
-------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
The commented-out calls were in the original code and got converted during the autorefactor. To minimize change - heh - I left them in. Thanks for the review. I've committed this. Resolving as fixed.
> Provide builder for constructing instances of MiniDFSCluster
> ------------------------------------------------------------
>
> Key: HDFS-1456
> URL: https://issues.apache.org/jira/browse/HDFS-1456
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.22.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.22.0
>
> Attachments: HDFS-1456-2.patch, HDFS-1456.patch
>
>
> Time to fix a broken window. Of the 293 occurences of "new MiniDFSCluster("... most look something like:
> {noformat}cluster = new MiniDFSCluster(0, config, numDatanodes, true, false, true, null, null, null, null);{noformat}
> The largest constructor takes 10 parameters, and even the overloaded constructors can be difficult to read as their mainaly nulls or booleans.
> We should provide a Builder for constructing MiniDFSClusters to improve readability.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.