You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2021/03/29 14:45:55 UTC

[GitHub] [kylin] zzcclp commented on a change in pull request #1603: KYLIN-4918 Support Cube Level configuration in FilePruner

zzcclp commented on a change in pull request #1603:
URL: https://github.com/apache/kylin/pull/1603#discussion_r603356675



##########
File path: kylin-spark-project/kylin-spark-common/src/main/scala/org/apache/spark/sql/execution/datasource/FilePruner.scala
##########
@@ -78,6 +77,8 @@ class FilePruner(cubeInstance: CubeInstance,
                  val options: Map[String, String])
   extends FileIndex with ResetShufflePartition with Logging {
 
+  val MAX_SHARDING_SIZE_PER_TASK: Long = cubeInstance.getConfig.getMaxShardingSizeMBPerTask * 1024 * 1024

Review comment:
       this line will exceed 100 chars, please change to:
   ```
     val MAX_SHARDING_SIZE_PER_TASK: Long =
       cubeInstance.getConfig.getMaxShardingSizeMBPerTask * 1024 * 1024
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org